Changeset 116636 in webkit


Ignore:
Timestamp:
May 10, 2012 6:15:47 AM (12 years ago)
Author:
noel.gordon@gmail.com
Message:

Source/WebCore: [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772

Reviewed by Kent Tamura.

On some JPEG images, vertical and horizontal lines artifacts might appear in image
regions with very high frequency color variation when using DCT_IFAST decodes. Use
DCT_IFAST on small screen devices only (Chromium Android).

No new tests. Covered by existing tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(dctMethod): Permit DCT_IFAST decoding for Chromium Android only.

LayoutTests: [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
https://bugs.webkit.org/show_bug.cgi?id=85772

Reviewed by Kent Tamura.

  • platform/chromium/test_expectations.txt: Add IMAGE expectations.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r116635 r116636  
     12012-05-10  Noel Gordon  <noel.gordon@gmail.com>
     2
     3        [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
     4        https://bugs.webkit.org/show_bug.cgi?id=85772
     5
     6        Reviewed by Kent Tamura.
     7
     8        * platform/chromium/test_expectations.txt: Add IMAGE expectations.
     9
    1102012-05-10  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    211
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r116592 r116636  
    29742974
    29752975// ICC color profiles are not supported on WIN, LINUX so SKIP for now.
    2976 BUGWK70001 SKIP LINUX WIN : fast/images/color-jpeg-with-color-profile.html = FAIL MISSING
     2976BUGWK70001 SKIP LINUX WIN : fast/images/color-jpeg-with-color-profile.html = FAIL IMAGE MISSING
    29772977
    29782978// V8 handles stack overflow exceptions differently than JSC
     
    33593359// Tests still flaky on the given platforms. They may not actually be flaky, but prior to
    33603360// a rebaselining they were showing inconsistent results.
    3361 BUGWK81631 WIN LINUX DEBUG : tables/mozilla_expected_failures/bugs/bug85016.html = IMAGE PASS
     3361BUGWK81631 WIN LINUX : tables/mozilla_expected_failures/bugs/bug85016.html = IMAGE PASS
    33623362BUGWK81631 WIN LINUX DEBUG : fast/writing-mode/block-level-images.html = IMAGE PASS
    33633363BUGWK81631 MAC : tables/mozilla_expected_failures/bugs/bug85016.html = IMAGE PASS
    3364 BUGWK81631 MAC : fast/repaint/block-layout-inline-children-replaced.html = IMAGE PASS
     3364BUGWK81631 : fast/repaint/block-layout-inline-children-replaced.html = IMAGE PASS
    33653365BUGWK81631 MAC : fast/writing-mode/block-level-images.html = IMAGE PASS
    33663366BUGWK81631 MAC : fast/table/quote-text-around-iframe.html = IMAGE PASS
     
    38683868BUGWK83954 : fast/table/spanOverlapRepaint.html = TEXT
    38693869BUGWK83954 : fast/table/text-field-baseline.html = TEXT
    3870 BUGWK83954 : tables/mozilla/bugs/bug1188.html = TEXT
     3870BUGWK83954 : tables/mozilla/bugs/bug1188.html = IMAGE TEXT
    38713871BUGWK83954 WIN LINUX : fast/block/float/avoiding-float-centered.html = TEXT
    38723872BUGWK83954 WIN LINUX : fast/clip/008.html = TEXT
     
    38763876BUGWK83954 : http/tests/navigation/javascriptlink-frames.html = TEXT
    38773877BUGWK83954 : fast/forms/date/date-appearance.html = TEXT
     3878
     3879BUGNOEL : compositing/geometry/horizontal-scroll-composited.html = IMAGE
     3880BUGNOEL : compositing/geometry/vertical-scroll-composited.html = IMAGE
     3881BUGNOEL : fast/backgrounds/size/backgroundSize17.html = IMAGE
     3882BUGNOEL : fast/backgrounds/size/backgroundSize18.html = IMAGE
     3883BUGNOEL : fast/backgrounds/size/backgroundSize19.html = IMAGE
     3884BUGNOEL : fast/backgrounds/size/backgroundSize20.html = IMAGE
     3885BUGNOEL : fast/backgrounds/size/backgroundSize21.html = IMAGE
     3886BUGNOEL : fast/backgrounds/size/backgroundSize22.html = IMAGE
     3887BUGNOEL : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE
     3888BUGNOEL : fast/backgrounds/size/contain-and-cover.html = IMAGE
     3889BUGNOEL : fast/block/float/014.html = IMAGE
     3890BUGNOEL : fast/css/line-height-determined-by-primary-font.html = IMAGE
     3891BUGNOEL : fast/images/gray-scale-jpeg-with-color-profile.html = IMAGE
     3892BUGNOEL : fast/images/image-css3-content-data.html = IMAGE
     3893BUGNOEL : fast/images/rgb-jpeg-with-adobe-marker-only.html = IMAGE
     3894BUGNOEL : fast/images/ycbcr-with-cmyk-color-profile.html = IMAGE
     3895BUGNOEL : fast/repaint/backgroundSizeRepaint.html = IMAGE
     3896BUGNOEL : fast/repaint/clipped-relative.html = IMAGE
     3897BUGNOEL : fast/repaint/selected-replaced.html = IMAGE
     3898BUGNOEL : fast/replaced/absolute-image-sizing.html = IMAGE
     3899BUGNOEL : fast/replaced/image-onload.html = IMAGE
     3900BUGNOEL : fast/replaced/image-sizing.html = IMAGE
     3901BUGNOEL : fast/replaced/image-tag.html = IMAGE
     3902BUGNOEL : fast/replaced/width100percent-image.html = IMAGE
     3903BUGNOEL : fast/writing-mode/background-horizontal-bt.html = IMAGE
     3904BUGNOEL : fast/writing-mode/background-vertical-lr.html = IMAGE
     3905BUGNOEL : fast/writing-mode/background-vertical-rl.html = IMAGE
     3906BUGNOEL : platform/chromium/compositing/img-layer-grow.html = IMAGE
     3907BUGNOEL : svg/W3C-SVG-1.1/animate-elem-30-t.svg = IMAGE
     3908BUGNOEL : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
     3909BUGNOEL : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
     3910BUGNOEL : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE
     3911BUGNOEL : svg/W3C-SVG-1.1/coords-viewattr-02-b.svg = IMAGE
     3912BUGNOEL : svg/W3C-SVG-1.1/filters-image-01-b.svg = IMAGE
     3913BUGNOEL : svg/W3C-SVG-1.1/struct-image-01-t.svg = IMAGE
     3914BUGNOEL : svg/W3C-SVG-1.1/struct-image-02-b.svg = IMAGE
     3915BUGNOEL : svg/W3C-SVG-1.1/struct-image-04-t.svg = IMAGE
     3916BUGNOEL : svg/carto.net/scrollbar.svg = IMAGE
     3917BUGNOEL : svg/carto.net/selectionlist.svg = IMAGE
     3918BUGNOEL : svg/custom/image-rescale-clip.html = IMAGE
     3919BUGNOEL : svg/custom/image-rescale-scroll.html = IMAGE
     3920BUGNOEL : svg/custom/image-rescale.svg = IMAGE
     3921BUGNOEL : svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html = IMAGE
     3922BUGNOEL : svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html = IMAGE
     3923BUGNOEL : svg/repaint/image-href-change.svg = IMAGE
     3924BUGNOEL : tables/mozilla/bugs/bug101674.html = IMAGE
     3925BUGNOEL : tables/mozilla/bugs/bug10565.html = IMAGE
     3926BUGNOEL : tables/mozilla/bugs/bug11026.html = IMAGE
     3927BUGNOEL : tables/mozilla/bugs/bug120107.html = IMAGE
     3928BUGNOEL : tables/mozilla/bugs/bug1271.html = IMAGE
     3929BUGNOEL : tables/mozilla/bugs/bug12908-1.html = IMAGE
     3930BUGNOEL : tables/mozilla/bugs/bug12908-2.html = IMAGE
     3931BUGNOEL : tables/mozilla/bugs/bug1296.html = IMAGE
     3932BUGNOEL : tables/mozilla/bugs/bug13169.html = IMAGE
     3933BUGNOEL : tables/mozilla/bugs/bug1430.html = IMAGE
     3934BUGNOEL : tables/mozilla/bugs/bug15544.html = IMAGE
     3935BUGNOEL : tables/mozilla/bugs/bug17138.html = IMAGE
     3936BUGNOEL : tables/mozilla/bugs/bug196870.html = IMAGE
     3937BUGNOEL : tables/mozilla/bugs/bug29314.html = IMAGE
     3938BUGNOEL : tables/mozilla/bugs/bug2981-2.html = IMAGE
     3939BUGNOEL : tables/mozilla/bugs/bug4093.html = IMAGE
     3940BUGNOEL : tables/mozilla/bugs/bug4284.html = IMAGE
     3941BUGNOEL : tables/mozilla/bugs/bug4427.html = IMAGE
     3942BUGNOEL : tables/mozilla/bugs/bug50695-2.html = IMAGE
     3943BUGNOEL : tables/mozilla/bugs/bug56563.html = IMAGE
     3944BUGNOEL : tables/mozilla/bugs/bug5797.html = IMAGE
     3945BUGNOEL : tables/mozilla/bugs/bug625.html = IMAGE
     3946BUGNOEL : tables/mozilla/bugs/bug6404.html = IMAGE
     3947BUGNOEL : tables/mozilla/bugs/bug82946-2.html = IMAGE
     3948BUGNOEL : tables/mozilla/bugs/bug86708.html = IMAGE
     3949BUGNOEL : tables/mozilla/core/bloomberg.html = IMAGE
     3950BUGNOEL : tables/mozilla/core/col_widths_auto_autoFix.html = IMAGE
     3951BUGNOEL : tables/mozilla/core/misc.html = IMAGE
     3952BUGNOEL : tables/mozilla/core/row_span.html = IMAGE
     3953BUGNOEL : tables/mozilla/marvin/tbody_valign_baseline.html = IMAGE
     3954BUGNOEL : tables/mozilla/marvin/tbody_valign_bottom.html = IMAGE
     3955BUGNOEL : tables/mozilla/marvin/tbody_valign_middle.html = IMAGE
     3956BUGNOEL : tables/mozilla/marvin/tbody_valign_top.html = IMAGE
     3957BUGNOEL : tables/mozilla/marvin/td_valign_baseline.html = IMAGE
     3958BUGNOEL : tables/mozilla/marvin/td_valign_bottom.html = IMAGE
     3959BUGNOEL : tables/mozilla/marvin/td_valign_middle.html = IMAGE
     3960BUGNOEL : tables/mozilla/marvin/td_valign_top.html = IMAGE
     3961BUGNOEL : tables/mozilla/marvin/tfoot_valign_baseline.html = IMAGE
     3962BUGNOEL : tables/mozilla/marvin/tfoot_valign_bottom.html = IMAGE
     3963BUGNOEL : tables/mozilla/marvin/tfoot_valign_middle.html = IMAGE
     3964BUGNOEL : tables/mozilla/marvin/tfoot_valign_top.html = IMAGE
     3965BUGNOEL : tables/mozilla/marvin/th_valign_baseline.html = IMAGE
     3966BUGNOEL : tables/mozilla/marvin/th_valign_bottom.html = IMAGE
     3967BUGNOEL : tables/mozilla/marvin/th_valign_middle.html = IMAGE
     3968BUGNOEL : tables/mozilla/marvin/th_valign_top.html = IMAGE
     3969BUGNOEL : tables/mozilla/marvin/thead_valign_baseline.html = IMAGE
     3970BUGNOEL : tables/mozilla/marvin/thead_valign_bottom.html = IMAGE
     3971BUGNOEL : tables/mozilla/marvin/thead_valign_middle.html = IMAGE
     3972BUGNOEL : tables/mozilla/marvin/thead_valign_top.html = IMAGE
     3973BUGNOEL : tables/mozilla/marvin/tr_valign_baseline.html = IMAGE
     3974BUGNOEL : tables/mozilla/marvin/tr_valign_bottom.html = IMAGE
     3975BUGNOEL : tables/mozilla/marvin/tr_valign_middle.html = IMAGE
     3976BUGNOEL : tables/mozilla/marvin/tr_valign_top.html = IMAGE
     3977BUGNOEL : tables/mozilla/other/cell_widths.html = IMAGE
     3978BUGNOEL : tables/mozilla_expected_failures/bugs/bug6933.html = IMAGE
     3979BUGNOEL : tables/mozilla_expected_failures/other/test4.html = IMAGE
    38783980
    38793981// Skip until SUBPIXEL_LAYOUT is enabled
  • trunk/Source/WebCore/ChangeLog

    r116632 r116636  
     12012-05-10  Noel Gordon  <noel.gordon@gmail.com>
     2
     3        [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images
     4        https://bugs.webkit.org/show_bug.cgi?id=85772
     5
     6        Reviewed by Kent Tamura.
     7
     8        On some JPEG images, vertical and horizontal lines artifacts might appear in image
     9        regions with very high frequency color variation when using DCT_IFAST decodes. Use
     10        DCT_IFAST on small screen devices only (Chromium Android).
     11
     12        No new tests. Covered by existing tests.
     13
     14        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
     15        (dctMethod): Permit DCT_IFAST decoding for Chromium Android only.
     16
    1172012-05-10  Kenneth Rohde Christiansen  <kenneth@webkit.org>
    218
  • trunk/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

    r113243 r116636  
    7171
    7272#if defined(JCS_ALPHA_EXTENSIONS) && ASSUME_LITTLE_ENDIAN
    73 inline J_DCT_METHOD dctMethod() { return JDCT_IFAST; }
    7473#define TURBO_JPEG_RGB_SWIZZLE
    7574#if USE(SKIA) && (!SK_R32_SHIFT && SK_G32_SHIFT == 8 && SK_B32_SHIFT == 16)
     
    8079inline bool turboSwizzled(J_COLOR_SPACE colorSpace) { return colorSpace == rgbOutputColorSpace(); }
    8180#else
    82 inline J_DCT_METHOD dctMethod() { return JDCT_ISLOW; }
    8381inline J_COLOR_SPACE rgbOutputColorSpace() { return JCS_RGB; }
    8482#endif
    8583
    8684#if OS(ANDROID)
     85inline J_DCT_METHOD dctMethod() { return JDCT_IFAST; }
    8786inline J_DITHER_MODE ditherMode() { return JDITHER_NONE; }
    8887inline bool doFancyUpsampling() { return false; }
    8988#else
     89inline J_DCT_METHOD dctMethod() { return JDCT_ISLOW; }
    9090inline J_DITHER_MODE ditherMode() { return JDITHER_FS; }
    9191inline bool doFancyUpsampling() { return true; }
Note: See TracChangeset for help on using the changeset viewer.