Changeset 116639 in webkit


Ignore:
Timestamp:
May 10, 2012 6:48:47 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r116633.
​http://trac.webkit.org/changeset/116633
​https://bugs.webkit.org/show_bug.cgi?id=86093

Breaks EFL tests (Requested by kov on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-10

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/EventSender.cpp:

(keyDownCallback):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

  • platform/efl/Skipped:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r116636 r116639  
     12012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r116633.
     4        http://trac.webkit.org/changeset/116633
     5        https://bugs.webkit.org/show_bug.cgi?id=86093
     6
     7        Breaks EFL tests (Requested by kov on #webkit).
     8
     9        * platform/efl/Skipped:
     10
    1112012-05-10  Noel Gordon  <noel.gordon@gmail.com>
    212

  • trunk/LayoutTests/platform/efl/Skipped

    r116633 r116639  
    249249editing/selection/selection-background.html
    250250fast/dom/Window/window-onFocus.html
     251
     252# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
     253fast/events/keypress-insert-tab.html
    251254
    252255# EFL's LayoutTestController does not implement setUseDashboardCompatibilityMode

  • trunk/Source/WebKit/efl/ChangeLog

    r116633 r116639  
     12012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r116633.
     4        http://trac.webkit.org/changeset/116633
     5        https://bugs.webkit.org/show_bug.cgi?id=86093
     6
     7        Breaks EFL tests (Requested by kov on #webkit).
     8
     9        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
     10        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
     11
    1122012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
    213

  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp

    r116633 r116639  
    479479}
    480480
    481 void DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles)
    482 {
    483     WebCore::Page* page = EWKPrivate::corePage(ewkView);
    484     if (!page)
    485         return;
    486 
    487     page->setTabKeyCyclesThroughElements(cycles);
    488 }
    489 
    490481void DumpRenderTreeSupportEfl::garbageCollectorCollect()
    491482{

  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h

    r116633 r116639  
    8181    static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
    8282    static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
    83     static void setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles);
    8483
    8584    static void garbageCollectorCollect();

  • trunk/Tools/ChangeLog

    r116638 r116639  
     12012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r116633.
     4        http://trac.webkit.org/changeset/116633
     5        https://bugs.webkit.org/show_bug.cgi?id=86093
     6
     7        Breaks EFL tests (Requested by kov on #webkit).
     8
     9        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
     10        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
     11        * DumpRenderTree/efl/EventSender.cpp:
     12        (keyDownCallback):
     13        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
     14        (LayoutTestController::setTabKeyCyclesThroughElements):
     15
    1162012-05-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
    217

  • trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

    r116638 r116639  
    265265    DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled(mainView(), false);
    266266    DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting(mainView(), false);
    267     DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(mainView(), true);
    268267}
    269268

  • trunk/Tools/DumpRenderTree/efl/EventSender.cpp

    r116638 r116639  
    498498{
    499499    OwnPtr<KeyEventInfo> keyEventInfo = adoptPtr(createKeyEventInfo(context, argumentCount, arguments, exception));
    500     Evas_Object* mainFrame = browser->mainFrame();
    501 
    502     // Focus of the main frame could be lost during the test
    503     // Therefore, setting focus to the main frame
    504     evas_object_focus_set(mainFrame, true);
    505     sendKeyDown(evas_object_evas_get(mainFrame), keyEventInfo.get());
     500    sendKeyDown(evas_object_evas_get(browser->mainFrame()), keyEventInfo.get());
    506501
    507502    return JSValueMakeUndefined(context);

  • trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

    r116633 r116639  
    242242}
    243243
    244 void LayoutTestController::setTabKeyCyclesThroughElements(bool cycles)
    245 {
    246     DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(browser->mainView(), cycles);
     244void LayoutTestController::setTabKeyCyclesThroughElements(bool)
     245{
     246    notImplemented();
    247247}
    248248
Note: See TracChangeset for help on using the changeset viewer.