Changeset 116663 in webkit


Ignore:
Timestamp:
May 10, 2012 11:15:57 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Test from bug 34875 does not work on chromium/mac
https://bugs.webkit.org/show_bug.cgi?id=85913

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-10
Reviewed by Julien Chaffraix.

  • fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html: Added.
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Removed.
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:

Turned the test back into a ref-test as keeping the test cross-platform and
dumpAsText is proving cumbersome. Apart from that, it also make the test work
cross-browser.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:

Re-enabled the test.

Location:
trunk/LayoutTests
Files:
1 added
1 deleted
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r116661 r116663  
     12012-05-10  Shezan Baig <shezbaig.wk@gmail.com>
     2
     3        Test from bug 34875 does not work on chromium/mac
     4        https://bugs.webkit.org/show_bug.cgi?id=85913
     5
     6        Reviewed by Julien Chaffraix.
     7
     8        * fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html: Added.
     9        * fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Removed.
     10        * fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
     11        Turned the test back into a ref-test as keeping the test cross-platform and
     12        dumpAsText is proving cumbersome. Apart from that, it also make the test work
     13        cross-browser.
     14
     15        * platform/chromium/test_expectations.txt:
     16        * platform/mac/Skipped:
     17        * platform/qt-mac/Skipped:
     18        Re-enabled the test.
     19
    1202012-05-10  Dominik Röttsches  <dominik.rottsches@intel.com>
    221
  • trunk/LayoutTests/fast/block/positioning/offsetLeft-offsetTop-multicolumn.html

    r116446 r116663  
    22<html>
    33<head>
    4 <script src="../../js/resources/js-test-pre.js"></script>
    5 <script>
    6     description("This test checks that offsetLeft and offsetTop return " +
    7                 "correct values when used on elements contained in multiple " +
    8                 "columns. We put a number of spans (of arbitrary size) in a " +
    9                 "multi-column div. The script at the end verifies the " +
    10                 "offsetLeft and offsetTop result of each span against " +
    11                 "pre-calculated values.");
    12 
    13     if (window.layoutTestController)
    14         layoutTestController.dumpAsText();
    15 </script>
    164<style>
    17     body {
    18         font: Ahem;
    19     }
    20 
    21     #parent {
    22         position: absolute;
    23     }
    24 
    255    #multicol {
    266        -webkit-column-width: 100px;
     
    288        column-width: 100px;
    299        height: 200px;
    30         line-height: 18px;
    3110    }
    3211
    33     #multicol span {
     12    span {
    3413        display: inline-block;
    3514        height: 20px;
    36         background: #000;
     15        padding: 2px;
     16        background: red;
    3717    }
    3818
     
    4424        width: 20px;
    4525    }
    46 
    4726    .size3 {
    4827        width: 40px;
     
    5130</head>
    5231<body>
    53 <div id="parent">
    54     <div id="multicol">
    55         <div>
    56             <span class="size1"></span>
    57             <span class="size2"></span>
    58             <span class="size2"></span>
    59             <span class="size3"></span>
    60             <span class="size2"></span>
    61             <span class="size1"></span>
    62         </div>
     32<p> Bug <a href="http://webkit.org/b/34875">34875</a>: offsetLeft broken within CSS3 columns </p>
     33<p>There should not be any red spans visible.</p>
     34<p>
     35This test checks that offsetLeft and offsetTop return correct values when used
     36on elements contained in multiple columns. We put a number of red spans (of
     37arbitrary size) in a multi-column div. The script at the end creates an
     38identically sized green span for each of the red spans, and places it at the
     39offsetLeft and offsetTop of the red span, using absolute position. This ensures
     40that the green span completely covers the red span.
     41</p>
     42<div id="multicol">
     43    <div>
     44        <span class="size1"></span>
     45        <span class="size2"></span>
     46        <span class="size2"></span>
     47        <span class="size3"></span>
     48        <span class="size2"></span>
     49        <span class="size1"></span>
     50    </div>
     51    <div>
     52        <span class="size2"></span>
     53        <span class="size1"></span>
     54        <span class="size3"></span>
     55        <span class="size3"></span>
     56        <span class="size2"></span>
     57        <span class="size3"></span>
     58        <span class="size1"></span>
     59        <span class="size2"></span>
     60        <span class="size2"></span>
     61        <span class="size2"></span>
     62        <span class="size3"></span>
     63        <span class="size2"></span>
     64        <span class="size3"></span>
     65        <span class="size1"></span>
     66        <span class="size3"></span>
     67        <span class="size3"></span>
     68        <span class="size3"></span>
     69        <span class="size2"></span>
     70        <span class="size3"></span>
     71    </div>
     72    <div>
     73        <span class="size3"></span>
     74        <span class="size2"></span>
     75        <span class="size1"></span>
     76        <span class="size1"></span>
     77        <span class="size2"></span>
     78        <span class="size2"></span>
    6379        <div>
    6480            <span class="size2"></span>
     
    6682            <span class="size3"></span>
    6783            <span class="size3"></span>
    68             <span class="size2"></span>
    69             <span class="size3"></span>
    70             <span class="size1"></span>
    71             <span class="size2"></span>
    72             <span class="size2"></span>
    73             <span class="size2"></span>
    74             <span class="size3"></span>
    75             <span class="size2"></span>
    76             <span class="size3"></span>
    7784            <span class="size1"></span>
    7885            <span class="size3"></span>
    7986            <span class="size3"></span>
    80             <span class="size3"></span>
    81             <span class="size2"></span>
    82             <span class="size3"></span>
    83         </div>
    84         <div>
    85             <span class="size3"></span>
    86             <span class="size2"></span>
    87             <span class="size1"></span>
    88             <span class="size1"></span>
    89             <span class="size2"></span>
    9087            <span class="size2"></span>
    9188            <div>
    9289                <span class="size2"></span>
    93                 <span class="size1"></span>
    94                 <span class="size3"></span>
    9590                <span class="size3"></span>
    9691                <span class="size1"></span>
     
    9893                <span class="size3"></span>
    9994                <span class="size2"></span>
    100                 <div>
    101                     <span class="size2"></span>
    102                     <span class="size3"></span>
    103                     <span class="size1"></span>
    104                     <span class="size3"></span>
    105                     <span class="size3"></span>
    106                     <span class="size2"></span>
    107                     <span class="size1"></span>
    108                     <span class="size1"></span>
    109                     <span class="size2"></span>
    110                     <span class="size2"></span>
    111                     <span class="size2"></span>
    112                     <span class="size1"></span>
    113                     <span class="size3"></span>
    114                 </div>
    115                 <span class="size3"></span>
     95                <span class="size1"></span>
     96                <span class="size1"></span>
     97                <span class="size2"></span>
     98                <span class="size2"></span>
     99                <span class="size2"></span>
    116100                <span class="size1"></span>
    117101                <span class="size3"></span>
    118                 <span class="size3"></span>
    119                 <span class="size2"></span>
    120                 <span class="size2"></span>
    121102            </div>
    122103            <span class="size3"></span>
    123104            <span class="size1"></span>
    124105            <span class="size3"></span>
     106            <span class="size3"></span>
     107            <span class="size2"></span>
     108            <span class="size2"></span>
    125109        </div>
     110        <span class="size3"></span>
     111        <span class="size1"></span>
     112        <span class="size3"></span>
    126113    </div>
    127114</div>
     
    129116    var body = document.getElementsByTagName("body")[0];
    130117    var multicol = document.getElementById("multicol");
    131     var offsetParent = document.getElementById("parent");
    132118    var spans = multicol.getElementsByTagName("span");
    133 
    134     shouldBe("multicol.offsetParent.id", "offsetParent.id");
    135 
    136     var expectedResults = [
    137         [0,0],[14,0],[38,0],[62,0],[0,23],[24,23],[0,46],[24,46],[38,46],
    138         [0,69],[44,69],[0,92],[44,92],[58,92],[82,92],[0,115],[24,115],
    139         [68,115],[0,138],[44,138],[58,138],[0,161],[44,161],[123,0],[147,0],
    140         [123,23],[167,23],[191,23],[205,23],[123,46],[147,46],[123,69],[147,69],
    141         [161,69],[123,92],[167,92],[181,92],[123,115],[167,115],[123,138],[147,138],
    142         [191,138],[123,161],[167,161],[246,0],[270,0],[284,0],[298,0],[322,0],
    143         [246,23],[270,23],[284,23],[246,46],[290,46],[304,46],[246,69],[290,69],
    144         [314,69],[246,92],[290,92],[304,92],
    145     ];
    146 
    147119    for (var i = 0; i < spans.length; ++i) {
    148         var expected = expectedResults[i];
    149         shouldBe("spans[" + i + "].offsetLeft", expected[0].toString());
    150         shouldBe("spans[" + i + "].offsetTop", expected[1].toString());
     120        var item = spans[i];
     121        var cover = document.createElement("span");
     122        cover.setAttribute("class", item.getAttribute("class"));
     123        cover.setAttribute("style", "background: green; " +
     124                                    "z-index: 10; " +
     125                                    "position: absolute; " +
     126                                    "left: " + item.offsetLeft + "px; " +
     127                                    "top: " + item.offsetTop + "px;");
     128        body.appendChild(cover);
    151129    }
    152130</script>
    153131</body>
    154 <script src="../../js/resources/js-test-post.js"></script>
    155132</html>
    156 
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r116660 r116663  
    40304030BUGWK85949 SKIP : http/tests/loading/post-in-iframe-with-back-navigation.html = TEXT
    40314031
    4032 BUGWK85913 MAC : fast/block/positioning/offsetLeft-offsetTop-multicolumn.html = TEXT
    4033 
    40344032BUGWK85951 WIN DEBUG : fast/css/hover-update.html = TEXT PASS
    40354033
  • trunk/LayoutTests/platform/mac/Skipped

    r116592 r116663  
    835835ietestcenter/css3/flexbox/
    836836
    837 # https://bugs.webkit.org/show_bug.cgi?id=85913
    838 fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
    839 
    840837# https://bugs.webkit.org/show_bug.cgi?id=85969
    841838http/tests/loading/post-in-iframe-with-back-navigation.html
  • trunk/LayoutTests/platform/qt-mac/Skipped

    r116622 r116663  
    56585658fast/block/margin-collapse/103.html
    56595659fast/block/positioning/auto/006.html
    5660 fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
    56615660fast/css/color-correction-backgrounds-and-text.html
    56625661fast/css/first-letter-nested-positioned.htm
Note: See TracChangeset for help on using the changeset viewer.