Changeset 116676 in webkit

Timestamp:

May 10, 2012 12:28:18 PM (12 years ago)

Author:

rakuco@webkit.org

Message:

[EFL][webkitpy] Do not redefine check_build() in EflPort.
​https://bugs.webkit.org/show_bug.cgi?id=86124

Reviewed by Dirk Pranke.

Remove an old FIXME and do not redefine check_build in EflPort;
once build-dumprendertree recognizes --efl, we can use the
check_build implementation in WebKitPort.

• Scripts/build-dumprendertree:
• Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.check_build):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/build-dumprendertree (modified) (2 diffs)
• Scripts/webkitpy/layout_tests/port/efl.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
+
+        [EFL][webkitpy] Do not redefine check_build() in EflPort.
+        https://bugs.webkit.org/show_bug.cgi?id=86124
+
+        Reviewed by Dirk Pranke.
+
+        Remove an old FIXME and do not redefine check_build in EflPort;
+        once build-dumprendertree recognizes --efl, we can use the
+        check_build implementation in WebKitPort.
+
+        * Scripts/build-dumprendertree:
+        * Scripts/webkitpy/layout_tests/port/efl.py:
+        (EflPort.check_build):
+
 2012-05-10  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Tools/Scripts/build-dumprendertree

@@ -47 +47 @@
   --wx          Build the wxWindows port
   --chromium    Build the Chromium port
+  --efl         Build the EFL port
 EOF
 
@@ -71 +72 @@
 } elsif (isAppleWinWebKit()) {
     $result = buildVisualStudioProject("DumpRenderTree.sln", $clean);
-} elsif (isQt() || isGtk() || isWx() || isChromium()) {
-    # Qt, Gtk wxWindows, and Chromium build everything in one shot. No need to build anything here.
+} elsif (isQt() || isGtk() || isWx() || isChromium() || isEfl()) {
+    # Qt, Gtk wxWindows, Chromium and EFL build everything in one shot. No need to build anything here.
     $result = 0;
 } else {

trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py

@@ -63 +63 @@
         return self._build_path('bin', 'ImageDiff')
 
-    # FIXME: I doubt EFL wants to override this method.
-    def check_build(self, needs_http):
-        return self._check_driver()
-
     def _path_to_webcore_library(self):
         static_path = self._build_path('WebCore', 'libwebcore_efl.a')