Changeset 116679 in webkit


Ignore:
Timestamp:
May 10, 2012 1:10:22 PM (12 years ago)
Author:
zandobersek@gmail.com
Message:

[GTK] ENABLE_IFRAME_SEAMLESS support
​https://bugs.webkit.org/show_bug.cgi?id=85843

Reviewed by Eric Seidel.

.:

Add a configuration option for enabling the iframe seamless
attribute support, enabling it by default.

  • configure.ac:

Source/WebCore:

Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
enabled.

No new tests - all the related tests should now be passing.

  • GNUmakefile.am:

Tools:

Add the iframe-seamless option to the options list. This makes it
possible to enable the iframe seamless support through build-webkit
script. Enabled by default for all the ports.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove test expectations for the iframe seamless tests. All these
tests should be passing now as the feature is enabled.

  • platform/gtk/test_expectations.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r116647 r116679  
     12012-05-10  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] ENABLE_IFRAME_SEAMLESS support
     4        https://bugs.webkit.org/show_bug.cgi?id=85843
     5
     6        Reviewed by Eric Seidel.
     7
     8        Add a configuration option for enabling the iframe seamless
     9        attribute support, enabling it by default.
     10
     11        * configure.ac:
     12
    1132012-05-09  Stephen Chenney  <schenney@chromium.org>
    214

  • trunk/LayoutTests/ChangeLog

    r116678 r116679  
     12012-05-10  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] ENABLE_IFRAME_SEAMLESS support
     4        https://bugs.webkit.org/show_bug.cgi?id=85843
     5
     6        Reviewed by Eric Seidel.
     7
     8        Remove test expectations for the iframe seamless tests. All these
     9        tests should be passing now as the feature is enabled.
     10
     11        * platform/gtk/test_expectations.txt:
     12
    1132012-05-10  Julien Chaffraix  <jchaffraix@webkit.org>
    214

  • trunk/LayoutTests/platform/gtk/test_expectations.txt

    r116658 r116679  
    299299// These tests require subpixel layout to be enabled
    300300BUGWK60318 : fast/sub-pixel = FAIL
    301 
    302 BUGWK85843 : fast/frames/seamless = FAIL
    303301
    304302//////////////////////////////////////////////////////////////////////////////////////////

  • trunk/Source/WebCore/ChangeLog

    r116677 r116679  
     12012-05-10  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] ENABLE_IFRAME_SEAMLESS support
     4        https://bugs.webkit.org/show_bug.cgi?id=85843
     5
     6        Reviewed by Eric Seidel.
     7
     8        Export the ENABLE_IFRAME_SEAMLESS feature define when the feature is
     9        enabled.
     10
     11        No new tests - all the related tests should now be passing.
     12
     13        * GNUmakefile.am:
     14
    1152012-05-10  Antti Koivisto  <antti@apple.com>
    216

  • trunk/Source/WebCore/GNUmakefile.am

    r116641 r116679  
    656656webcore_cppflags += -DENABLE_WEB_TIMING=1
    657657endif  # END ENABLE_WEB_TIMING
     658
     659# ---
     660# HTML iframe seamless attribute support
     661# ---
     662if ENABLE_IFRAME_SEAMLESS
     663FEATURE_DEFINES += ENABLE_IFRAME_SEAMLESS=1
     664webcore_cppflags += -DENABLE_IFRAME_SEAMLESS=1
     665endif  # END ENABLE_IFRAME_SEAMLESS
    658666
    659667DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h

  • trunk/Tools/ChangeLog

    r116676 r116679  
     12012-05-10  Zan Dobersek  <zandobersek@gmail.com>
     2
     3        [GTK] ENABLE_IFRAME_SEAMLESS support
     4        https://bugs.webkit.org/show_bug.cgi?id=85843
     5
     6        Reviewed by Eric Seidel.
     7
     8        Add the iframe-seamless option to the options list. This makes it
     9        possible to enable the iframe seamless support through build-webkit
     10        script. Enabled by default for all the ports.
     11
     12        * Scripts/webkitperl/FeatureList.pm:
     13
    1142012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
    215

  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r116310 r116679  
    6666    $highDPICanvasSupport,
    6767    $icondatabaseSupport,
     68    $iframeSeamlessSupport,
    6869    $imageResizerSupport,
    6970    $indexedDatabaseSupport,
    … …  
    192193      define => "ENABLE_ICONDATABASE", default => 1, value => \$icondatabaseSupport },
    193194
     195    { option => "iframe-seamless", desc => "Toggle iframe seamless attribute support",
     196      define => "ENABLE_IFRAME_SEAMLESS", default => 1, value => \$iframeSeamlessSupport },
     197
    194198    { option => "indexed-database", desc => "Toggle Indexed Database support",
    195199      define => "ENABLE_INDEXED_DATABASE", default => 0, value => \$indexedDatabaseSupport },

  • trunk/configure.ac

    r116533 r116679  
    733733                             [enable HTML5 sandboxed iframe support [default=yes]]),
    734734              [],[enable_sandbox="yes"])
     735AC_MSG_RESULT([$enable_sandbox])
     736
     737# check whether to enable HTML5 iframe seamless attribute support
     738AC_MSG_CHECKING([whether to enable HTML5 iframe seamless attribute support])
     739AC_ARG_ENABLE(iframe-seamless,
     740              AC_HELP_STRING([--enable-iframe-seamless],
     741                             [enable HTML5 iframe seamless attribute support [default=yes]]),
     742              [],[enable_iframe_seamless="yes"])
    735743AC_MSG_RESULT([$enable_sandbox])
    736744
    … …  
    13971405AM_CONDITIONAL([ENABLE_DEVICE_ORIENTATION],[test "$enable_device_orientation" = "yes"])
    13981406AM_CONDITIONAL([ENABLE_MUTATION_OBSERVERS],[test "$enable_mutation_observers" = "yes"])
     1407AM_CONDITIONAL([ENABLE_IFRAME_SEAMLESS],[test "$enable_iframe_seamless" = "yes"])
    13991408
    14001409# Gtk conditionals
    … …  
    14721481 Quota API support                                        : $enable_quota
    14731482 HTML5 sandboxed iframe support                           : $enable_sandbox
     1483 HTML5 iframe seamless attribute support                  : $enable_iframe_seamless
    14741484 HTML5 video element support                              : $enable_video
    14751485 HTML5 track element support                              : $enable_video_track
Note: See TracChangeset for help on using the changeset viewer.