Changeset 116691 in webkit

Timestamp:

May 10, 2012 2:53:35 PM (12 years ago)

Author:

abarth@webkit.org

Message:

ASSERT in BidiResolver<Iterator, Run>::commitExplicitEmbedding makes running debug builds annoying
​https://bugs.webkit.org/show_bug.cgi?id=86140

Reviewed by Eric Seidel.

The correct fix here is to resolve
​https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
this ASSERT is annoying.

• platform/text/BidiResolver.h:

(WebCore::::commitExplicitEmbedding):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/text/BidiResolver.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-10  Adam Barth  <abarth@webkit.org>
+
+        ASSERT in BidiResolver<Iterator, Run>::commitExplicitEmbedding makes running debug builds annoying
+        https://bugs.webkit.org/show_bug.cgi?id=86140
+
+        Reviewed by Eric Seidel.
+
+        The correct fix here is to resolve
+        https://bugs.webkit.org/show_bug.cgi?id=76574, but in the mean time,
+        this ASSERT is annoying.
+
+        * platform/text/BidiResolver.h:
+        (WebCore::::commitExplicitEmbedding):
+
 2012-05-10  Mark Pilgrim  <pilgrim@chromium.org>
 

trunk/Source/WebCore/platform/text/BidiResolver.h

@@ -404 +404 @@
 {
     // This gets called from bidiFirst when setting up our start position.
-    ASSERT(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty());
+    // FIXME: Re-enable this assert once https://bugs.webkit.org/show_bug.cgi?id=76574 is fixed.
+    // ASSERT(!inIsolate() || m_currentExplicitEmbeddingSequence.isEmpty());
 
     using namespace WTF::Unicode;