Changeset 116726 in webkit

Timestamp:

May 10, 2012 9:16:04 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][DRT] Editor doesn't cancel composition as change of value
​https://bugs.webkit.org/show_bug.cgi?id=85122

Patch by Kangil Han <​kangil.han@samsung.com> on 2012-05-10
Reviewed by Martin Robinson.

IME composition should be cancelled when the value of input element is changed programmatically.
However, EFL port doesn't cancel as change of value.
Therefore, this patch will fix the bug.

Source/WebKit/efl:

• WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::respondToChangedSelection):

LayoutTests:

• platform/efl/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Source/WebKit/efl/ChangeLog (modified) (1 diff)
• Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-10  Kangil Han  <kangil.han@samsung.com>
+
+        [EFL][DRT] Editor doesn't cancel composition as change of value
+        https://bugs.webkit.org/show_bug.cgi?id=85122
+
+        Reviewed by Martin Robinson.
+
+        IME composition should be cancelled when the value of input element is changed programmatically.
+        However, EFL port doesn't cancel as change of value.
+        Therefore, this patch will fix the bug.
+
+        * platform/efl/Skipped:
+
 2012-05-10  Noel Gordon  <noel.gordon@gmail.com>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -204 +204 @@
 editing/input/password-echo-passnode.html
 editing/input/password-echo-passnode2.html
-
-# EFL's editor doesn't cancel composition as change of value
-# https://bugs.webkit.org/show_bug.cgi?id=85122
-editing/input/setting-input-value-cancel-ime-composition.html
 
 # EFL's textarea and textfield doesn't handle whitespace style

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-05-10  Kangil Han  <kangil.han@samsung.com>
+
+        [EFL][DRT] Editor doesn't cancel composition as change of value
+        https://bugs.webkit.org/show_bug.cgi?id=85122
+
+        Reviewed by Martin Robinson.
+
+        IME composition should be cancelled when the value of input element is changed programmatically.
+        However, EFL port doesn't cancel as change of value.
+        Therefore, this patch will fix the bug.
+
+        * WebCoreSupport/EditorClientEfl.cpp:
+        (WebCore::EditorClientEfl::respondToChangedSelection):
+
 2012-05-10  Dominik Röttsches  <dominik.rottsches@intel.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp

@@ -145 +145 @@
     Evas_Object* webFrame = EWKPrivate::kitFrame(coreFrame);
     ewk_frame_editor_client_selection_changed(webFrame);
+
+    if (!coreFrame->editor()->hasComposition() || coreFrame->editor()->ignoreCompositionSelectionChange())
+        return;
+
+    unsigned start;
+    unsigned end;
+
+    if (!coreFrame->editor()->getCompositionSelection(start, end))
+        coreFrame->editor()->cancelComposition();
 }