Changeset 116743 in webkit

Timestamp:

May 11, 2012 2:35:00 AM (12 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
​https://bugs.webkit.org/show_bug.cgi?id=86188

Reviewed by Yury Semikhatsky.

Source/WebCore:

We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
within _treeElementFromEvent(), which returns 0 for inline elements.

• inspector/front-end/AuditFormatters.js:

(WebInspector.AuditFormatters.node.onNodeAvailable):
(WebInspector.AuditFormatters.node):

LayoutTests:

• inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/extensions/extensions-audits-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/AuditFormatters.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-11  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
+        https://bugs.webkit.org/show_bug.cgi?id=86188
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/extensions/extensions-audits-expected.txt: rebaseline to account for extra <div>.
+
 2012-05-11  Kent Tamura  <tkent@chromium.org>
 

trunk/LayoutTests/inspector/extensions/extensions-audits-expected.txt

@@ -30 +30 @@
              : 
              Object
-            <
-             span
-             
-              id
-             ="
-              test-element
-             "
-            >
-           
+             <
+              span
+              
+               id
+              ="
+               test-element
+              "
+             >
+            
          extensions-audits.html:20
     Passed rule

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-11  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: use div, not span as a parent element for ElementsTreeOutline in Audits panel
+        https://bugs.webkit.org/show_bug.cgi?id=86188
+
+        Reviewed by Yury Semikhatsky.
+
+        We need to use <div>, not <span> as a container for ElementsTreeOutline, as latter accesses its parent offsetWidth
+        within _treeElementFromEvent(), which returns 0 for inline elements.
+
+        * inspector/front-end/AuditFormatters.js:
+        (WebInspector.AuditFormatters.node.onNodeAvailable):
+        (WebInspector.AuditFormatters.node):
+
 2012-05-11  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/inspector/front-end/AuditFormatters.js

@@ -122 +122 @@
     node: function(expression)
     {
-        var treeOutline = new WebInspector.ElementsTreeOutline(false, false, true);
+        var parentElement = document.createElement("div");
         /**
          * @param {?number} nodeId
@@ -130 +130 @@
             if (!nodeId)
                 return;
+            var treeOutline = new WebInspector.ElementsTreeOutline(false, false, true);
             treeOutline.rootDOMNode = WebInspector.domAgent.nodeForId(nodeId);
             treeOutline.element.addStyleClass("outline-disclosure");
             treeOutline.setVisible(true);
+            parentElement.appendChild(treeOutline.element);
         }
         /**
@@ -142 +144 @@
         }
         WebInspector.AuditFormatters.Utilities.evaluate(expression, onEvaluate);
-        return treeOutline.element;
+        return parentElement;
     }
 };