Changeset 116755 in webkit
- Timestamp:
- May 11, 2012 5:47:57 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r116754 r116755 1 2012-05-11 Alexander Pavlov <apavlov@chromium.org> 2 3 Web Inspector: Search box doesn't allow CSS selectors anymore 4 https://bugs.webkit.org/show_bug.cgi?id=86196 5 6 Reviewed by Pavel Feldman. 7 8 * inspector/elements/elements-panel-search-expected.txt: 9 * inspector/elements/elements-panel-search.html: 10 1 11 2012-05-11 Sheriff Bot <webkit.review.bot@gmail.com> 2 12 -
trunk/LayoutTests/inspector/elements/elements-panel-search-expected.txt
r99965 r116755 3 3 FooBar 4 4 5 Found by selector 5 6 6 7 Running: testSetUp … … 30 31 < d i v a t t r = " f o o " > < / d i v > 31 32 33 Running: testSelector 34 < s p a n > F o u n d b y s e l e c t o r < / s p a n > 35 -
trunk/LayoutTests/inspector/elements/elements-panel-search.html
r99983 r116755 72 72 { 73 73 WebInspector.domAgent.performSearch("//html" + "//@attr", searchCallback.bind(this, next)); 74 }, 75 76 function testSelector(next) 77 { 78 WebInspector.domAgent.performSearch("d" + "iv.divclass span", searchCallback.bind(this, next)); 74 79 } 75 80 ]); … … 88 93 <div attr="foo"></div> 89 94 <div id="terminator"></div> 95 <div class="divclass"><span>Found by selector</span></div> 90 96 91 97 </body> -
trunk/Source/WebCore/ChangeLog
r116754 r116755 1 2012-05-11 Alexander Pavlov <apavlov@chromium.org> 2 3 Web Inspector: Search box doesn't allow CSS selectors anymore 4 https://bugs.webkit.org/show_bug.cgi?id=86196 5 6 Reviewed by Pavel Feldman. 7 8 Refactoring in http://trac.webkit.org/changeset/99983 inadvertently removed the selector matching during 9 node search in the InspectorDOMAgent. This change re-introduces the Document::querySelectorAll() evaluation 10 for the user query. 11 12 * inspector/InspectorDOMAgent.cpp: 13 (WebCore::InspectorDOMAgent::performSearch): 14 1 15 2012-05-11 Sheriff Bot <webkit.review.bot@gmail.com> 2 16 -
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
r116730 r116755 885 885 } 886 886 } 887 888 // Selector evaluation 889 for (Vector<Document*>::iterator it = docs.begin(); it != docs.end(); ++it) { 890 Document* document = *it; 891 ExceptionCode ec = 0; 892 RefPtr<NodeList> nodeList = document->querySelectorAll(whitespaceTrimmedQuery, ec); 893 if (ec || !nodeList) 894 continue; 895 896 unsigned size = nodeList->length(); 897 for (unsigned i = 0; i < size; ++i) 898 resultCollector.add(nodeList->item(i)); 899 } 887 900 } 888 901
Note: See TracChangeset
for help on using the changeset viewer.