Changeset 116762 in webkit


Ignore:
Timestamp:
May 11, 2012 6:42:50 AM (12 years ago)
Author:
apavlov@chromium.org
Message:

Web Inspector: Can't type spaces in "Override User Agent" field
https://bugs.webkit.org/show_bug.cgi?id=86202

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen.prototype.isClosingKey):
(WebInspector.HelpScreen.prototype._onKeyDown):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype.isClosingKey):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r116761 r116762  
     12012-05-11  Alexander Pavlov  <apavlov@chromium.org>
     2
     3        Web Inspector: Can't type spaces in "Override User Agent" field
     4        https://bugs.webkit.org/show_bug.cgi?id=86202
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/front-end/HelpScreen.js:
     9        (WebInspector.HelpScreen.prototype.isClosingKey):
     10        (WebInspector.HelpScreen.prototype._onKeyDown):
     11        * inspector/front-end/SettingsScreen.js:
     12        (WebInspector.SettingsScreen.prototype.isClosingKey):
     13
    1142012-05-11  Dominik Röttsches  <dominik.rottsches@intel.com>
    215
  • trunk/Source/WebCore/inspector/front-end/HelpScreen.js

    r111551 r116762  
    4848    closeButton.textContent = "\u2716"; // Code stands for HEAVY MULTIPLICATION X.
    4949    closeButton.addEventListener("click", this.hide.bind(this), false);
    50     this._closeKeys = [
    51         WebInspector.KeyboardShortcut.Keys.Enter.code,
    52         WebInspector.KeyboardShortcut.Keys.Esc.code,
    53         WebInspector.KeyboardShortcut.Keys.Space.code,
    54     ];
    5550}
    5651
     
    8984    },
    9085
     86    /**
     87     * @param {number} keyCode
     88     * @return {boolean}
     89     */
     90    isClosingKey: function(keyCode)
     91    {
     92        return [
     93            WebInspector.KeyboardShortcut.Keys.Enter.code,
     94            WebInspector.KeyboardShortcut.Keys.Esc.code,
     95            WebInspector.KeyboardShortcut.Keys.Space.code,
     96        ].indexOf(keyCode) >= 0;
     97    },
     98
    9199    _onKeyDown: function(event)
    92100    {
    93         if (this._isShown && this._closeKeys.indexOf(event.keyCode) >= 0) {
     101        if (this._isShown && this.isClosingKey(event.keyCode)) {
    94102            this.hide();
    95103            event.consume();
  • trunk/Source/WebCore/inspector/front-end/SettingsScreen.js

    r115447 r116762  
    115115
    116116WebInspector.SettingsScreen.prototype = {
     117
     118    /**
     119     * @override
     120     */
     121    isClosingKey: function(keyCode)
     122    {
     123        return [
     124            WebInspector.KeyboardShortcut.Keys.Enter.code,
     125            WebInspector.KeyboardShortcut.Keys.Esc.code,
     126        ].indexOf(keyCode) >= 0;
     127    },
     128
    117129    /**
    118130     * @param {string} name
Note: See TracChangeset for help on using the changeset viewer.