Changeset 116762 in webkit
- Timestamp:
- May 11, 2012 6:42:50 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r116761 r116762 1 2012-05-11 Alexander Pavlov <apavlov@chromium.org> 2 3 Web Inspector: Can't type spaces in "Override User Agent" field 4 https://bugs.webkit.org/show_bug.cgi?id=86202 5 6 Reviewed by Yury Semikhatsky. 7 8 * inspector/front-end/HelpScreen.js: 9 (WebInspector.HelpScreen.prototype.isClosingKey): 10 (WebInspector.HelpScreen.prototype._onKeyDown): 11 * inspector/front-end/SettingsScreen.js: 12 (WebInspector.SettingsScreen.prototype.isClosingKey): 13 1 14 2012-05-11 Dominik Röttsches <dominik.rottsches@intel.com> 2 15 -
trunk/Source/WebCore/inspector/front-end/HelpScreen.js
r111551 r116762 48 48 closeButton.textContent = "\u2716"; // Code stands for HEAVY MULTIPLICATION X. 49 49 closeButton.addEventListener("click", this.hide.bind(this), false); 50 this._closeKeys = [51 WebInspector.KeyboardShortcut.Keys.Enter.code,52 WebInspector.KeyboardShortcut.Keys.Esc.code,53 WebInspector.KeyboardShortcut.Keys.Space.code,54 ];55 50 } 56 51 … … 89 84 }, 90 85 86 /** 87 * @param {number} keyCode 88 * @return {boolean} 89 */ 90 isClosingKey: function(keyCode) 91 { 92 return [ 93 WebInspector.KeyboardShortcut.Keys.Enter.code, 94 WebInspector.KeyboardShortcut.Keys.Esc.code, 95 WebInspector.KeyboardShortcut.Keys.Space.code, 96 ].indexOf(keyCode) >= 0; 97 }, 98 91 99 _onKeyDown: function(event) 92 100 { 93 if (this._isShown && this. _closeKeys.indexOf(event.keyCode) >= 0) {101 if (this._isShown && this.isClosingKey(event.keyCode)) { 94 102 this.hide(); 95 103 event.consume(); -
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
r115447 r116762 115 115 116 116 WebInspector.SettingsScreen.prototype = { 117 118 /** 119 * @override 120 */ 121 isClosingKey: function(keyCode) 122 { 123 return [ 124 WebInspector.KeyboardShortcut.Keys.Enter.code, 125 WebInspector.KeyboardShortcut.Keys.Esc.code, 126 ].indexOf(keyCode) >= 0; 127 }, 128 117 129 /** 118 130 * @param {string} name
Note: See TracChangeset
for help on using the changeset viewer.