Changeset 116802 in webkit


Ignore:
Timestamp:
May 11, 2012 2:16:19 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[chromium] Compute the best target node on a GestureTap event
​https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-11
Reviewed by Adam Barth.

Source/WebCore:

Will be using the tests in the touchadjustment/ directory.

  • WebCore.gypi:

Include TouchAdjustment.* files.

Source/WebKit/chromium:

  • features.gypi:

Enable the touch adjustment code by default.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

  • platform/chromium/test_expectations.txt:

Skipping two layout tests in the touchadjustment/ directory that
fail using DRT but pass when I run through the test cases manually.
Allan Jensen experiences a similar problem with these two tests
on the qt port (see comment 36 in the bug description) and will be
investigating why these tests have unexpected behavior.

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r116801 r116802  
     12012-05-11  Terry Anderson  <tdanderson@chromium.org>
     2
     3        [chromium] Compute the best target node on a GestureTap event
     4        https://bugs.webkit.org/show_bug.cgi?id=85101
     5
     6        Reviewed by Adam Barth.
     7
     8        * platform/chromium/test_expectations.txt:
     9        Skipping two layout tests in the touchadjustment/ directory that
     10        fail using DRT but pass when I run through the test cases manually.
     11        Allan Jensen experiences a similar problem with these two tests
     12        on the qt port (see comment 36 in the bug description) and will be
     13        investigating why these tests have unexpected behavior.
     14
    1152012-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
    216

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r116795 r116802  
    144144BUGWK62698 SKIP : batterystatus = PASS FAIL
    145145
    146 // Touch Adjustment is not supported yet in the chromium port.
    147 BUGWK78801 SKIP : touchadjustment/ = FAIL
     146// Unskip after investigation of failure by Allan Sandfeld Jensen
     147BUGWK85101 SKIP : touchadjustment/event-triggered-widgets.html = FAIL
     148BUGWK85101 SKIP : touchadjustment/touch-inlines.html = FAIL
    148149
    149150// Network Information API is not supported yet in the chromium port.

  • trunk/Source/WebCore/ChangeLog

    r116801 r116802  
     12012-05-11  Terry Anderson  <tdanderson@chromium.org>
     2
     3        [chromium] Compute the best target node on a GestureTap event
     4        https://bugs.webkit.org/show_bug.cgi?id=85101
     5
     6        Reviewed by Adam Barth.
     7
     8        Will be using the tests in the touchadjustment/ directory.
     9
     10        * WebCore.gypi:
     11        Include TouchAdjustment.* files.
     12
    1132012-05-11  Sheriff Bot  <webkit.review.bot@gmail.com>
    214

  • trunk/Source/WebCore/WebCore.gypi

    r116797 r116802  
    30563056            'page/SuspendableTimer.cpp',
    30573057            'page/SuspendableTimer.h',
     3058            'page/TouchAdjustment.cpp',
     3059            'page/TouchAdjustment.h',
    30583060            'page/UserContentURLPattern.cpp',
    30593061            'page/WebKitAnimation.cpp',

  • trunk/Source/WebKit/chromium/ChangeLog

    r116786 r116802  
     12012-05-11  Terry Anderson  <tdanderson@chromium.org>
     2
     3        [chromium] Compute the best target node on a GestureTap event
     4        https://bugs.webkit.org/show_bug.cgi?id=85101
     5
     6        Reviewed by Adam Barth.
     7
     8        * features.gypi:
     9        Enable the touch adjustment code by default.
     10        * src/WebInputEventConversion.cpp:
     11        (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
     12        In the case of a GestureTap, deltaX represents the horizontal padding of the touch
     13        area and deltaY represents the vertical padding of the touch area.
     14
    1152012-05-11  Ian Vollick  <vollick@chromium.org>
    216

  • trunk/Source/WebKit/chromium/features.gypi

    r116604 r116802  
    9898      'ENABLE_SVG=<(enable_svg)',
    9999      'ENABLE_SVG_FONTS=<(enable_svg)',
     100      'ENABLE_TOUCH_ADJUSTMENT=1',
    100101      'ENABLE_TOUCH_EVENTS=<(enable_touch_events)',
    101102      'ENABLE_TOUCH_ICON_LOADING=<(enable_touch_icon_loading)',

  • trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp

    r114301 r116802  
    149149    case WebInputEvent::GestureTap:
    150150        m_type = PlatformEvent::GestureTap;
     151        m_area = IntSize(e.deltaX * 2, e.deltaY * 2);
    151152        break;
    152153    case WebInputEvent::GestureTapDown:
Note: See TracChangeset for help on using the changeset viewer.