Changeset 116840 in webkit


Ignore:
Timestamp:
May 11, 2012 11:45:37 PM (12 years ago)
Author:
pilgrim@chromium.org
Message:

[Chromium] Call isLinkVisited directly
https://bugs.webkit.org/show_bug.cgi?id=85412

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageGroup.cpp:

(WebCore::PageGroup::isLinkVisited):

  • platform/VisitedLinks.cpp: Added.

(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

  • platform/VisitedLinks.h: Added.

(WebCore):
(VisitedLinks):

  • platform/chromium/PlatformSupport.h:
  • platform/chromium/VisitedLinksChromium.cpp: Added.

(WebCore):
(WebCore::VisitedLinks::isLinkVisited):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

Location:
trunk/Source
Files:
3 added
11 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/CMakeLists.txt

    r116763 r116840  
    11381138    platform/Timer.cpp
    11391139    platform/UUID.cpp
     1140    platform/VisitedLinks.cpp
    11401141    platform/Widget.cpp
    11411142
  • trunk/Source/WebCore/ChangeLog

    r116834 r116840  
     12012-05-11  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        [Chromium] Call isLinkVisited directly
     4        https://bugs.webkit.org/show_bug.cgi?id=85412
     5
     6        Reviewed by Adam Barth.
     7
     8        Part of a refactoring series. See tracking bug 82948.
     9
     10        * CMakeLists.txt:
     11        * GNUmakefile.list.am:
     12        * Target.pri:
     13        * WebCore.gypi:
     14        * WebCore.vcproj/WebCore.vcproj:
     15        * WebCore.xcodeproj/project.pbxproj:
     16        * page/PageGroup.cpp:
     17        (WebCore::PageGroup::isLinkVisited):
     18        * platform/VisitedLinks.cpp: Added.
     19        (WebCore):
     20        (WebCore::VisitedLinks::isLinkVisited):
     21        * platform/VisitedLinks.h: Added.
     22        (WebCore):
     23        (VisitedLinks):
     24        * platform/chromium/PlatformSupport.h:
     25        * platform/chromium/VisitedLinksChromium.cpp: Added.
     26        (WebCore):
     27        (WebCore::VisitedLinks::isLinkVisited):
     28
    1292012-05-11  Martin Robinson  <mrobinson@igalia.com>
    230
  • trunk/Source/WebCore/GNUmakefile.list.am

    r116690 r116840  
    36713671        Source/WebCore/platform/UUID.h \
    36723672        Source/WebCore/platform/VisitedLinkStrategy.h \
     3673        Source/WebCore/platform/VisitedLinks.cpp \
     3674        Source/WebCore/platform/VisitedLinks.h \
    36733675        Source/WebCore/platform/Widget.cpp \
    36743676        Source/WebCore/platform/Widget.h \
  • trunk/Source/WebCore/Target.pri

    r116767 r116840  
    12171217    platform/text/transcoder/FontTranscoder.cpp \
    12181218    platform/UUID.cpp \
     1219    platform/VisitedLinks.cpp \
    12191220    platform/Widget.cpp \
    12201221    platform/PlatformStrategies.cpp \
  • trunk/Source/WebCore/WebCore.gypi

    r116815 r116840  
    328328            'platform/TreeShared.h',
    329329            'platform/VisitedLinkStrategy.h',
     330            'platform/VisitedLinks.h',
    330331            'platform/Widget.h',
    331332            'platform/WindowsKeyboardCodes.h',
     
    33583359            'platform/chromium/ThemeChromiumMac.mm',
    33593360            'platform/chromium/TraceEvent.h',
     3361            'platform/chromium/VisitedLinksChromium.cpp',
    33603362            'platform/chromium/WidgetChromium.cpp',
    33613363            'platform/cocoa/KeyEventCocoa.h',
  • trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

    r116690 r116840  
    2814728147                        </File>
    2814828148                        <File
     28149                                RelativePath="..\platform\VisitedLinks.cpp"
     28150                                >
     28151                        </File>
     28152                        <File
     28153                                RelativePath="..\platform\VisitedLinks.h"
     28154                                >
     28155                        </File>
     28156                        <File
    2814928157                                RelativePath="..\platform\Widget.cpp"
    2815028158                                >
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r116690 r116840  
    2039620396                                2E3BBF061162DA1100B9409A /* UUID.h */,
    2039720397                                515788C01207852C00A37C4A /* VisitedLinkStrategy.h */,
     20398                                D6FDAEF2149C06190037B1E5 /* VisitedLinks.cpp */,
     20399                                D630E2AB149BF344005B2F97 /* VisitedLinks.h */,
    2039820400                                9380F47109A11AB4001FDB34 /* Widget.cpp */,
    2039920401                                9380F47209A11AB4001FDB34 /* Widget.h */,
     
    2472024722                                A883DF280F3D045D00F19BF6 /* VisibleSelection.h in Headers */,
    2472124723                                515788C11207852C00A37C4A /* VisitedLinkStrategy.h in Headers */,
     24724                                D630E2AC149BF344005B2F97 /* VisitedLinks.h in Headers */,
    2472224725                                E44613B60CD6344E00FADA75 /* VoidCallback.h in Headers */,
    2472324726                                FD7F299213D4C0CB00AD9535 /* WaveShaperDSPKernel.h in Headers */,
     
    2775827761                                93309E1F099E64920056E581 /* VisiblePosition.cpp in Sources */,
    2775927762                                A883DF270F3D045D00F19BF6 /* VisibleSelection.cpp in Sources */,
     27763                                D6FDAEF3149C06190037B1E5 /* VisitedLinks.cpp in Sources */,
    2776027764                                FD7F299113D4C0CB00AD9535 /* WaveShaperDSPKernel.cpp in Sources */,
    2776127765                                FD7F299313D4C0CB00AD9535 /* WaveShaperNode.cpp in Sources */,
  • trunk/Source/WebCore/page/PageGroup.cpp

    r112555 r116840  
    3939
    4040#if PLATFORM(CHROMIUM)
    41 #include "PlatformSupport.h"
     41#include "VisitedLinks.h"
    4242#endif
    4343
     
    177177#if PLATFORM(CHROMIUM)
    178178    // Use Chromium's built-in visited link database.
    179     return PlatformSupport::isLinkVisited(visitedLinkHash);
     179    return VisitedLinks::isLinkVisited(visitedLinkHash);
    180180#else
    181181    if (!m_visitedLinksPopulated) {
  • trunk/Source/WebCore/platform/chromium/PlatformSupport.h

    r116690 r116840  
    369369    static LinkHash visitedLinkHash(const UChar* url, unsigned length);
    370370    static LinkHash visitedLinkHash(const KURL& base, const AtomicString& attributeURL);
    371     static bool isLinkVisited(LinkHash);
    372371
    373372    static void didStartWorkerRunLoop(WorkerRunLoop*);
  • trunk/Source/WebKit/chromium/ChangeLog

    r116836 r116840  
     12012-05-11  Mark Pilgrim  <pilgrim@chromium.org>
     2
     3        [Chromium] Call isLinkVisited directly
     4        https://bugs.webkit.org/show_bug.cgi?id=85412
     5
     6        Reviewed by Adam Barth.
     7
     8        Part of a refactoring series. See tracking bug 82948.
     9
     10        * src/PlatformSupport.cpp:
     11        (WebCore):
     12
    1132012-05-11  Tony Chang  <tony@chromium.org>
    214
  • trunk/Source/WebKit/chromium/src/PlatformSupport.cpp

    r116690 r116840  
    831831}
    832832
    833 bool PlatformSupport::isLinkVisited(LinkHash visitedLinkHash)
    834 {
    835     return webKitPlatformSupport()->isLinkVisited(visitedLinkHash);
    836 }
    837 
    838833// These are temporary methods that the WebKit layer can use to call to the
    839834// Glue layer. Once the Glue layer moves entirely into the WebKit layer, these
Note: See TracChangeset for help on using the changeset viewer.