Changeset 116907 in webkit


Ignore:
Timestamp:
May 13, 2012 4:42:24 PM (12 years ago)
Author:
Darin Adler
Message:

Image::initPlatformData is always an empty function so we can remove it
​https://bugs.webkit.org/show_bug.cgi?id=86297

Reviewed by Dan Bernstein.

  • platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage): Ditto.

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): Ditto.

  • platform/graphics/chromium/ImageChromiumMac.mm: Removed empty

initPlatformData function.

  • platform/graphics/efl/ImageEfl.cpp: Ditto.
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/mac/ImageMac.mm:
  • platform/graphics/openvg/ImageOpenVG.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
Removed empty initPlatformData function.

  • platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
  • platform/graphics/win/ImageWin.cpp: Ditto.
  • platform/graphics/wx/ImageWx.cpp: Ditto.

(WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.

Location:
trunk/Source/WebCore
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r116906 r116907  
     12012-05-13  Darin Adler  <darin@apple.com>
     2
     3        Image::initPlatformData is always an empty function so we can remove it
     4        https://bugs.webkit.org/show_bug.cgi?id=86297
     5
     6        Reviewed by Dan Bernstein.
     7
     8        * platform/graphics/BitmapImage.h: Removed declaration of initPlatformData.
     9
     10        * platform/graphics/BitmapImage.cpp:
     11        (WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
     12        * platform/graphics/cairo/BitmapImageCairo.cpp:
     13        (WebCore::BitmapImage::BitmapImage): Ditto.
     14        * platform/graphics/cg/ImageCG.cpp:
     15        (WebCore::BitmapImage::BitmapImage): Ditto.
     16        * platform/graphics/chromium/ImageChromiumMac.mm: Removed empty
     17        initPlatformData function.
     18        * platform/graphics/efl/ImageEfl.cpp: Ditto.
     19        * platform/graphics/gtk/ImageGtk.cpp:
     20        * platform/graphics/mac/ImageMac.mm:
     21        * platform/graphics/openvg/ImageOpenVG.cpp:
     22        (WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
     23        Removed empty initPlatformData function.
     24        * platform/graphics/qt/ImageQt.cpp:
     25        (WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
     26        Removed empty initPlatformData function.
     27        * platform/graphics/skia/ImageSkia.cpp: Removed empty initPlatformData function.
     28        * platform/graphics/win/ImageWin.cpp: Ditto.
     29        * platform/graphics/wx/ImageWx.cpp: Ditto.
     30        (WebCore::BitmapImage::BitmapImage): Removed call to initPlatformData.
     31
    1322012-05-13  Darin Adler  <darin@apple.com>
    233

  • trunk/Source/WebCore/platform/graphics/BitmapImage.cpp

    r113486 r116907  
    6565    , m_haveFrameCount(false)
    6666{
    67     initPlatformData();
    6867}
    6968

  • trunk/Source/WebCore/platform/graphics/BitmapImage.h

    r115385 r116907  
    255255
    256256    // Handle platform-specific data
    257     void initPlatformData();
    258257    void invalidatePlatformData();
    259258   

  • trunk/Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp

    r115385 r116907  
    5959    , m_haveFrameCount(true)
    6060{
    61     initPlatformData();
    62 
    6361    cairo_surface_t* surface = nativeImage->surface();
    6462    int width = cairo_image_surface_get_width(surface);

  • trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp

    r116905 r116907  
    8787    , m_haveFrameCount(true)
    8888{
    89     initPlatformData();
    90    
    9189    CGFloat width = CGImageGetWidth(cgImage);
    9290    CGFloat height = CGImageGetHeight(cgImage);

  • trunk/Source/WebCore/platform/graphics/efl/ImageEfl.cpp

    r95901 r116907  
    3838namespace WebCore {
    3939
    40 void BitmapImage::initPlatformData()
    41 {
    42 }
    43 
    4440void BitmapImage::invalidatePlatformData()
    4541{

  • trunk/Source/WebCore/platform/graphics/gtk/ImageGtk.cpp

    r115385 r116907  
    7474}
    7575
    76 void BitmapImage::initPlatformData()
    77 {
    78 }
    79 
    8076void BitmapImage::invalidatePlatformData()
    8177{

  • trunk/Source/WebCore/platform/graphics/mac/ImageMac.mm

    r94900 r116907  
    3939
    4040namespace WebCore {
    41 
    42 void BitmapImage::initPlatformData()
    43 {
    44 }
    4541
    4642void BitmapImage::invalidatePlatformData()

  • trunk/Source/WebCore/platform/graphics/openvg/ImageOpenVG.cpp

    r102404 r116907  
    7171    , m_haveFrameCount(true)
    7272{
    73     initPlatformData();
    74 
    7573    ASSERT(m_size.width() > 0);
    7674    ASSERT(m_size.height() > 0);
    … …  
    102100
    103101    m_checkedForSolidColor = true;
    104 }
    105 
    106 void BitmapImage::initPlatformData()
    107 {
    108102}
    109103

  • trunk/Source/WebCore/platform/graphics/qt/ImageQt.cpp

    r107811 r116907  
    203203    , m_haveFrameCount(true)
    204204{
    205     initPlatformData();
    206 
    207205    int width = pixmap->width();
    208206    int height = pixmap->height();
    … …  
    215213    m_frames[0].m_haveMetadata = true;
    216214    checkForSolidColor();
    217 }
    218 
    219 void BitmapImage::initPlatformData()
    220 {
    221215}
    222216

  • trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp

    r116806 r116907  
    384384// FIXME: These should go to BitmapImageSkia.cpp
    385385
    386 void BitmapImage::initPlatformData()
    387 {
    388     // This is not used. On Mac, the "platform" data is a cache of some OS
    389     // specific versions of the image that are created is some cases. These
    390     // aren't normally used, it is equivalent to getHBITMAP on Windows, and
    391     // the platform data is the cache.
    392 }
    393 
    394386void BitmapImage::invalidatePlatformData()
    395387{
    396     // See initPlatformData above.
    397388}
    398389

  • trunk/Source/WebCore/platform/graphics/win/ImageWin.cpp

    r35738 r116907  
    3535namespace WebCore {
    3636
    37 void BitmapImage::initPlatformData()
    38 {
    39 }
    40 
    4137void BitmapImage::invalidatePlatformData()
    4238{

  • trunk/Source/WebCore/platform/graphics/wx/ImageWx.cpp

    r112670 r116907  
    8181}
    8282
    83 void BitmapImage::initPlatformData()
    84 {
    85     // FIXME: NYI
    86 }
    87 
    8883BitmapImage::BitmapImage(const wxBitmap& bitmap)
    8984    : Image(0)
    … …  
    10499    , m_frameCount(1)
    105100{
    106     initPlatformData();
    107    
    108101    m_decodedSize = bitmap.GetWidth() * bitmap.GetHeight() * 4;
    109102    m_size = IntSize(bitmap.GetWidth(), bitmap.GetHeight());
Note: See TracChangeset for help on using the changeset viewer.