Changeset 116972 in webkit


Ignore:
Timestamp:
May 14, 2012 11:18:50 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Fixup: Two of the touch-adjustment tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=86218

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-05-14
Reviewed by Darin Adler.

One test cases was still not working all platforms.
Change used font to Ahem to have stable layout across platforms.

  • touchadjustment/touch-inlines.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r116965 r116972  
     12012-05-14  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
     2
     3        Fixup: Two of the touch-adjustment tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=86218
     5
     6        Reviewed by Darin Adler.
     7
     8        One test cases was still not working all platforms.
     9        Change used font to Ahem to have stable layout across platforms.
     10
     11        * touchadjustment/touch-inlines.html:
     12
    1132012-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
    214

  • trunk/LayoutTests/touchadjustment/touch-inlines.html

    r116777 r116972  
    22<head>
    33    <script src="../fast/js/resources/js-test-pre.js"></script>
     4    <style>
     5        .testcontainer { position: absolute; top: 0px; left: 0px; font: 16px Ahem; line-height: 20px }
     6    </style>
    47</head>
    58<body onload="runTests()">
    69
    7 <p style="width: 10em;">
     10<div class=testcontainer>
     11<p style="width: 22em;">
    812<a id="1" href="#1">some link</a><br>
    913<a id="2" href="#2">some link breaking lines</a> and <a id="3" href="#3">link</a><br>
    … …  
    1216hi there <a id="6" href="#6">some link that is breaking multiple lines just for the very fun of it</a><br><br>
    1317</p>
     18</div>
    1419
    1520
    … …  
    3641        debug('Test some direct hits.');
    3742
    38         adjustedNode = testRoundTouch(30, 20, 8)
     43        adjustedNode = testRoundTouch(30, 25, 10)
    3944        shouldBeEqualToString('adjustedNode.id', '1');
    4045
    41         adjustedNode = testRoundTouch(30, 60, 8)
     46        adjustedNode = testRoundTouch(20, 65, 10)
    4247        shouldBeEqualToString('adjustedNode.id', '2');
    4348
    44         adjustedNode = testRoundTouch(120, 80, 8)
     49        adjustedNode = testRoundTouch(220, 85, 10)
    4550        shouldBeEqualToString('adjustedNode.id', '4');
    4651
    47         adjustedNode = testRoundTouch(80, 180, 8)
     52        adjustedNode = testRoundTouch(80, 195, 10)
    4853        shouldBeEqualToString('adjustedNode.id', '6');
    4954    }
    … …  
    5358        debug('Test a few direct misses.');
    5459
    55         adjustedNode = testRoundTouch(56, 60, 8)
     60        // Hit 'and' betwen link 2 and 3
     61        adjustedNode = testRoundTouch(120, 75, 6)
    5662        shouldBeNull('adjustedNode');
    5763
    58         adjustedNode = testRoundTouch(20, 166, 4)
     64        // Hit 'hi there' above and to the left of link 6.
     65        adjustedNode = testRoundTouch(72, 166, 6)
    5966        shouldBeNull('adjustedNode');
    6067
    … …  
    6572        debug('Test some in-direct hits.');
    6673
    67         adjustedNode = testRoundTouch(56, 60, 20)
     74        adjustedNode = testRoundTouch(50, 60, 20)
    6875        shouldBeEqualToString('adjustedNode.id', '2');
    6976
    70         adjustedNode = testRoundTouch(85, 80, 20)
     77        adjustedNode = testRoundTouch(172, 82, 20)
    7178        shouldBeEqualToString('adjustedNode.id', '3');
    7279
    73         adjustedNode = testRoundTouch(120, 66, 30)
     80        adjustedNode = testRoundTouch(230, 74, 20)
    7481        shouldBeEqualToString('adjustedNode.id', '4');
    7582
    76         adjustedNode = testRoundTouch(40, 100, 20)
     83        adjustedNode = testRoundTouch(30, 100, 20)
    7784        shouldBeEqualToString('adjustedNode.id', '4');
    7885
    79         adjustedNode = testRoundTouch(20, 174, 30)
     86        adjustedNode = testRoundTouch(24, 170, 20)
    8087        shouldBeEqualToString('adjustedNode.id', '6');
    8188
Note: See TracChangeset for help on using the changeset viewer.