Changeset 116978 in webkit

Timestamp:

May 14, 2012 12:06:54 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Patch by Swapna P <​spottabathini@innominds.com> on 2012-05-14
Reviewed by Eric Seidel.

Bug: Cannot resize frames because frameborder=0
​https://bugs.webkit.org/show_bug.cgi?id=23750

Source/WebCore:

Removed check for frameborder, in order to allow resize of frames even in case of frameborder=0.

Test: fast/frames/frames-with-frameborder-zero-can-be-resized.html

• rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::startResizing):
(WebCore::RenderFrameSet::canResizeRow):
(WebCore::RenderFrameSet::canResizeColumn):

LayoutTests:

Added test case to test whether the frame can be resized when frameborder=0.

• fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
• fast/frames/frames-with-frameborder-zero-can-be-resized.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt (added)
• LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderFrameSet.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-14  Swapna P  <spottabathini@innominds.com>
+
+        Reviewed by Eric Seidel.
+
+        Bug: Cannot resize frames because frameborder=0
+        https://bugs.webkit.org/show_bug.cgi?id=23750
+
+        Added test case to test whether the frame can be resized when frameborder=0.
+
+        * fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
+        * fast/frames/frames-with-frameborder-zero-can-be-resized.html: Added.
+
 2012-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-14  Swapna P  <spottabathini@innominds.com>
+
+        Reviewed by Eric Seidel.
+
+        Bug: Cannot resize frames because frameborder=0
+        https://bugs.webkit.org/show_bug.cgi?id=23750
+
+        Removed check for frameborder, in order to allow resize of frames even in case of frameborder=0.
+
+        Test: fast/frames/frames-with-frameborder-zero-can-be-resized.html
+
+        * rendering/RenderFrameSet.cpp:
+        (WebCore::RenderFrameSet::startResizing):
+        (WebCore::RenderFrameSet::canResizeRow):
+        (WebCore::RenderFrameSet::canResizeColumn):
+
 2012-05-14  David Barton  <dbarton@mathscribe.com>
 

trunk/Source/WebCore/rendering/RenderFrameSet.cpp

@@ -668 +668 @@
 {
     int split = hitTestSplit(axis, position);
-    if (split == noSplit || !axis.m_allowBorder[split] || axis.m_preventResize[split]) {
+    if (split == noSplit || axis.m_preventResize[split]) {
         axis.m_splitBeingResized = noSplit;
         return;
@@ -747 +747 @@
 {
     int r = hitTestSplit(m_rows, p.y());
-    return r != noSplit && m_rows.m_allowBorder[r] && !m_rows.m_preventResize[r];
+    return r != noSplit && !m_rows.m_preventResize[r];
 }
 
@@ -753 +753 @@
 {
     int c = hitTestSplit(m_cols, p.x());
-    return c != noSplit && m_cols.m_allowBorder[c] && !m_cols.m_preventResize[c];
+    return c != noSplit && !m_cols.m_preventResize[c];
 }