Changeset 117160 in webkit

Timestamp:

May 15, 2012 2:27:39 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[File API] URL methods handling null arguments
​https://bugs.webkit.org/show_bug.cgi?id=69693

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-05-15
Reviewed by Adam Barth.

Source/WebCore:

Per the latest editor's draft of the File API:
​http://dev.w3.org/2006/webapi/FileAPI/#dfn-createObjectURL

Use null instead of undefined as return value when a
null blob is given to URL.createObjectURL.

Test: fast/files/url-null.html

• html/DOMURL.idl:

LayoutTests:

URL.createObjectURL must return null instead of undefined
when a null blob is given as argument. Updated old test that
used undefined explicitly. New test by Mark Pilgrim (rebaselined
after fix).

• fast/files/url-null-expected.txt: Added.
• fast/files/url-null.html: Added.
• http/tests/fileapi/create-blob-url-from-data-url.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/files/url-null-expected.txt (added)
• LayoutTests/fast/files/url-null.html (added)
• LayoutTests/http/tests/fileapi/create-blob-url-from-data-url.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/DOMURL.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-15  Lauro Neto  <lauro.neto@openbossa.org>
+
+        [File API] URL methods handling null arguments
+        https://bugs.webkit.org/show_bug.cgi?id=69693
+
+        Reviewed by Adam Barth.
+
+        URL.createObjectURL must return null instead of undefined
+        when a null blob is given as argument. Updated old test that
+        used undefined explicitly. New test by Mark Pilgrim (rebaselined
+        after fix).
+
+        * fast/files/url-null-expected.txt: Added.
+        * fast/files/url-null.html: Added.
+        * http/tests/fileapi/create-blob-url-from-data-url.html:
+
 2012-05-15  Terry Anderson  <tdanderson@chromium.org>
 

trunk/LayoutTests/http/tests/fileapi/create-blob-url-from-data-url.html

@@ -16 +16 @@
         return;
     var blobURL = location.hash.substr(1);
-    if (blobURL == "undefined")
+    if (blobURL == "null")
         log("PASS: no blob URL is created");
     else

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-15  Lauro Neto  <lauro.neto@openbossa.org>
+
+        [File API] URL methods handling null arguments
+        https://bugs.webkit.org/show_bug.cgi?id=69693
+
+        Reviewed by Adam Barth.
+
+        Per the latest editor's draft of the File API:
+        http://dev.w3.org/2006/webapi/FileAPI/#dfn-createObjectURL
+
+        Use null instead of undefined as return value when a
+        null blob is given to URL.createObjectURL.
+
+        Test: fast/files/url-null.html
+
+        * html/DOMURL.idl:
+
 2012-05-15  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/html/DOMURL.idl

@@ -35 +35 @@
     ] DOMURL {
 #if defined(ENABLE_MEDIA_STREAM) && ENABLE_MEDIA_STREAM
-        [CallWith=ScriptExecutionContext,TreatReturnedNullStringAs=Undefined] static DOMString createObjectURL(in MediaStream stream);
+        [CallWith=ScriptExecutionContext,TreatReturnedNullStringAs=Null] static DOMString createObjectURL(in MediaStream stream);
 #endif
-        [CallWith=ScriptExecutionContext,TreatReturnedNullStringAs=Undefined] static DOMString createObjectURL(in Blob blob);
+        [CallWith=ScriptExecutionContext,TreatReturnedNullStringAs=Null] static DOMString createObjectURL(in Blob blob);
         [CallWith=ScriptExecutionContext] static void revokeObjectURL(in DOMString url);
     };