Changeset 117165 in webkit

Timestamp:

May 15, 2012 2:43:10 PM (12 years ago)

Author:

jer.noble@apple.com

Message:

r117147 causes a null-deref crash in DOMImplementation::createDocument()
​https://bugs.webkit.org/show_bug.cgi?id=86532

Reviewed by James Robinson.

No new tests, but fixes many crashing tests.

Protect against the possibility of being passed a NULL frame in
DOMImplementation::createDocument().

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DOMImplementation.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-15  Jer Noble  <jer.noble@apple.com>
+
+        r117147 causes a null-deref crash in DOMImplementation::createDocument()
+        https://bugs.webkit.org/show_bug.cgi?id=86532
+
+        Reviewed by James Robinson.
+
+        No new tests, but fixes many crashing tests.
+
+        Protect against the possibility of being passed a NULL frame in
+        DOMImplementation::createDocument().
+
+        * dom/DOMImplementation.cpp:
+        (WebCore::DOMImplementation::createDocument):
+
 2012-05-15  Julien Chaffraix  <jchaffraix@webkit.org>
 

trunk/Source/WebCore/dom/DOMImplementation.cpp

@@ -406 +406 @@
      // Check to see if the type can be played by our MediaPlayer, if so create a MediaDocument
     // Key system is not applicable here.
-    DOMImplementationSupportsTypeClient client(frame->settings() && frame->settings()->needsSiteSpecificQuirks(), url.host());
+    DOMImplementationSupportsTypeClient client(frame && frame->settings() && frame->settings()->needsSiteSpecificQuirks(), url.host());
     if (MediaPlayer::supportsType(ContentType(type), String(), &client))
          return MediaDocument::create(frame, url);