Changeset 117205 in webkit


Ignore:
Timestamp:
May 15, 2012 7:34:00 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] Enable Fullscreen API
​https://bugs.webkit.org/show_bug.cgi?id=85870

Patch by Kihong Kwon <​kihong.kwon@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

.:

Enable FULLSCREEN_API on the Efl port.

  • Source/cmake/OptionsEfl.cmake:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::supportsFullScreenForElement):
Add check routine if the full screen is enabled by page setting.

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
Add full screen setting to be true.

Tools:

Enable full screen api feature on the EFL port.
There are two failed test cases under LayoutTests/fullscreen.
They are going to be fixed with other patch.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl/Skipped: Remove fullscreen/video-controls-override.html.
  • platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/efl/fullscreen/full-screen-placeholder-expected.txt: Added.
  • platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
  • platform/efl/fullscreen/full-screen-render-inline-expected.txt: Added.
  • platform/efl/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/efl/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/efl/fullscreen/full-screen-zIndex-expected.png: Added.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
  • platform/efl/test_expectations.txt: Remove fullscreen and media/video-play-require-user-gesture.html
    • Add full-screen-keyboard-disabled.html and video-controls-drag.html to the efl's test_expectation.txt
Location:
trunk
Files:
10 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r117041 r117205  
     12012-05-15  Kihong Kwon  <kihong.kwon@samsung.com>
     2
     3        [EFL] Enable Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=85870
     5
     6        Reviewed by Antonio Gomes.
     7
     8        Enable FULLSCREEN_API on the Efl port.
     9
     10        * Source/cmake/OptionsEfl.cmake:
     11
    1122012-05-14  Shinya Kawanaka  <shinyak@chromium.org>
    213

  • trunk/LayoutTests/ChangeLog

    r117197 r117205  
     12012-05-15  Kihong Kwon  <kihong.kwon@samsung.com>
     2
     3        [EFL] Enable Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=85870
     5
     6        Reviewed by Antonio Gomes.
     7
     8        * platform/efl/Skipped: Remove fullscreen/video-controls-override.html.
     9        * platform/efl/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
     10        * platform/efl/fullscreen/full-screen-placeholder-expected.txt: Added.
     11        * platform/efl/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
     12        * platform/efl/fullscreen/full-screen-render-inline-expected.txt: Added.
     13        * platform/efl/fullscreen/full-screen-stacking-context-expected.png: Added.
     14        * platform/efl/fullscreen/full-screen-zIndex-after-expected.png: Added.
     15        * platform/efl/fullscreen/full-screen-zIndex-expected.png: Added.
     16        * platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
     17        * platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
     18        * platform/efl/test_expectations.txt: Remove fullscreen and media/video-play-require-user-gesture.html
     19          - Add full-screen-keyboard-disabled.html and video-controls-drag.html to the efl's test_expectation.txt
     20
    1212012-05-15  Robert Hogan  <robert@webkit.org>
    222

  • trunk/LayoutTests/platform/efl/Skipped

    r117082 r117205  
    322322
    323323# EFL's LayoutTestController does not implement shadowPseudoId
    324 fullscreen/video-controls-override.html
    325324media/video-controls-transformed.html
    326325media/video-controls-visible-audio-only.html

  • trunk/LayoutTests/platform/efl/test_expectations.txt

    r117189 r117205  
    368368BUGWK85956 : http/tests/loading/pdf-commit-load-callbacks.html = TEXT
    369369
    370 // The EFL port has no support for the Fullscreen API
    371 BUGWK85870 SKIP : fullscreen = FAIL
    372 BUGWK85870 : media/video-play-require-user-gesture.html = TEXT
     370// There are not proper result with FULLSCREN_API enabling.
     371BUGWK85870 : fullscreen/full-screen-keyboard-disabled.html = TEXT
     372BUGWK85870 : fullscreen/video-controls-drag.html = TEXT
    373373
    374374BUGWK79757 : fast/selectors/selection-window-inactive.html = IMAGE

  • trunk/Source/WebKit/efl/ChangeLog

    r117046 r117205  
     12012-05-15  Kihong Kwon  <kihong.kwon@samsung.com>
     2
     3        [EFL] Enable Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=85870
     5
     6        Reviewed by Antonio Gomes.
     7
     8        * WebCoreSupport/ChromeClientEfl.cpp:
     9        (WebCore::ChromeClientEfl::supportsFullScreenForElement):
     10        Add check routine if the full screen is enabled by page setting.
     11        * ewk/ewk_view.cpp:
     12        (_Ewk_View_Private_Data):
     13        (_ewk_view_priv_new):
     14        Add full screen setting to be true.
     15
    1162012-05-15  Tomasz Morawski  <t.morawski@samsung.com>
    217

  • trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp

    r117046 r117205  
    7272#endif
    7373
     74#if ENABLE(FULLSCREEN_API)
     75#include "Settings.h"
     76#endif
     77
    7478using namespace WebCore;
    7579
    … …  
    601605bool ChromeClientEfl::supportsFullScreenForElement(const WebCore::Element* element, bool withKeyboard)
    602606{
    603     if (withKeyboard)
     607    UNUSED_PARAM(withKeyboard);
     608
     609    if (!element->document()->page())
    604610        return false;
    605 
    606     return true;
     611    return element->document()->page()->settings()->fullScreenEnabled();
    607612}
    608613

  • trunk/Source/WebKit/efl/ewk/ewk_view.cpp

    r117046 r117205  
    701701    priv->pageSettings->setWebGLEnabled(true);
    702702    priv->pageSettings->setXSSAuditorEnabled(true);
     703#if ENABLE(FULLSCREEN_API)
     704    priv->pageSettings->setFullScreenEnabled(true);
     705#endif
    703706
    704707    url = priv->pageSettings->userStyleSheetLocation();

  • trunk/Source/cmake/OptionsEfl.cmake

    r116453 r117205  
    7070WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FAST_MOBILE_SCROLLING ON)
    7171WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS ON)
     72WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API ON)
    7273WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GLIB_SUPPORT ON)
    7374WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR ON)

  • trunk/Tools/ChangeLog

    r117190 r117205  
     12012-05-15  Kihong Kwon  <kihong.kwon@samsung.com>
     2
     3        [EFL] Enable Fullscreen API
     4        https://bugs.webkit.org/show_bug.cgi?id=85870
     5
     6        Reviewed by Antonio Gomes.
     7
     8        Enable full screen api feature on the EFL port.
     9        There are two failed test cases under LayoutTests/fullscreen.
     10        They are going to be fixed with other patch.
     11
     12        * Scripts/webkitperl/FeatureList.pm:
     13
    1142012-05-15  James Robinson  <jamesr@chromium.org>
    215

  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r117028 r117205  
    183183
    184184    { option => "fullscreen-api", desc => "Toggle Fullscreen API support",
    185       define => "ENABLE_FULLSCREEN_API", default => (isAppleMacWebKit() || isGtk() || isBlackBerry() || isQt()), value => \$fullscreenAPISupport },
     185      define => "ENABLE_FULLSCREEN_API", default => (isAppleMacWebKit() || isEfl() || isGtk() || isBlackBerry() || isQt()), value => \$fullscreenAPISupport },
    186186
    187187    { option => "gamepad", desc => "Toggle Gamepad support",
Note: See TracChangeset for help on using the changeset viewer.