Changeset 117227 in webkit

Timestamp:

May 16, 2012 12:36:06 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r117050.
​http://trac.webkit.org/changeset/117050
​https://bugs.webkit.org/show_bug.cgi?id=86587

"Some heap profiler tests started timing out" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-16

• inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/HeapSnapshotProxy.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r117050.
+        http://trac.webkit.org/changeset/117050
+        https://bugs.webkit.org/show_bug.cgi?id=86587
+
+        "Some heap profiler tests started timing out" (Requested by
+        yurys on #webkit).
+
+        * inspector/front-end/HeapSnapshotProxy.js:
+        (WebInspector.HeapSnapshotFakeWorker):
+        (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
+        (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
+
 2012-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js

@@ -79 +79 @@
 /**
  * @constructor
- */
-WebInspector.AsyncTaskQueue = function()
-{
-    this._queue = [];
-    this._isTimerSheduled = false;
-}
-
-WebInspector.AsyncTaskQueue.prototype = {
-    /**
-     * @param {function()} task
-     */
-    addTask: function(task)
-    {
-        this._queue.push(task);
-        this._scheduleTimer();
-    },
-
-    _onTimeout: function()
-    {
-        this._isTimerSheduled = false;
-        var task = this._queue.shift();
-        try {
-            task();
-        } finally {
-            this._scheduleTimer();
-        }
-    },
-
-    _scheduleTimer: function()
-    {
-        if (this._queue.length && !this._isTimerSheduled) {
-            setTimeout(this._onTimeout.bind(this), 0);
-            this._isTimerSheduled = true;
-        }
-    }
-}
-
-/**
- * @constructor
  * @extends {WebInspector.HeapSnapshotWorkerWrapper}
  */
@@ -123 +84 @@
 {
     this._dispatcher = new WebInspector.HeapSnapshotWorkerDispatcher(window, this._postMessageFromWorker.bind(this));
-    this._asyncTaskQueue = new WebInspector.AsyncTaskQueue();
 }
 
@@ -134 +94 @@
                 this._dispatcher.dispatchMessage({data: message});
         }
-        this._asyncTaskQueue.addTask(dispatch.bind(this));
+        setTimeout(dispatch.bind(this), 0);
     },
 
@@ -148 +108 @@
             this.dispatchEventToListeners("message", message);
         }
-        this._asyncTaskQueue.addTask(send.bind(this));
+        setTimeout(send.bind(this), 0);
     }
 };