Changeset 117257 in webkit


Ignore:
Timestamp:
May 16, 2012 4:20:21 AM (12 years ago)
Author:
bashi@chromium.org
Message:

[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
​https://bugs.webkit.org/show_bug.cgi?id=86589

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebTransformationMatrix.h: Added destructor.

(WebTransformationMatrix):

Source/WebCore:

Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.

No new tests. WebTransformationMatrixTest should pass on debug build.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebKit):

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/Platform/ChangeLog

    r117213 r117257  
     12012-05-16  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=86589
     5
     6        Reviewed by Kent Tamura.
     7
     8        * chromium/public/WebTransformationMatrix.h: Added destructor.
     9        (WebTransformationMatrix):
     10
    1112012-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
    212

  • trunk/Source/Platform/chromium/public/WebTransformationMatrix.h

    r116797 r117257  
    5252    WebTransformationMatrix(double a, double b, double c, double d, double e, double f);
    5353    WebTransformationMatrix(const WebTransformationMatrix&);
     54    ~WebTransformationMatrix();
    5455
    5556    // Operations that return a separate matrix and do not modify this one.

  • trunk/Source/WebCore/ChangeLog

    r117249 r117257  
     12012-05-16  Kenichi Ishibashi  <bashi@chromium.org>
     2
     3        [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=86589
     5
     6        Reviewed by Kent Tamura.
     7
     8        Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.
     9
     10        No new tests. WebTransformationMatrixTest should pass on debug build.
     11
     12        * platform/chromium/support/WebTransformationMatrix.cpp:
     13        (WebKit::WebTransformationMatrix::~WebTransformationMatrix):
     14        (WebKit):
     15
    1162012-05-16  Shinya Kawanaka  <shinyak@chromium.org>
    217

  • trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp

    r116797 r117257  
    5151}
    5252
     53WebTransformationMatrix::~WebTransformationMatrix()
     54{
     55    // We need to call m_private.reset(0). See the comment of WebPrivateOwnPtr class.
     56    m_private.reset(0);
     57}
     58
    5359#if WEBKIT_IMPLEMENTATION
    5460WebTransformationMatrix::WebTransformationMatrix(const TransformationMatrix& t)
Note: See TracChangeset for help on using the changeset viewer.