Changeset 117271 in webkit

Timestamp:

May 16, 2012 5:53:28 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

"border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
​https://bugs.webkit.org/show_bug.cgi?id=67877

Patch by Arpita Bahuguna <​arpitabahuguna@gmail.com> on 2012-05-16
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/table-collapsed-borders.html

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
When getting the previous row group's after border, pass SkipEmptySections as the second param
to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the
table passing SkipEmptySections to sectionAbove() would return null which should be the expected
behavior.

(WebCore::RenderTableCell::computeCollapsedAfterBorder):
When getting the following row group's before border, pass SkipEmptySections as the second param
to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the
table passing SkipEmptySections to sectionBelow() would return null which should be the expected
behavior.

LayoutTests:

• fast/css/table-collapsed-borders-expected.html: Added.
• fast/css/table-collapsed-borders.html: Added.

Added new reftest for testing table with collapsed borders.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/table-collapsed-borders-expected.html (added)
• LayoutTests/fast/css/table-collapsed-borders.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTableCell.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-16  Arpita Bahuguna  <arpitabahuguna@gmail.com>
+
+        "border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
+        https://bugs.webkit.org/show_bug.cgi?id=67877
+
+        Reviewed by Antti Koivisto.
+
+        * fast/css/table-collapsed-borders-expected.html: Added.
+        * fast/css/table-collapsed-borders.html: Added.
+        Added new reftest for testing table with collapsed borders.
+
 2012-05-16  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-16  Arpita Bahuguna  <arpitabahuguna@gmail.com>
+
+        "border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
+        https://bugs.webkit.org/show_bug.cgi?id=67877
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/css/table-collapsed-borders.html
+
+        * rendering/RenderTableCell.cpp:
+        (WebCore::RenderTableCell::computeCollapsedBeforeBorder):
+        When getting the previous row group's after border, pass SkipEmptySections as the second param
+        to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the
+        table passing SkipEmptySections to sectionAbove() would return null which should be the expected
+        behavior.
+
+        (WebCore::RenderTableCell::computeCollapsedAfterBorder):
+        When getting the following row group's before border, pass SkipEmptySections as the second param
+        to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the
+        table passing SkipEmptySections to sectionBelow() would return null which should be the expected
+        behavior.
+
 2012-05-16  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/rendering/RenderTableCell.cpp

@@ -605 +605 @@
         
         // (6) Previous row group's after border.
-        currSection = table->sectionAbove(currSection);
+        currSection = table->sectionAbove(currSection, SkipEmptySections);
         if (currSection) {
             result = chooseBorder(CollapsedBorderValue(currSection->style()->borderAfter(), includeColor ? currSection->style()->visitedDependentColor(afterColorProperty) : Color(), BROWGROUP), result);
@@ -683 +683 @@
         
         // (6) Following row group's before border.
-        currSection = table->sectionBelow(currSection);
+        currSection = table->sectionBelow(currSection, SkipEmptySections);
         if (currSection) {
             result = chooseBorder(result, CollapsedBorderValue(currSection->style()->borderBefore(), includeColor ? currSection->style()->visitedDependentColor(beforeColorProperty) : Color(), BROWGROUP));