Changeset 117272 in webkit

Timestamp:

May 16, 2012 6:16:57 AM (12 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: rename ProfileView.js to CPUProfileView.js
​https://bugs.webkit.org/show_bug.cgi?id=86612

Reviewed by Pavel Feldman.

Renamed ProfileView.js to CPUProfileView.js to match the file content.

• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• inspector/compile-front-end.py:
• inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.

(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype.get statusBarItems):
(WebInspector.CPUProfileView.prototype.get profile):
(WebInspector.CPUProfileView.prototype.set profile):
(WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get currentTree):
(WebInspector.CPUProfileView.prototype.set currentTree):
(WebInspector.CPUProfileView.prototype.willHide):
(WebInspector.CPUProfileView.prototype.refresh):
(WebInspector.CPUProfileView.prototype.refreshVisibleData):
(WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
(WebInspector.CPUProfileView.prototype.searchCanceled):
(WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
(WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
(WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
(WebInspector.CPUProfileView.prototype.showingLastSearchResult):
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
(WebInspector.CPUProfileView.prototype._changeView.set else):
(WebInspector.CPUProfileView.prototype._focusClicked):
(WebInspector.CPUProfileView.prototype._excludeClicked):
(WebInspector.CPUProfileView.prototype._resetClicked):
(WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
(WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
(WebInspector.CPUProfileView.prototype._sortProfile):
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.buttonClicked):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
(WebInspector.CPUProfileType.prototype.setRecordingProfile):
(WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):

• inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):

• inspector/front-end/WebKit.qrc:
• inspector/front-end/inspector.html:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• WebCore.gypi (modified) (2 diffs)
• WebCore.vcproj/WebCore.vcproj (modified) (2 diffs)
• inspector/compile-front-end.py (modified) (2 diffs)
• inspector/front-end/CPUProfileView.js (moved) (moved from trunk/Source/WebCore/inspector/front-end/ProfileView.js) (1 diff, 1 prop)
• inspector/front-end/HeapSnapshotView.js (modified) (1 diff)
• inspector/front-end/WebKit.qrc (modified) (2 diffs)
• inspector/front-end/inspector.html (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-16  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: rename ProfileView.js to CPUProfileView.js
+        https://bugs.webkit.org/show_bug.cgi?id=86612
+
+        Reviewed by Pavel Feldman.
+
+        Renamed ProfileView.js to CPUProfileView.js to match the file content.
+
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCore.vcproj:
+        * inspector/compile-front-end.py:
+        * inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.
+        (WebInspector.CPUProfileView.profileCallback):
+        (WebInspector.CPUProfileView.prototype.get statusBarItems):
+        (WebInspector.CPUProfileView.prototype.get profile):
+        (WebInspector.CPUProfileView.prototype.set profile):
+        (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
+        (WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
+        (WebInspector.CPUProfileView.prototype.get currentTree):
+        (WebInspector.CPUProfileView.prototype.set currentTree):
+        (WebInspector.CPUProfileView.prototype.willHide):
+        (WebInspector.CPUProfileView.prototype.refresh):
+        (WebInspector.CPUProfileView.prototype.refreshVisibleData):
+        (WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
+        (WebInspector.CPUProfileView.prototype.searchCanceled):
+        (WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
+        (WebInspector.CPUProfileView.prototype.performSearch):
+        (WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
+        (WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
+        (WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
+        (WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
+        (WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
+        (WebInspector.CPUProfileView.prototype.showingLastSearchResult):
+        (WebInspector.CPUProfileView.prototype._jumpToSearchResult):
+        (WebInspector.CPUProfileView.prototype._changeView.set else):
+        (WebInspector.CPUProfileView.prototype._focusClicked):
+        (WebInspector.CPUProfileView.prototype._excludeClicked):
+        (WebInspector.CPUProfileView.prototype._resetClicked):
+        (WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
+        (WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
+        (WebInspector.CPUProfileView.prototype._sortProfile):
+        (WebInspector.CPUProfileView.prototype._assignParentsInProfile):
+        (WebInspector.CPUProfileType):
+        (WebInspector.CPUProfileType.prototype.get buttonTooltip):
+        (WebInspector.CPUProfileType.prototype.buttonClicked):
+        (WebInspector.CPUProfileType.prototype.get treeItemTitle):
+        (WebInspector.CPUProfileType.prototype.get description):
+        (WebInspector.CPUProfileType.prototype.isRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.startRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.stopRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.setRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
+        (WebInspector.CPUProfileType.prototype.createView):
+        (WebInspector.CPUProfileType.prototype.createTemporaryProfile):
+        (WebInspector.CPUProfileType.prototype.createProfile):
+        * inspector/front-end/HeapSnapshotView.js:
+        (WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/inspector.html:
+
 2012-05-16  Arpita Bahuguna  <arpitabahuguna@gmail.com>
 

trunk/Source/WebCore/WebCore.gypi

@@ -6364 +6364 @@
             'inspector/front-end/CookieParser.js',
             'inspector/front-end/CookiesTable.js',
+            'inspector/front-end/CPUProfileView.js',
             'inspector/front-end/CSSCompletions.js',
             'inspector/front-end/CSSKeywordCompletions.js',
@@ -6443 +6444 @@
             'inspector/front-end/ProfileLauncherView.js',
             'inspector/front-end/ProfilesPanel.js',
-            'inspector/front-end/ProfileView.js',
             'inspector/front-end/PropertiesSection.js',
             'inspector/front-end/PropertiesSidebarPane.js',

trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj

@@ -74206 +74206 @@
                                 </File>
                                 <File
+                                        RelativePath="..\inspector\front-end\CPUProfileView.js"
+                                        >
+                                </File>
+                                <File
                                         RelativePath="..\inspector\front-end\CSSCompletions.js"
                                         >
@@ -74587 +74591 @@
                                 <File
                                         RelativePath="..\inspector\front-end\ProfilesPanel.js"
-                                        >
-                                </File>
-                                <File
-                                        RelativePath="..\inspector\front-end\ProfileView.js"
                                         >
                                 </File>

trunk/Source/WebCore/inspector/compile-front-end.py

@@ -294 +294 @@
         "sources": [
             "BottomUpProfileDataGridTree.js",
+            "CPUProfileView.js",
             "CSSSelectorProfileView.js",
             "HeapSnapshot.js",
@@ -306 +307 @@
             "ProfilesPanel.js",
             "ProfileLauncherView.js",
-            "ProfileView.js",
             "TopDownProfileDataGridTree.js",
         ]

trunk/Source/WebCore/inspector/front-end/CPUProfileView.js

@@ -24 +24 @@
  */
 
-// FIXME: Rename the file.
-
 /**
  * @constructor

trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js

@@ -246 +246 @@
 
         function matchesByName(gridNode) {
-            return ("name" in gridNode) && gridNode.name.hasSubstring(query, true);
+            return ("_name" in gridNode) && gridNode._name.hasSubstring(query, true);
         }
 

trunk/Source/WebCore/inspector/front-end/WebKit.qrc

@@ -28 +28 @@
     <file>CookieParser.js</file>
     <file>CookiesTable.js</file>
+    <file>CPUProfileView.js</file>
     <file>CSSCompletions.js</file>
     <file>CSSKeywordCompletions.js</file>
@@ -107 +108 @@
     <file>ProfileLauncherView.js</file>
     <file>ProfilesPanel.js</file>
-    <file>ProfileView.js</file>
     <file>PropertiesSection.js</file>
     <file>PropertiesSidebarPane.js</file>

trunk/Source/WebCore/inspector/front-end/inspector.html

@@ -167 +167 @@
     <script type="text/javascript" src="BottomUpProfileDataGridTree.js"></script>
     <script type="text/javascript" src="TopDownProfileDataGridTree.js"></script>
-    <script type="text/javascript" src="ProfileView.js"></script>
+    <script type="text/javascript" src="CPUProfileView.js"></script>
     <script type="text/javascript" src="CSSSelectorProfileView.js"></script>
     <script type="text/javascript" src="HeapSnapshot.js"></script>