Changeset 117381 in webkit

Timestamp:

May 16, 2012 7:21:10 PM (12 years ago)

Author:

haraken@chromium.org

Message:

[V8] Pass Isolate to remaining toV8()
​https://bugs.webkit.org/show_bug.cgi?id=86570

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to toV8(). I've landed a bunch of
patches to pass Isolate to toV8(), and this would be the last
patch for passing Isolate to toV8().

No tests. No change in behavior.

• bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::getNamedItems):

• bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8HTMLCollectionCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8IDBAnyCustom.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-16  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Pass Isolate to remaining toV8()
+        https://bugs.webkit.org/show_bug.cgi?id=86570
+
+        Reviewed by Nate Chapin.
+
+        The objective is to pass Isolate around in V8 bindings.
+        This patch passes Isolate to toV8(). I've landed a bunch of
+        patches to pass Isolate to toV8(), and this would be the last
+        patch for passing Isolate to toV8().
+
+        No tests. No change in behavior.
+
+        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
+        (WebCore::getNamedItems):
+        * bindings/v8/custom/V8IDBAnyCustom.cpp:
+        (WebCore::toV8):
+
 2012-05-16  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

@@ -56 +56 @@
 
     if (collection->type() == FormControls)
-        return toV8(collection->base()->radioNodeList(name).get());
+        return toV8(collection->base()->radioNodeList(name).get(), isolate);
 
     return toV8(V8NamedNodesCollection::create(namedItems), isolate);

trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp

@@ -56 +56 @@
         return v8::Null();
     case IDBAny::DOMStringListType:
-        return toV8(impl->domStringList());
+        return toV8(impl->domStringList(), isolate);
     case IDBAny::IDBCursorType:
-        return toV8(impl->idbCursor());
+        return toV8(impl->idbCursor(), isolate);
     case IDBAny::IDBCursorWithValueType:
-        return toV8(impl->idbCursorWithValue());
+        return toV8(impl->idbCursorWithValue(), isolate);
     case IDBAny::IDBDatabaseType:
-        return toV8(impl->idbDatabase());
+        return toV8(impl->idbDatabase(), isolate);
     case IDBAny::IDBFactoryType:
-        return toV8(impl->idbFactory());
+        return toV8(impl->idbFactory(), isolate);
     case IDBAny::IDBIndexType:
-        return toV8(impl->idbIndex());
+        return toV8(impl->idbIndex(), isolate);
     case IDBAny::IDBKeyType:
-        return toV8(impl->idbKey());
+        return toV8(impl->idbKey(), isolate);
     case IDBAny::IDBObjectStoreType:
-        return toV8(impl->idbObjectStore());
+        return toV8(impl->idbObjectStore(), isolate);
     case IDBAny::IDBTransactionType:
-        return toV8(impl->idbTransaction());
+        return toV8(impl->idbTransaction(), isolate);
     case IDBAny::SerializedScriptValueType:
         return impl->serializedScriptValue()->deserialize(0, isolate);