Changeset 117388 in webkit

Timestamp:

May 16, 2012 8:37:21 PM (12 years ago)

Author:

leviw@chromium.org

Message:

Use pixelSnappedLogicalHeight for TableSection layout
​https://bugs.webkit.org/show_bug.cgi?id=86665

Reviewed by Eric Seidel.

We do table layout using integers to ensure we follow the spec (see
​https://trac.webkit.org/wiki/LayoutUnit for details), but were previously
flooring the logical height used in layoutRows. This caused us to mis-
calculate the intrinsic padding and grow cells beyond their proper height.

No new tests. Fully covered by existing tests with sub-pixel enabled.

• rendering/RenderBox.h:

(WebCore::RenderBox::pixelSnappedLogicalHeight): Added these convenience
methods.
(WebCore::RenderBox::pixelSnappedLogicalWidth):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBox.h (modified) (1 diff)
• rendering/RenderTableSection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-16  Levi Weintraub  <leviw@chromium.org>
+
+        Use pixelSnappedLogicalHeight for TableSection layout
+        https://bugs.webkit.org/show_bug.cgi?id=86665
+
+        Reviewed by Eric Seidel.
+
+        We do table layout using integers to ensure we follow the spec (see
+        https://trac.webkit.org/wiki/LayoutUnit for details), but were previously
+        flooring the logical height used in layoutRows. This caused us to mis-
+        calculate the intrinsic padding and grow cells beyond their proper height.
+
+        No new tests. Fully covered by existing tests with sub-pixel enabled.
+
+        * rendering/RenderBox.h:
+        (WebCore::RenderBox::pixelSnappedLogicalHeight): Added these convenience
+        methods.
+        (WebCore::RenderBox::pixelSnappedLogicalWidth):
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::layoutRows):
+
 2012-05-16  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/rendering/RenderBox.h

@@ -74 +74 @@
     LayoutUnit logicalHeight() const { return style()->isHorizontalWritingMode() ? height() : width(); }
 
+    int pixelSnappedLogicalHeight() const { return style()->isHorizontalWritingMode() ? pixelSnappedHeight() : pixelSnappedWidth(); }
+    int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); }
+
     void setLogicalLeft(LayoutUnit left)
     {

trunk/Source/WebCore/rendering/RenderTableSection.cpp

@@ -619 +619 @@
             int oldIntrinsicPaddingBefore = cell->intrinsicPaddingBefore();
             int oldIntrinsicPaddingAfter = cell->intrinsicPaddingAfter();
-            int logicalHeightWithoutIntrinsicPadding = cell->logicalHeight() - oldIntrinsicPaddingBefore - oldIntrinsicPaddingAfter;
+            int logicalHeightWithoutIntrinsicPadding = cell->pixelSnappedLogicalHeight() - oldIntrinsicPaddingBefore - oldIntrinsicPaddingAfter;
 
             int intrinsicPaddingBefore = 0;