Changeset 117447 in webkit


Ignore:
Timestamp:
May 17, 2012 7:21:41 AM (12 years ago)
Author:
caseq@chromium.org
Message:

Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
https://bugs.webkit.org/show_bug.cgi?id=86659

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionView):
(WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.

  • inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.

(iframe.extension):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r117445 r117447  
     12012-05-16  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
     4        https://bugs.webkit.org/show_bug.cgi?id=86659
     5
     6        Reviewed by Vsevolod Vlasov.
     7
     8        * inspector/front-end/ExtensionPanel.js:
     9        (WebInspector.ExtensionView):
     10        (WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.
     11        * inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.
     12        (iframe.extension):
     13
    1142012-05-17  Sam D  <dsam2912@gmail.com>
    215
  • trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js

    r116957 r117447  
    11/*
    2  * Copyright (C) 2011 Google Inc. All rights reserved.
     2 * Copyright (C) 2012 Google Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    4040{
    4141    WebInspector.View.call(this);
     42    this.element.className = "fill";
    4243
    4344    this._id = id;
     
    264265            this._extensionView.detach(true);
    265266
    266         this._extensionView = new WebInspector.ExtensionView(this._id, this.bodyElement, url, "extension");
     267        this._extensionView = new WebInspector.ExtensionView(this._id, this.bodyElement, url, "extension fill");
     268        if (!this.bodyElement.style.height)
     269            this.setHeight("150px");
    267270    },
    268271
  • trunk/Source/WebCore/inspector/front-end/inspector.css

    r117445 r117447  
    994994iframe.extension {
    995995    width: 100%;
     996    height: 100%;
    996997}
    997998
Note: See TracChangeset for help on using the changeset viewer.