Changeset 117450 in webkit

Timestamp:

May 17, 2012 8:21:08 AM (12 years ago)

Author:

yurys@chromium.org

Message:

[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=86726

Reviewed by Pavel Feldman.

No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.

• inspector/WorkerDebuggerAgent.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/WorkerDebuggerAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Yury Semikhatsky  <yurys@chromium.org>
+
+        [Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
+        https://bugs.webkit.org/show_bug.cgi?id=86726
+
+        Reviewed by Pavel Feldman.
+
+        No need to keep RefPtr to WorkerThread in a task that will be executed on
+        that thread, raw pointer can be used instead.
+
+        * inspector/WorkerDebuggerAgent.cpp:
+
 2012-05-17  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/inspector/WorkerDebuggerAgent.cpp

@@ -68 +68 @@
         // Process all queued debugger commands. It is safe to use m_workerContext here
         // because it is alive if RunWorkerLoop is not terminated, otherwise it will
-        // just be ignored.
+        // just be ignored. WorkerThread is certainly alive if this task is being executed.
         while (MessageQueueMessageReceived == m_thread->runLoop().runInMode(m_workerContext, WorkerDebuggerAgent::debuggerTaskMode, WorkerRunLoop::DontWaitForMessage)) { }
     }
 
 private:
-    RefPtr<WorkerThread> m_thread;
+    WorkerThread* m_thread;
     WorkerContext* m_workerContext;
 };