Changeset 117454 in webkit


Ignore:
Timestamp:
May 17, 2012 9:00:36 AM (12 years ago)
Author:
yurys@chromium.org
Message:

Web Inspector: error when expanding an HTMLAllCollection object in the console
https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/console/inspect-html-all-collection.html

  • inspector/InjectedScriptSource.js: take into account that typeof HTMLAllCollection is "undefined"

when checking if object resolved by id is valid.

LayoutTests:

Test that RemoteObject.callFunctionOn can be successfully invoked on a
remote object representing HTMLAllCollection instance.

  • inspector/console/inspect-html-all-collection-expected.txt: Added.
  • inspector/console/inspect-html-all-collection.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r117451 r117454  
     12012-05-17  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: error when expanding an HTMLAllCollection object in the console
     4        https://bugs.webkit.org/show_bug.cgi?id=86741
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Test that RemoteObject.callFunctionOn can be successfully invoked on a
     9        remote object representing HTMLAllCollection instance.
     10
     11        * inspector/console/inspect-html-all-collection-expected.txt: Added.
     12        * inspector/console/inspect-html-all-collection.html: Added.
     13
    1142012-05-17  Antti Koivisto  <antti@apple.com>
    215
  • trunk/Source/WebCore/ChangeLog

    r117453 r117454  
     12012-05-17  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: error when expanding an HTMLAllCollection object in the console
     4        https://bugs.webkit.org/show_bug.cgi?id=86741
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Test: inspector/console/inspect-html-all-collection.html
     9
     10        * inspector/InjectedScriptSource.js: take into account that typeof HTMLAllCollection is "undefined"
     11        when checking if object resolved by id is valid.
     12
    1132012-05-17  Kinuko Yasuda  <kinuko@chromium.org>
    214
  • trunk/Source/WebCore/inspector/InjectedScriptSource.js

    r116768 r117454  
    272272        var parsedObjectId = this._parseObjectId(objectId);
    273273        var object = this._objectForId(parsedObjectId);
    274         if (!object)
     274        if (!this._isDefined(object))
    275275            return "Could not find object with given id";
    276276
Note: See TracChangeset for help on using the changeset viewer.