Changeset 117473 in webkit

Timestamp:

May 17, 2012 11:57:16 AM (12 years ago)

Author:

kling@webkit.org

Message:

Parser: Avoid unnecessary ref count churn in token constructors.
<​http://webkit.org/b/86667>

Reviewed by Antti Koivisto.

Pass AtomicString by const reference to avoid useless ref count churn
in AtomicHTMLToken() and AtomicXMLToken().

• html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

• xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):

• xml/parser/XMLToken.h:

(WebCore::AtomicXMLToken::AtomicXMLToken):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLToken.h (modified) (1 diff)
• xml/parser/MarkupTokenBase.h (modified) (1 diff)
• xml/parser/XMLToken.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Andreas Kling  <kling@webkit.org>
+
+        Parser: Avoid unnecessary ref count churn in token constructors.
+        <http://webkit.org/b/86667>
+
+        Reviewed by Antti Koivisto.
+
+        Pass AtomicString by const reference to avoid useless ref count churn
+        in AtomicHTMLToken() and AtomicXMLToken().
+
+        * html/parser/HTMLToken.h:
+        (WebCore::AtomicHTMLToken::AtomicHTMLToken):
+        * xml/parser/MarkupTokenBase.h:
+        (WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
+        * xml/parser/XMLToken.h:
+        (WebCore::AtomicXMLToken::AtomicXMLToken):
+
 2012-05-16  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/html/parser/HTMLToken.h

@@ -87 +87 @@
     AtomicHTMLToken(HTMLToken& token) : AtomicMarkupTokenBase<HTMLToken>(&token) { }
 
-    AtomicHTMLToken(HTMLTokenTypes::Type type, AtomicString name, const Vector<Attribute>& attributes = Vector<Attribute>())
+    AtomicHTMLToken(HTMLTokenTypes::Type type, const AtomicString& name, const Vector<Attribute>& attributes = Vector<Attribute>())
         : AtomicMarkupTokenBase<HTMLToken>(type, name, attributes)
     {

trunk/Source/WebCore/xml/parser/MarkupTokenBase.h

@@ -410 +410 @@
     }
 
-    AtomicMarkupTokenBase(typename Token::Type::Type type, AtomicString name, const Vector<Attribute>& attributes = Vector<Attribute>())
+    AtomicMarkupTokenBase(typename Token::Type::Type type, const AtomicString& name, const Vector<Attribute>& attributes = Vector<Attribute>())
         : m_type(type)
         , m_name(name)

trunk/Source/WebCore/xml/parser/XMLToken.h

@@ -432 +432 @@
     }
 
-    AtomicXMLToken(XMLTokenTypes::Type type, AtomicString name, const Vector<Attribute>& attributes = Vector<Attribute>())
+    AtomicXMLToken(XMLTokenTypes::Type type, const AtomicString& name, const Vector<Attribute>& attributes = Vector<Attribute>())
         : AtomicMarkupTokenBase<XMLToken>(type, name, attributes)
     {