Changeset 117477 in webkit
- Timestamp:
- May 17, 2012 12:07:57 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 13 added
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r117475 r117477 1 2012-05-02 Robert Hogan <robert@webkit.org> 2 3 CSS 2.1 failure: table-height-algorithm-023 and -024 fail 4 https://bugs.webkit.org/show_bug.cgi?id=85405 5 6 Reviewed by Eric Seidel. 7 8 * css2.1/20110323/table-height-algorithm-023.htm: Added. 9 * css2.1/20110323/table-height-algorithm-024.htm: Added. 10 Tests from the CSS test suite. 11 * fast/table/mozilla-bug10296-vertical-align-1.html: Added. 12 * fast/table/mozilla-bug10296-vertical-align-2.html: Added. 13 I split out the part of bug10296-1.html that gets rebaselined here so that the new results 14 are visible. I also changed the text so that the expected result is less mysterious. 15 16 * platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.png: Added. 17 * platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-023-expected.txt: Added. 18 * platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.png: Added. 19 * platform/chromium-linux-x86/css2.1/20110323/table-height-algorithm-024-expected.txt: Added. 20 * platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added. 21 * platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added. 22 * platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added. 23 * platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added. 24 * platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.txt: 25 1 26 2012-05-17 Raphael Kubo da Costa <rakuco@webkit.org> 2 27 -
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.txt
r56259 r117477 947 947 RenderText {#text} at (2,2) size 29x19 948 948 text run at (2,2) width 29: "Data" 949 RenderTableCell {TD} at (356, 2) size 94x61 [border: (1px solid #000000)] [r=0 c=5 rs=1 cs=1]949 RenderTableCell {TD} at (356,46) size 94x61 [border: (1px solid #000000)] [r=0 c=5 rs=1 cs=1] 950 950 RenderText {#text} at (2,3) size 90x55 951 951 text run at (2,3) width 90: "Data" … … 962 962 RenderText {#text} at (2,2) size 43x19 963 963 text run at (2,2) width 43: "Middle" 964 RenderTableCell {TD} at (270, 31) size 33x24 [border: (1px solid #000000)] [r=0 c=3 rs=1 cs=1]964 RenderTableCell {TD} at (270,75) size 33x24 [border: (1px solid #000000)] [r=0 c=3 rs=1 cs=1] 965 965 RenderText {#text} at (2,2) size 29x19 966 966 text run at (2,2) width 29: "Data" … … 968 968 RenderText {#text} at (2,2) size 45x19 969 969 text run at (2,2) width 45: "Bottom" 970 RenderTableCell {TD} at (356, 2) size 94x61 [border: (1px solid #000000)] [r=0 c=5 rs=1 cs=1]970 RenderTableCell {TD} at (356,46) size 94x61 [border: (1px solid #000000)] [r=0 c=5 rs=1 cs=1] 971 971 RenderText {#text} at (2,3) size 90x55 972 972 text run at (2,3) width 90: "Data" … … 998 998 RenderText {#text} at (2,2) size 25x19 999 999 text run at (2,2) width 25: "Top" 1000 RenderTableCell {TD} at (33, 2) size 94x61 [border: (1px solid #000000)] [r=0 c=1 rs=1 cs=1]1000 RenderTableCell {TD} at (33,46) size 94x61 [border: (1px solid #000000)] [r=0 c=1 rs=1 cs=1] 1001 1001 RenderText {#text} at (2,3) size 90x55 1002 1002 text run at (2,3) width 90: "Data" … … 1004 1004 RenderText {#text} at (2,2) size 45x19 1005 1005 text run at (2,2) width 45: "Bottom" 1006 RenderTableCell {TD} at (180, 2) size 33x24 [border: (1px solid #000000)] [r=0 c=3 rs=1 cs=1]1006 RenderTableCell {TD} at (180,75) size 33x24 [border: (1px solid #000000)] [r=0 c=3 rs=1 cs=1] 1007 1007 RenderText {#text} at (2,2) size 29x19 1008 1008 text run at (2,2) width 29: "Data" -
trunk/LayoutTests/platform/efl/test_expectations.txt
r117472 r117477 462 462 BUGWK86441 : fast/borders/border-antialiasing.html = IMAGE 463 463 BUGWK86441 : fast/multicol/shadow-breaking.html = IMAGE 464 465 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 466 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT -
trunk/LayoutTests/platform/gtk/test_expectations.txt
r117412 r117477 1334 1334 BUGWK86441 : fast/multicol/shadow-breaking.html = IMAGE 1335 1335 1336 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 1337 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT 1338 1336 1339 ////////////////////////////////////////////////////////////////////////////////////////// 1337 1340 // End of Tests failing -
trunk/LayoutTests/platform/mac/test_expectations.txt
r117412 r117477 231 231 // Needs rebaseline after bug 86441 232 232 BUGWK86441 : fast/multicol/shadow-breaking.html = IMAGE 233 234 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 235 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT -
trunk/LayoutTests/platform/qt/test_expectations.txt
r117412 r117477 73 73 BUGWK86441 : fast/borders/border-antialiasing.html = IMAGE 74 74 BUGWK86441 : fast/multicol/shadow-breaking.html = IMAGE 75 76 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 77 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT -
trunk/LayoutTests/platform/win/Skipped
r117394 r117477 1751 1751 inspector/extensions/extensions-audits-content-script.html 1752 1752 1753 //Rebaseline required after https://bugs.webkit.org/show_bug.cgi?id=841671753 # Rebaseline required after https://bugs.webkit.org/show_bug.cgi?id=84167 1754 1754 editing/pasteboard/innerText-inline-table.html 1755 1755 editing/selection/iframe.html … … 1760 1760 fast/inline-block/001.html 1761 1761 tables/mozilla/bugs/bug2479-2.html 1762 1763 # Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 1764 tables/mozilla/bugs/bug10296-1.html -
trunk/Source/WebCore/ChangeLog
r117476 r117477 1 2012-05-02 Robert Hogan <robert@webkit.org> 2 3 CSS 2.1 failure: table-height-algorithm-023 and -024 fail 4 https://bugs.webkit.org/show_bug.cgi?id=85405 5 6 Reviewed by Eric Seidel. 7 8 Treat vertical-align: [length] the same as vertical-align: baseline. 9 10 Tests: css2.1/20110323/table-height-algorithm-023.htm 11 css2.1/20110323/table-height-algorithm-024.htm 12 fast/table/mozilla-bug10296-vertical-align-1.html 13 fast/table/mozilla-bug10296-vertical-align-2.html 14 15 * rendering/RenderTableSection.cpp: 16 (WebCore::RenderTableSection::calcRowLogicalHeight): 17 (WebCore::RenderTableSection::layoutRows): 18 1 19 2012-05-17 Emil A Eklund <eae@chromium.org> 2 20 -
trunk/Source/WebCore/rendering/RenderTableSection.cpp
r117388 r117477 371 371 // find out the baseline 372 372 EVerticalAlign va = cell->style()->verticalAlign(); 373 if (va == BASELINE || va == TEXT_BOTTOM || va == TEXT_TOP || va == SUPER || va == SUB ) {373 if (va == BASELINE || va == TEXT_BOTTOM || va == TEXT_TOP || va == SUPER || va == SUB || va == LENGTH) { 374 374 LayoutUnit baselinePosition = cell->cellBaselinePosition(); 375 375 if (baselinePosition > cell->borderBefore() + cell->paddingBefore()) { … … 610 610 // If the baseline moved, we may have to update the data for our row. Find out the new baseline. 611 611 EVerticalAlign va = cell->style()->verticalAlign(); 612 if (va == BASELINE || va == TEXT_BOTTOM || va == TEXT_TOP || va == SUPER || va == SUB ) {612 if (va == BASELINE || va == TEXT_BOTTOM || va == TEXT_TOP || va == SUPER || va == SUB || va == LENGTH) { 613 613 LayoutUnit baseline = cell->cellBaselinePosition(); 614 614 if (baseline > cell->borderBefore() + cell->paddingBefore()) … … 627 627 case TEXT_TOP: 628 628 case TEXT_BOTTOM: 629 case LENGTH: 629 630 case BASELINE: { 630 631 LayoutUnit b = cell->cellBaselinePosition();
Note: See TracChangeset
for help on using the changeset viewer.