Changeset 117534 in webkit

Timestamp:

May 17, 2012 8:24:44 PM (12 years ago)

Author:

hayato@chromium.org

Message:

[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
​https://bugs.webkit.org/show_bug.cgi?id=86708

Reviewed by Eric Seidel.

Since InsertionPoint now has isActive() member function,
we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
using that function.

No new tests, no change in behavior.

• dom/ComposedShadowTreeWalker.h:

(WebCore::ComposedShadowTreeWalker::assertPrecondition):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ComposedShadowTreeWalker.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Hayato Ito  <hayato@chromium.org>
+
+        [Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
+        https://bugs.webkit.org/show_bug.cgi?id=86708
+
+        Reviewed by Eric Seidel.
+
+        Since InsertionPoint now has isActive() member function,
+        we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
+        using that function.
+
+        No new tests, no change in behavior.
+
+        * dom/ComposedShadowTreeWalker.h:
+        (WebCore::ComposedShadowTreeWalker::assertPrecondition):
+
 2012-05-17  Ami Fischman  <fischman@chromium.org>
 

trunk/Source/WebCore/dom/ComposedShadowTreeWalker.h

@@ -28 +28 @@
 #define ComposedShadowTreeWalker_h
 
+#include "InsertionPoint.h"
 #include "ShadowRoot.h"
 
@@ -81 +82 @@
         else
             ASSERT(!m_node->isShadowRoot() || toShadowRoot(m_node)->isYoungest());
-        // FIXME: Add an assertion once InsertionPoint have isActive() function.
-        // https://bugs.webkit.org/show_bug.cgi?id=82010
-        // ASSERT(!isInsertionPoint(m_node) || !toInsertionPoint(node)->isActive());
+        ASSERT(!isInsertionPoint(m_node) || !toInsertionPoint(m_node)->isActive());
 #endif
     }