Changeset 117541 in webkit

Timestamp:

May 17, 2012 9:57:07 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
​https://bugs.webkit.org/show_bug.cgi?id=75119

Patch by Wei James <​james.wei@intel.com> on 2012-05-17
Reviewed by Chris Rogers.

As multiple channel support in AudioBus and other places is already
implemented, the check can be removed here.

• Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/MediaElementAudioSourceNode.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Wei James  <james.wei@intel.com>
+
+        AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
+        https://bugs.webkit.org/show_bug.cgi?id=75119
+
+        Reviewed by Chris Rogers.
+
+        As multiple channel support in AudioBus and other places is already
+        implemented, the check can be removed here.  
+
+        * Modules/webaudio/MediaElementAudioSourceNode.cpp:
+        (WebCore::MediaElementAudioSourceNode::setFormat):
+
 2012-05-17  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp

@@ -69 +69 @@
 {
     if (numberOfChannels != m_sourceNumberOfChannels || sourceSampleRate != m_sourceSampleRate) {
-        // FIXME: implement multi-channel greater than stereo.
-        // https://bugs.webkit.org/show_bug.cgi?id=75119
-        if (!numberOfChannels || numberOfChannels > 2 || sourceSampleRate < minSampleRate || sourceSampleRate > maxSampleRate) {
+        if (!numberOfChannels || numberOfChannels > AudioContext::maxNumberOfChannels() || sourceSampleRate < minSampleRate || sourceSampleRate > maxSampleRate) {
             // process() will generate silence for these uninitialized values.
             LOG(Media, "MediaElementAudioSourceNode::setFormat(%u, %f) - unhandled format change", static_cast<unsigned>(numberOfChannels), sourceSampleRate);