Changeset 117546 in webkit

Timestamp:

May 17, 2012 10:50:42 PM (12 years ago)

Author:

haraken@chromium.org

Message:

[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
​https://bugs.webkit.org/show_bug.cgi?id=86803

Reviewed by Dimitri Glazkov.

V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
too, and remove V8Proxy::deletionNotHandledByInterceptor().

No tests. No change in behavior.

• bindings/v8/V8Proxy.h:
• bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageDeleter):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Proxy.h (modified) (1 diff)
• bindings/v8/custom/V8StorageCustom.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Kentaro Hara  <haraken@chromium.org>
+
+        [V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
+        https://bugs.webkit.org/show_bug.cgi?id=86803
+
+        Reviewed by Dimitri Glazkov.
+
+        V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
+        only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
+        other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
+        Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
+        too, and remove V8Proxy::deletionNotHandledByInterceptor().
+
+        No tests. No change in behavior.
+
+        * bindings/v8/V8Proxy.h:
+        * bindings/v8/custom/V8StorageCustom.cpp:
+        (WebCore::storageDeleter):
+
 2012-05-17  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8Proxy.h

@@ -321 +321 @@
     }
 
-    inline static v8::Local<v8::Boolean> deletionNotHandledByInterceptor()
-    {
-        return v8::Local<v8::Boolean>();
-    }
-
     inline v8::Handle<v8::Primitive> throwError(const char* message, V8Proxy::ErrorType type, v8::Isolate* isolate = 0)
     {

trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp

@@ -137 +137 @@
     }
 
-    return deletionNotHandledByInterceptor();
+    return v8::Handle<v8::Boolean>();
 }