Changeset 117562 in webkit

Timestamp:

May 18, 2012 1:25:07 AM (12 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: add an option to show last N hidden children of node in heap profiler
​https://bugs.webkit.org/show_bug.cgi?id=86757

Reviewed by Pavel Feldman.

Renamed "Show next N" to "Show N before" and added "Show N after" button. Also
when all 3 buttons would have equal effect there is now only "Show all N" button.

• English.lproj/localizedStrings.js:
• inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showLastChunk):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.createCells):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/ShowMoreDataGridNode.js (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-17  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: add an option to show last N hidden children of node in heap profiler
+        https://bugs.webkit.org/show_bug.cgi?id=86757
+
+        Reviewed by Pavel Feldman.
+
+        Renamed "Show next N" to "Show N before" and added "Show N after" button. Also
+        when all 3 buttons would have equal effect there is now only "Show all N" button.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/ShowMoreDataGridNode.js:
+        (WebInspector.ShowMoreDataGridNode):
+        (WebInspector.ShowMoreDataGridNode.prototype._showLastChunk):
+        (WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
+        (WebInspector.ShowMoreDataGridNode.prototype.createCells):
+
 2012-05-17  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/ShowMoreDataGridNode.js

@@ -48 +48 @@
     this.showNext.setAttribute("type", "button");
     this.showNext.addEventListener("click", this._showNextChunk.bind(this), false);
+    this.showNext.textContent = WebInspector.UIString("Show %d before", this._chunkSize);
 
     this.showAll = document.createElement("button");
     this.showAll.setAttribute("type", "button");
     this.showAll.addEventListener("click", this._showAll.bind(this), false);
+
+    this.showLast = document.createElement("button");
+    this.showLast.setAttribute("type", "button");
+    this.showLast.addEventListener("click", this._showLastChunk.bind(this), false);
+    this.showLast.textContent = WebInspector.UIString("Show %d after", this._chunkSize);
 
     this._updateLabels();
@@ -68 +74 @@
     },
 
+    _showLastChunk: function()
+    {
+        this._callback(this._endPosition - this._chunkSize, this._endPosition);
+    },
+
     _updateLabels: function()
     {
         var totalSize = this._endPosition - this._startPosition;
-        var nextChunkSize = Math.min(this._chunkSize, totalSize);
-        this.showNext.textContent = WebInspector.UIString("Show next %d", nextChunkSize);
+        if (totalSize > this._chunkSize) {
+            this.showNext.removeStyleClass("hidden");
+            this.showLast.removeStyleClass("hidden");
+        } else {
+            this.showNext.addStyleClass("hidden");
+            this.showLast.addStyleClass("hidden");
+        }
         this.showAll.textContent = WebInspector.UIString("Show all %d", totalSize);
     },
@@ -82 +98 @@
             cell.style.setProperty("padding-left", (this.depth * this.dataGrid.indentWidth) + "px");
         cell.appendChild(this.showNext);
-        if (this.showAll)
-            cell.appendChild(this.showAll);
+        cell.appendChild(this.showAll);
+        cell.appendChild(this.showLast);
         this._element.appendChild(cell);