Changeset 117584 in webkit

Timestamp:

May 18, 2012 6:55:08 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Text input events are emitted for nodes that do not allow editing.
​https://bugs.webkit.org/show_bug.cgi?id=86836

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.

Text input events are not anymore emitted for nodes that do not allow editing.
This can be checked with fast/events/key-events-in-input-button.html test output.

• WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/EditorClientEfl.cpp (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-05-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] Text input events are emitted for nodes that do not allow editing.
+        https://bugs.webkit.org/show_bug.cgi?id=86836
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Text input events are not anymore emitted for nodes that do not allow editing.
+        This can be checked with fast/events/key-events-in-input-button.html test output.
+
+        * WebCoreSupport/EditorClientEfl.cpp:
+        (WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.
+
 2012-05-18  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp

@@ -442 +442 @@
         return true;
 
+    // Don't allow text insertion for nodes that cannot edit.
+    if (!frame->editor()->canEdit())
+        return false;
+
     // Don't insert null or control characters as they can result in unexpected behaviour
     if (event->charCode() < ' ')