Changeset 117590 in webkit
- Timestamp:
- May 18, 2012 7:26:08 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 22 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r117588 r117590 1 2012-05-18 Yi Shen <yi.4.shen@nokia.com> 2 3 REGRESSION (r102553): Smart links do not work 4 https://bugs.webkit.org/show_bug.cgi?id=85463 5 6 Reviewed by Ryosuke Niwa. 7 8 Add a new test for testing the smart link. 9 10 * editing/inserting/typing-space-to-trigger-smart-link-expected.txt: Added. 11 * editing/inserting/typing-space-to-trigger-smart-link.html: Added. 12 * platform/chromium/test_expectations.txt: 13 * platform/efl/test_expectations.txt: 14 * platform/gtk/test_expectations.txt: 15 * platform/qt/Skipped: 16 * platform/qt/test_expectations.txt: 17 * platform/win/Skipped: 18 1 19 2012-05-18 Csaba Osztrogonác <ossy@webkit.org> 2 20 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r117583 r117590 1781 1781 BUGWK SKIP : http/tests/appcache/origin-usage.html = FAIL 1782 1782 1783 // LayoutTestController::setAutomaticLinkDetectionEnabled isn't implemented 1784 BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = FAIL 1785 1783 1786 // Failures from WebKit merge 51711:51724 1784 1787 BUGCR32003 : fast/js/string-property-deletion.html = TEXT -
trunk/LayoutTests/platform/efl/test_expectations.txt
r117583 r117590 463 463 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 464 464 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT 465 466 // EFL's LayoutTestController does not implement setAutomaticLinkDetectionEnabled 467 BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = FAIL -
trunk/LayoutTests/platform/gtk/test_expectations.txt
r117583 r117590 170 170 BUGWKGTK SKIP : fast/events/drag-dataTransferItemList.html = FAIL 171 171 BUGWKGTK SKIP : fast/events/drag-dataTransferItemList-file-handling.html = FAIL 172 173 // setAutomaticLinkDetectionEnabled is not yet implemented. 174 BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = FAIL 172 175 173 176 // Custom MIME type support in DataTransfer is not yet implemented. -
trunk/LayoutTests/platform/qt/Skipped
r117588 r117590 2456 2456 # https://bugs.webkit.org/show_bug.cgi?id=86445 2457 2457 fast/multicol/split-in-top-margin.html 2458 2459 # LayoutTestController::setAutomaticLinkDetectionEnabled isn't implemented 2460 editing/inserting/typing-space-to-trigger-smart-link.html -
trunk/LayoutTests/platform/qt/test_expectations.txt
r117477 r117590 76 76 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405 77 77 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT 78 79 // LayoutTestController::setAutomaticLinkDetectionEnabled isn't implemented 80 BUGWK85463 SKIP : editing/inserting/typing-space-to-trigger-smart-link.html = FAIL -
trunk/LayoutTests/platform/win/Skipped
r117477 r117590 653 653 http/tests/xmlhttprequest/upload-progress-events.html 654 654 http/tests/xmlhttprequest/upload-onprogress-event.html 655 656 // LayoutTestController::setAutomaticLinkDetectionEnabled isn't implemented 657 editing/inserting/typing-space-to-trigger-smart-link.html 655 658 656 659 ################################################################################ -
trunk/Source/WebCore/ChangeLog
r117587 r117590 1 2012-05-18 Yi Shen <yi.4.shen@nokia.com> 2 3 REGRESSION (r102553): Smart links do not work 4 https://bugs.webkit.org/show_bug.cgi?id=85463 5 6 Reviewed by NOBODY Ryosuke Niwa. 7 8 To fix the regression of smart links, we need to check TextCheckingTypeLink option in 9 Editor::markAndReplaceFor(). 10 11 Test: editing/inserting/typing-space-to-trigger-smart-link.html 12 13 * editing/Editor.cpp: 14 (WebCore::Editor::markAndReplaceFor): 15 1 16 2012-05-18 Alexander Pavlov <apavlov@chromium.org> 2 17 -
trunk/Source/WebCore/editing/Editor.cpp
r117574 r117590 1997 1997 bool shouldMarkSpelling = textCheckingOptions & TextCheckingTypeSpelling; 1998 1998 bool shouldMarkGrammar = textCheckingOptions & TextCheckingTypeGrammar; 1999 bool shouldMarkLink = textCheckingOptions & TextCheckingTypeLink; 1999 2000 bool shouldPerformReplacement = textCheckingOptions & TextCheckingTypeReplacement; 2000 2001 bool shouldShowCorrectionPanel = textCheckingOptions & TextCheckingTypeShowCorrectionPanel; … … 2081 2082 continue; 2082 2083 2083 if (!(shouldPerformReplacement || shouldShowCorrectionPanel ) || !doReplacement)2084 if (!(shouldPerformReplacement || shouldShowCorrectionPanel || shouldMarkLink) || !doReplacement) 2084 2085 continue; 2085 2086 -
trunk/Tools/ChangeLog
r117589 r117590 1 2012-05-18 Yi Shen <yi.4.shen@nokia.com> 2 3 REGRESSION (r102553): Smart links do not work 4 https://bugs.webkit.org/show_bug.cgi?id=85463 5 6 Reviewed by Ryosuke Niwa. 7 8 Add LayoutTestController::setAutomaticLinkDetectionEnabled(). 9 10 * DumpRenderTree/LayoutTestController.cpp: 11 (setAutomaticLinkDetectionEnabledCallback): 12 (LayoutTestController::staticFunctions): 13 * DumpRenderTree/LayoutTestController.h: 14 (LayoutTestController): 15 * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: 16 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 17 * DumpRenderTree/chromium/LayoutTestController.cpp: 18 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 19 * DumpRenderTree/chromium/LayoutTestController.h: 20 (LayoutTestController): 21 * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: 22 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 23 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 24 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 25 * DumpRenderTree/mac/LayoutTestControllerMac.mm: 26 (LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled. 27 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: 28 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 29 * DumpRenderTree/qt/LayoutTestControllerQt.h: 30 (LayoutTestController): 31 * DumpRenderTree/win/LayoutTestControllerWin.cpp: 32 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 33 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: 34 (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented. 35 1 36 2012-05-18 Thiago Marcos P. Santos <thiago.santos@intel.com> 2 37 -
trunk/Tools/DumpRenderTree/LayoutTestController.cpp
r117460 r117590 1730 1730 LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject)); 1731 1731 controller->setSmartInsertDeleteEnabled(JSValueToBoolean(context, arguments[0])); 1732 return JSValueMakeUndefined(context); 1733 } 1734 1735 static JSValueRef setAutomaticLinkDetectionEnabledCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception) 1736 { 1737 if (argumentCount < 1) 1738 return JSValueMakeUndefined(context); 1739 1740 LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject)); 1741 controller->setAutomaticLinkDetectionEnabled(JSValueToBoolean(context, arguments[0])); 1732 1742 return JSValueMakeUndefined(context); 1733 1743 } … … 2382 2392 { "setIconDatabaseEnabled", setIconDatabaseEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, 2383 2393 { "setJavaScriptProfilingEnabled", setJavaScriptProfilingEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, 2394 { "setAutomaticLinkDetectionEnabled", setAutomaticLinkDetectionEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, 2384 2395 { "setMainFrameIsFirstResponder", setMainFrameIsFirstResponderCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, 2385 2396 { "setMinimumTimerInterval", setMinimumTimerIntervalCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete }, -
trunk/Tools/DumpRenderTree/LayoutTestController.h
r117460 r117590 102 102 void setJavaScriptProfilingEnabled(bool profilingEnabled); 103 103 void setJavaScriptCanAccessClipboard(bool flag); 104 void setAutomaticLinkDetectionEnabled(bool flag); 104 105 void setMainFrameIsFirstResponder(bool flag); 105 106 void setMockDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma); -
trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp
r117460 r117590 889 889 notImplemented(); 890 890 } 891 892 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 893 { 894 notImplemented(); 895 } -
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
r117460 r117590 2217 2217 } 2218 2218 2219 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 2220 { 2221 // Not Implemented 2222 } 2223 2219 2224 void LayoutTestController::setTextDirection(const CppArgumentList& arguments, CppVariant* result) 2220 2225 { -
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
r117460 r117590 430 430 431 431 void selectionAsMarkup(const CppArgumentList&, CppVariant*); 432 433 // Switch the link detection. 434 void setAutomaticLinkDetectionEnabled(bool); 432 435 433 436 #if ENABLE(POINTER_LOCK) -
trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
r117561 r117590 850 850 ewk_view_visibility_state_set(browser->mainView(), EWK_PAGE_VISIBILITY_STATE_PREVIEW, false); 851 851 } 852 853 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 854 { 855 notImplemented(); 856 } -
trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
r117460 r117590 1029 1029 // FIXME: Implement this. 1030 1030 } 1031 1032 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 1033 { 1034 // FIXME: Implement this. 1035 } -
trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm
r117460 r117590 621 621 } 622 622 623 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool enabled) 624 { 625 [[mainFrame webView] setAutomaticLinkDetectionEnabled:enabled]; 626 } 627 623 628 void LayoutTestController::setTabKeyCyclesThroughElements(bool cycles) 624 629 { -
trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp
r117460 r117590 975 975 } 976 976 977 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 978 { 979 // FIXME: Implement this. 980 } 981 977 982 QString LayoutTestController::layerTreeAsText() 978 983 { -
trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h
r117460 r117590 241 241 void resetPageVisibility(); 242 242 243 void setAutomaticLinkDetectionEnabled(bool); 244 243 245 // Empty stub method to keep parity with object model exposed by global LayoutTestController. 244 246 void abortModal() {} -
trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp
r117460 r117590 1529 1529 // FIXME: Implement this. 1530 1530 } 1531 1532 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 1533 { 1534 // FIXME: Implement this. 1535 } -
trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp
r117460 r117590 648 648 // FIXME: Implement this. 649 649 } 650 651 void LayoutTestController::setAutomaticLinkDetectionEnabled(bool) 652 { 653 // FIXME: Implement this. 654 }
Note: See TracChangeset
for help on using the changeset viewer.