Changeset 117592 in webkit

Timestamp:

May 18, 2012 7:38:14 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
​https://bugs.webkit.org/show_bug.cgi?id=86731

Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-05-18
Reviewed by Simon Hausmann.

Source/WebKit2:

Set the page visibility on a single page instead of on all pages
from the page group.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetPageVisibilityState):

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPageVisibilityState):

• WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Set the page visibility on a single page instead of on all pages
from the page group.

• WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setPageVisibility):
(WTR::LayoutTestController::resetPageVisibility):

LayoutTests:

Unskip fast/events/page-visibility-iframe-move-test.html.

• platform/qt-5.0-wk2/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt-5.0-wk2/Skipped (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (modified) (1 diff)
• Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (modified) (1 diff)
• Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (modified) (1 diff)
• Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-18  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=86731
+
+        Reviewed by Simon Hausmann.
+
+        Unskip fast/events/page-visibility-iframe-move-test.html.
+
+        * platform/qt-5.0-wk2/Skipped:
+
 2012-05-18  Raphael Kubo da Costa  <rakuco@webkit.org>
 

trunk/LayoutTests/platform/qt-5.0-wk2/Skipped

@@ -74 +74 @@
 fast/loader/policy-delegate-action-hit-test-zoomed.html
 
-# Still failing after implementing layoutTestController.setPageVisibility()
-# https://bugs.webkit.org/show_bug.cgi?id=83263
-fast/events/page-visibility-iframe-move-test.html
-
 svg/custom/use-events-crash.svg
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-05-18  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=86731
+
+        Reviewed by Simon Hausmann.
+
+        Set the page visibility on a single page instead of on all pages
+        from the page group.
+
+        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+        (WKBundleSetPageVisibilityState):
+        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::setPageVisibilityState):
+        * WebProcess/InjectedBundle/InjectedBundle.h:
+        (InjectedBundle):
+
 2012-05-18  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp

@@ -242 +242 @@
 }
 
-void WKBundleSetPageVisibilityState(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, int state, bool isInitialState)
-{
-    toImpl(bundleRef)->setPageVisibilityState(toImpl(pageGroupRef), state, isInitialState);
-}
+void WKBundleSetPageVisibilityState(WKBundleRef bundleRef, WKBundlePageRef pageRef, int state, bool isInitialState)
+{
+    toImpl(bundleRef)->setPageVisibilityState(toImpl(pageRef), state, isInitialState);
+}

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h

@@ -91 +91 @@
 WK_EXPORT void WKBundleSwitchNetworkLoaderToNewTestingSession(WKBundleRef bundle);
 
-WK_EXPORT void WKBundleSetPageVisibilityState(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, int state, bool isInitialState);
+WK_EXPORT void WKBundleSetPageVisibilityState(WKBundleRef bundle, WKBundlePageRef page, int state, bool isInitialState);
 
 #ifdef __cplusplus

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

@@ -459 +459 @@
 }
 
-void InjectedBundle::setPageVisibilityState(WebPageGroupProxy* pageGroup, int state, bool isInitialState)
+void InjectedBundle::setPageVisibilityState(WebPage* page, int state, bool isInitialState)
 {
 #if ENABLE(PAGE_VISIBILITY_API)
-    const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
-    for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
-        (*iter)->setVisibilityState(static_cast<PageVisibilityState>(state), isInitialState);
+    page->corePage()->setVisibilityState(static_cast<PageVisibilityState>(state), isInitialState);
 #endif
 }

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h

@@ -157 +157 @@
     static bool isProcessingUserGesture();
 
-    void setPageVisibilityState(WebPageGroupProxy*, int state, bool isInitialState);
+    void setPageVisibilityState(WebPage*, int state, bool isInitialState);
 
 private:

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-18  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=86731
+
+        Reviewed by Simon Hausmann.
+
+        Set the page visibility on a single page instead of on all pages
+        from the page group.
+
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+        (WTR::LayoutTestController::setPageVisibility):
+        (WTR::LayoutTestController::resetPageVisibility):
+
 2012-05-18  Yi Shen  <yi.4.shen@nokia.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp

@@ -555 +555 @@
         visibilityState = WebCore::PageVisibilityStatePreview;
 
-    WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), visibilityState, /* isInitialState */ false);
+    WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().page()->page(), visibilityState, /* isInitialState */ false);
 }
 
 void LayoutTestController::resetPageVisibility()
 {
-    WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), WebCore::PageVisibilityStateVisible, /* isInitialState */ true);
+    WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().page()->page(), WebCore::PageVisibilityStateVisible, /* isInitialState */ true);
 }