Changeset 117599 in webkit

Timestamp:

May 18, 2012 8:57:26 AM (12 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: error when expanding an HTMLAllCollection object in the console
​https://bugs.webkit.org/show_bug.cgi?id=86741

Reviewed by Pavel Feldman.

Source/WebCore:

RuntimeAgent.callFunctionOn should work correcly with arguments of type HTMLAllCollection.

• inspector/InjectedScriptSource.js:

LayoutTests:

• inspector/console/inspect-html-all-collection.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/console/inspect-html-all-collection.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/InjectedScriptSource.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-18  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: error when expanding an HTMLAllCollection object in the console
+        https://bugs.webkit.org/show_bug.cgi?id=86741
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/console/inspect-html-all-collection.html:
+
 2012-05-18  Krzysztof Czech  <k.czech@samsung.com>,  Mariusz Grzegorczyk <mariusz.g@samsung.com>
 

trunk/LayoutTests/inspector/console/inspect-html-all-collection.html

@@ -15 +15 @@
         }
         var htmlAllCollection = WebInspector.RemoteObject.fromPayload(result);
-        htmlAllCollection.callFunctionJSON("function() { return this.length; }", [], didGetLength.bind(this));
+        htmlAllCollection.callFunctionJSON("function(collection) { return this.length + collection.length; }", [{objectId: htmlAllCollection.objectId}], didGetLength.bind(this));
     }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-18  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: error when expanding an HTMLAllCollection object in the console
+        https://bugs.webkit.org/show_bug.cgi?id=86741
+
+        Reviewed by Pavel Feldman.
+
+        RuntimeAgent.callFunctionOn should work correcly with arguments of type HTMLAllCollection.
+
+        * inspector/InjectedScriptSource.js:
+
 2012-05-18  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/inspector/InjectedScriptSource.js

@@ -286 +286 @@
 
                     var resolvedArg = this._objectForId(parsedArgId);
-                    if (!resolvedArg)
+                    if (!this._isDefined(resolvedArg))
                         return "Could not find object with given id";