Changeset 117611 in webkit

Timestamp:

May 18, 2012 12:12:27 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Script elements inserted while fragment parsing should have their "already started" flag set.
​https://bugs.webkit.org/show_bug.cgi?id=86376

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

Step 3 of:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#scriptTag

Test: fast/parser/script-already-started-flag-in-fragment-parsing-mode.html

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::create):

• html/HTMLScriptElement.h:

(HTMLScriptElement):

• html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertScriptElement):

LayoutTests:

• fast/parser/script-already-started-flag-in-fragment-parsing-mode-expected.txt: Added.
• fast/parser/script-already-started-flag-in-fragment-parsing-mode.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/script-already-started-flag-in-fragment-parsing-mode-expected.txt (added)
• LayoutTests/fast/parser/script-already-started-flag-in-fragment-parsing-mode.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLScriptElement.cpp (modified) (1 diff)
• Source/WebCore/html/HTMLScriptElement.h (modified) (1 diff)
• Source/WebCore/html/parser/HTMLConstructionSite.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-18  Pablo Flouret  <pablof@motorola.com>
+
+        Script elements inserted while fragment parsing should have their "already started" flag set.
+        https://bugs.webkit.org/show_bug.cgi?id=86376
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/parser/script-already-started-flag-in-fragment-parsing-mode-expected.txt: Added.
+        * fast/parser/script-already-started-flag-in-fragment-parsing-mode.html: Added.
+
 2012-05-18  Shezan Baig  <shezbaig.wk@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-18  Pablo Flouret  <pablof@motorola.com>
+
+        Script elements inserted while fragment parsing should have their "already started" flag set.
+        https://bugs.webkit.org/show_bug.cgi?id=86376
+
+        Reviewed by Ryosuke Niwa.
+
+        Step 3 of:
+        http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#scriptTag
+
+        Test: fast/parser/script-already-started-flag-in-fragment-parsing-mode.html
+
+        * html/HTMLScriptElement.cpp:
+        (WebCore::HTMLScriptElement::create):
+        * html/HTMLScriptElement.h:
+        (HTMLScriptElement):
+        * html/parser/HTMLConstructionSite.cpp:
+        (WebCore::HTMLConstructionSite::insertScriptElement):
+
 2012-05-18  Shezan Baig  <shezbaig.wk@gmail.com>
 

trunk/Source/WebCore/html/HTMLScriptElement.cpp

@@ -43 +43 @@
 }
 
-PassRefPtr<HTMLScriptElement> HTMLScriptElement::create(const QualifiedName& tagName, Document* document, bool wasInsertedByParser)
+PassRefPtr<HTMLScriptElement> HTMLScriptElement::create(const QualifiedName& tagName, Document* document, bool wasInsertedByParser, bool alreadyStarted)
 {
-    return adoptRef(new HTMLScriptElement(tagName, document, wasInsertedByParser, false));
+    return adoptRef(new HTMLScriptElement(tagName, document, wasInsertedByParser, alreadyStarted));
 }
 

trunk/Source/WebCore/html/HTMLScriptElement.h

@@ -32 +32 @@
 class HTMLScriptElement : public HTMLElement, public ScriptElement {
 public:
-    static PassRefPtr<HTMLScriptElement> create(const QualifiedName&, Document*, bool wasInsertedByParser);
+    static PassRefPtr<HTMLScriptElement> create(const QualifiedName&, Document*, bool wasInsertedByParser, bool alreadyStarted = false);
 
     String text() const { return scriptContent(); }

trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp

@@ -336 +336 @@
 void HTMLConstructionSite::insertScriptElement(AtomicHTMLToken& token)
 {
-    RefPtr<HTMLScriptElement> element = HTMLScriptElement::create(scriptTag, currentNode()->document(), true);
+    RefPtr<HTMLScriptElement> element = HTMLScriptElement::create(scriptTag, currentNode()->document(), true, m_isParsingFragment);
     if (m_fragmentScriptingPermission == FragmentScriptingAllowed)
         element->parserSetAttributes(token.attributes(), m_fragmentScriptingPermission);