Changeset 117624 in webkit


Ignore:
Timestamp:
May 18, 2012 2:01:10 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] Web Intents code is not compiling
https://bugs.webkit.org/show_bug.cgi?id=85364

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-18
Reviewed by Adam Barth.

.:

Remove broken CMake directive for WEB_INTENTS.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add missing implementation for
JSIntentConstructor::constructJSIntent() in JS bindings.

  • CMakeLists.txt:
  • UseJSC.cmake:
  • bindings/js/JSIntentConstructor.cpp: Added.

(WebCore):
(WebCore::JSIntentConstructor::constructJSIntent):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp: Add missing header include.
  • ewk/ewk_intent_private.h: Ditto.
  • ewk/ewk_intent_request.cpp:

(ewk_intent_request_new): Do not PassRefPtr after it becomes 0.

LayoutTests:

Move webintents test cases to test expectations until the needed
features are implemented and Web Intents are enabled by default
for EFL port.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
Location:
trunk
Files:
1 added
12 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r117619 r117624  
     12012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] Web Intents code is not compiling
     4        https://bugs.webkit.org/show_bug.cgi?id=85364
     5
     6        Reviewed by Adam Barth.
     7
     8        Remove broken CMake directive for WEB_INTENTS.
     9
     10        * Source/cmake/OptionsEfl.cmake:
     11
    1122012-05-18  Adrian Bunk  <bunk@stusta.de>
    213
  • trunk/LayoutTests/ChangeLog

    r117622 r117624  
     12012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] Web Intents code is not compiling
     4        https://bugs.webkit.org/show_bug.cgi?id=85364
     5
     6        Reviewed by Adam Barth.
     7
     8        Move webintents test cases to test expectations until the needed
     9        features are implemented and Web Intents are enabled by default
     10        for EFL port.
     11
     12        * platform/efl/Skipped:
     13        * platform/efl/test_expectations.txt:
     14
    1152012-05-18  Joe Thomas  <joethomas@motorola.com>
    216
  • trunk/LayoutTests/platform/efl/Skipped

    r117597 r117624  
    10691069# Microdata DOM API is not yet enabled.
    10701070fast/dom/MicroData
    1071 
    1072 # Web Intents is not yet enabled.
    1073 webintents/
    10741071
    10751072# Pointer Lock is not implemented.
  • trunk/LayoutTests/platform/efl/test_expectations.txt

    r117597 r117624  
    518518BUGWK84167 : tables/mozilla/bugs/bug2479-2.html = IMAGE+TEXT
    519519
     520// Incomplete Web Intents support (disabled by default)
     521BUGWK86866 SKIP : webintents/intent-tag.html = TEXT
     522BUGWK86873 SKIP : webintents/web-intents-api.html = TEXT
     523BUGWK86865 SKIP : webintents/web-intents-delivery.html = TEXT
     524BUGWK86864 SKIP : webintents/web-intents-delivery-reuse.html = TEXT
     525BUGWK86867 SKIP : webintents/web-intents-failure.html = TEXT
     526BUGWK86864 SKIP : webintents/web-intents-invoke.html = TEXT
     527BUGWK86864 SKIP : webintents/web-intents-invoke-port.html = TEXT
     528BUGWK86864 SKIP : webintents/web-intents-obj-constructor.html = TEXT
     529BUGWK86864 SKIP : webintents/web-intents-reload.html = TEXT
     530BUGWK86867 SKIP : webintents/web-intents-reply.html = TEXT
     531
    520532// Needs rebaseline after bug 86441
    521533BUGWK86441 : fast/borders/border-antialiasing.html = IMAGE
  • trunk/Source/WebCore/CMakeLists.txt

    r117420 r117624  
    25162516    )
    25172517    LIST(APPEND WebCore_SOURCES
     2518       Modules/intents/DOMWindowIntents.cpp
    25182519       Modules/intents/Intent.cpp
    25192520       Modules/intents/IntentRequest.cpp
  • trunk/Source/WebCore/ChangeLog

    r117622 r117624  
     12012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] Web Intents code is not compiling
     4        https://bugs.webkit.org/show_bug.cgi?id=85364
     5
     6        Reviewed by Adam Barth.
     7
     8        Add missing implementation for
     9        JSIntentConstructor::constructJSIntent() in JS bindings.
     10
     11        * CMakeLists.txt:
     12        * UseJSC.cmake:
     13        * bindings/js/JSIntentConstructor.cpp: Added.
     14        (WebCore):
     15        (WebCore::JSIntentConstructor::constructJSIntent):
     16
    1172012-05-18  Joe Thomas  <joethomas@motorola.com>
    218
  • trunk/Source/WebCore/UseJSC.cmake

    r116649 r117624  
    288288ENDIF ()
    289289
     290IF (ENABLE_WEB_INTENTS)
     291    LIST (APPEND WebCore_SOURCES
     292        bindings/js/JSIntentConstructor.cpp
     293    )
     294ENDIF ()
     295
    290296LIST(APPEND SCRIPTS_BINDINGS
    291297    ${WEBCORE_DIR}/bindings/scripts/CodeGenerator.pm
  • trunk/Source/WebKit/efl/ChangeLog

    r117617 r117624  
     12012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] Web Intents code is not compiling
     4        https://bugs.webkit.org/show_bug.cgi?id=85364
     5
     6        Reviewed by Adam Barth.
     7
     8        * WebCoreSupport/FrameLoaderClientEfl.cpp: Add missing header include.
     9        * ewk/ewk_intent_private.h: Ditto.
     10        * ewk/ewk_intent_request.cpp:
     11        (ewk_intent_request_new): Do not PassRefPtr after it becomes 0.
     12
    1132012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
    214
  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp

    r117551 r117624  
    5656#include "WebKitVersion.h"
    5757#include "ewk_frame_private.h"
    58 #include "ewk_intent_request.h"
     58#include "ewk_intent_private.h"
    5959#include "ewk_private.h"
    6060#include "ewk_settings_private.h"
  • trunk/Source/WebKit/efl/ewk/ewk_intent_private.h

    r117551 r117624  
    2222
    2323#if ENABLE(WEB_INTENTS)
     24
     25#include "ewk_intent.h"
     26#include "ewk_intent_request.h"
     27
    2428// forward declarations
    2529namespace WebCore {
  • trunk/Source/WebKit/efl/ewk/ewk_intent_request.cpp

    r117551 r117624  
    116116    request->__ref = 1;
    117117    request->core = core;
    118     request->intent = ewk_intent_new(core->intent());
     118    request->intent = ewk_intent_new(request->core->intent());
    119119
    120120    return request;
  • trunk/Source/cmake/OptionsEfl.cmake

    r117551 r117624  
    8282WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO_TRACK ON)
    8383WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO ON)
    84 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_INTENTS, ON)
    8584WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING ON)
    8685WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WORKERS ON)
Note: See TracChangeset for help on using the changeset viewer.