Changeset 117633 in webkit

Timestamp:

May 18, 2012 2:42:31 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Percentage height replaced elements sometimes cause overflow of table contents
​https://bugs.webkit.org/show_bug.cgi?id=85581

Patch by Terry Anderson <​tdanderson@chromium.org> on 2012-05-18
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/replaced/table-replaced-element.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
This change guarantees that the containing block of a replaced element with percentage
height will be marked as having a percentage height descendant.

LayoutTests:

• fast/replaced/table-replaced-element-expected.txt: Added.
• fast/replaced/table-replaced-element.html: Added.

New layout test.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/replaced/table-replaced-element-expected.txt (added)
• LayoutTests/fast/replaced/table-replaced-element.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-18  Terry Anderson  <tdanderson@chromium.org>
+
+        Percentage height replaced elements sometimes cause overflow of table contents
+        https://bugs.webkit.org/show_bug.cgi?id=85581
+
+        Reviewed by Eric Seidel.
+
+        * fast/replaced/table-replaced-element-expected.txt: Added.
+        * fast/replaced/table-replaced-element.html: Added.
+        New layout test.
+
 2012-05-18  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-18  Terry Anderson  <tdanderson@chromium.org>
+
+        Percentage height replaced elements sometimes cause overflow of table contents
+        https://bugs.webkit.org/show_bug.cgi?id=85581
+
+        Reviewed by Eric Seidel.
+
+        Test: fast/replaced/table-replaced-element.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
+        This change guarantees that the containing block of a replaced element with percentage
+        height will be marked as having a percentage height descendant.
+
 2012-05-18  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -2325 +2325 @@
                         return valueForLength(logicalHeight, availableHeight - borderAndPaddingLogicalHeight());
                     }
+                    toRenderBlock(cb)->addPercentHeightDescendant(const_cast<RenderBox*>(this));
                     cb = cb->containingBlock();
-                    toRenderBlock(cb)->addPercentHeightDescendant(const_cast<RenderBox*>(this));
                 }
             }