Changeset 117635 in webkit

Timestamp:

May 18, 2012 2:46:18 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Support imageSmoothingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=82804

Patch by Keyar Hood <​keyar@chromium.org> on 2012-05-18
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled.html

Added the imageSmoothingEnabled parameter to the
CanvasRenderingContext2D object. When it is set to false, it sets
InterpolationQuality to InterpolationNone. When set to true, it sets
the InterpolationQuality to DefaultInterpolationQuality (as that is the
only other value used).

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):

• html/canvas/CanvasRenderingContext2D.h:

(CanvasRenderingContext2D):

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

• fast/canvas/canvas-imageSmoothingEnabled-expected.txt: Added.
• fast/canvas/canvas-imageSmoothingEnabled.html: Added.
• fast/canvas/script-tests/canvas-imageSmoothingEnabled.js: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-expected.txt (added)
• LayoutTests/fast/canvas/canvas-imageSmoothingEnabled.html (added)
• LayoutTests/fast/canvas/script-tests/canvas-imageSmoothingEnabled.js (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (modified) (2 diffs)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.h (modified) (3 diffs)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-18  Keyar Hood  <keyar@chromium.org>
+
+        Support imageSmoothingEnabled
+        https://bugs.webkit.org/show_bug.cgi?id=82804
+
+        Reviewed by Stephen White.
+
+        * fast/canvas/canvas-imageSmoothingEnabled-expected.txt: Added.
+        * fast/canvas/canvas-imageSmoothingEnabled.html: Added.
+        * fast/canvas/script-tests/canvas-imageSmoothingEnabled.js: Added.
+
 2012-05-18  Terry Anderson  <tdanderson@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-18  Keyar Hood  <keyar@chromium.org>
+
+        Support imageSmoothingEnabled
+        https://bugs.webkit.org/show_bug.cgi?id=82804
+
+        Reviewed by Stephen White.
+
+        Test: fast/canvas/canvas-imageSmoothingEnabled.html
+
+        Added the imageSmoothingEnabled parameter to the
+        CanvasRenderingContext2D object. When it is set to false, it sets
+        InterpolationQuality to InterpolationNone. When set to true, it sets
+        the InterpolationQuality to DefaultInterpolationQuality (as that is the
+        only other value used).
+
+        * html/canvas/CanvasRenderingContext2D.cpp:
+        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
+        (WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
+        (WebCore):
+        (WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):
+        * html/canvas/CanvasRenderingContext2D.h:
+        (CanvasRenderingContext2D):
+        * html/canvas/CanvasRenderingContext2D.idl:
+
 2012-05-18  Terry Anderson  <tdanderson@chromium.org>
 

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp

@@ -121 +121 @@
     , m_usesDashboardCompatibilityMode(usesDashboardCompatibilityMode)
 #endif
+    , m_imageSmoothingEnabled(true)
 {
 #if !ENABLE(DASHBOARD_SUPPORT)
@@ -2266 +2267 @@
 #endif
 
+bool CanvasRenderingContext2D::webkitImageSmoothingEnabled() const
+{
+    return m_imageSmoothingEnabled;
+}
+
+void CanvasRenderingContext2D::setWebkitImageSmoothingEnabled(bool enabled)
+{
+    if (enabled == m_imageSmoothingEnabled)
+        return;
+
+    drawingContext()->setImageInterpolationQuality(enabled ? DefaultInterpolationQuality : InterpolationNone);
+    m_imageSmoothingEnabled = enabled;
+}
+
 } // namespace WebCore

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.h

@@ -223 +223 @@
     LineJoin getLineJoin() const { return state().m_lineJoin; }
 
+    bool webkitImageSmoothingEnabled() const;
+    void setWebkitImageSmoothingEnabled(bool);
+
 private:
     struct State : FontSelectorClient {
@@ -327 +330 @@
 #endif
 
-    Path m_path;    
+    Path m_path;
     Vector<State, 1> m_stateStack;
     unsigned m_unrealizedSaveCount;
@@ -334 +337 @@
     bool m_usesDashboardCompatibilityMode;
 #endif
+    bool m_imageSmoothingEnabled;
 };
 

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

@@ -232 +232 @@
 
         readonly attribute float webkitBackingStorePixelRatio;
+
+        attribute boolean webkitImageSmoothingEnabled;
     };