Changeset 117640 in webkit


Ignore:
Timestamp:
May 18, 2012 3:09:51 PM (12 years ago)
Author:
leviw@chromium.org
Message:

Standalone table-columns should be wrapped in anonymous tables
​https://bugs.webkit.org/show_bug.cgi?id=86671

Reviewed by Julien Chaffraix.

Source/WebCore:

The CSS2 spec specifies that table-columns misparented outside of a table or
table-column-group should be wrapped in an anonymous table. Updating
RenderObject::addChild to follow the spec.
see ​http://www.w3.org/TR/CSS2/tables.html#anonymous-boxes for details.

Tests: fast/table/table-column-generates-anonymous-table.html

fast/table/table-column-group-generates-anonymous-table.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):

LayoutTests:

Adding 2 test cases and updating test results for two with changed expectations.

  • fast/table/table-column-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-generates-anonymous-table.html: Added.
  • fast/table/table-column-group-generates-anonymous-table-expected.html: Added.
  • fast/table/table-column-group-generates-anonymous-table.html: Added.
  • platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Added. An anonymous

table is now generated to enclose the misparented table column.

  • platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
  • platform/chromium-linux/fast/table/form-with-table-style-expected.png: Modified. The

expectations previously were wrong in that the table column occupied height the
equivalent of its line-height. This is correctly no longer the case.

  • platform/chromium/test_expectations.txt: Modified. Skipping modified tests on other

platforms until I can rebaseline.

Location:
trunk
Files:
6 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r117639 r117640  
     1        2012-05-17  Levi Weintraub  <leviw@chromium.org>
     2
     3        Standalone table-columns should be wrapped in anonymous tables
     4        https://bugs.webkit.org/show_bug.cgi?id=86671
     5
     6        Reviewed by Julien Chaffraix.
     7
     8        Adding 2 test cases and updating test results for two with changed expectations.
     9
     10        * fast/table/table-column-generates-anonymous-table-expected.html: Added.
     11        * fast/table/table-column-generates-anonymous-table.html: Added.
     12        * fast/table/table-column-group-generates-anonymous-table-expected.html: Added.
     13        * fast/table/table-column-group-generates-anonymous-table.html: Added.
     14        * platform/chromium-linux/fast/forms/form-hides-table-expected.txt: Added. An anonymous
     15        table is now generated to enclose the misparented table column.
     16        * platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
     17        * platform/chromium-linux/fast/table/form-with-table-style-expected.png: Modified. The
     18        expectations previously were wrong in that the table column occupied height the
     19        equivalent of its line-height. This is correctly no longer the case.
     20        * platform/chromium/test_expectations.txt: Modified. Skipping modified tests on other
     21        platforms until I can rebaseline.
     22
    1232012-05-18  Tony Chang  <tony@chromium.org>
    224

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r117613 r117640  
    37463746BUGWK86592 LINUX : http/tests/xmlhttprequest/zero-length-response-sync.html = TIMEOUT PASS
    37473747
     3748// Need rebaselining after patch from WK86671
     3749BUGLEVIW MAC WIN : fast/forms/form-hides-table.html = FAIL PASS
     3750BUGLEVIW MAC WIN : fast/table/form-with-table-style.html = FAIL
     3751
    37483752// strange "Unexpected no expected results found" on cr-linux ews
    37493753BUGWK86600 LINUX : http/tests/cache/loaded-from-cache-after-reload-within-iframe.html = MISSING PASS

  • trunk/Source/WebCore/ChangeLog

    r117635 r117640  
     12012-05-18  Levi Weintraub  <leviw@chromium.org>
     2
     3        Standalone table-columns should be wrapped in anonymous tables
     4        https://bugs.webkit.org/show_bug.cgi?id=86671
     5
     6        Reviewed by Julien Chaffraix.
     7
     8        The CSS2 spec specifies that table-columns misparented outside of a table or
     9        table-column-group should be wrapped in an anonymous table. Updating
     10        RenderObject::addChild to follow the spec.
     11        see http://www.w3.org/TR/CSS2/tables.html#anonymous-boxes for details.
     12
     13        Tests: fast/table/table-column-generates-anonymous-table.html
     14               fast/table/table-column-group-generates-anonymous-table.html
     15
     16        * rendering/RenderObject.cpp:
     17        (WebCore::RenderObject::addChild):
     18
    1192012-05-18  Keyar Hood  <keyar@chromium.org>
    220

  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r117613 r117640  
    272272    bool needsTable = false;
    273273
    274     if (newChild->isTableCol() && newChild->style()->display() == TABLE_COLUMN_GROUP)
     274    if (newChild->style()->display() == TABLE_COLUMN_GROUP)
    275275        needsTable = !isTable();
     276    else if (newChild->style()->display() == TABLE_COLUMN)
     277        needsTable = !isTable() && style()->display() != TABLE_COLUMN_GROUP;
    276278    else if (newChild->isTableCaption())
    277279        needsTable = !isTable();
Note: See TracChangeset for help on using the changeset viewer.