Changeset 117664 in webkit

Timestamp:

May 18, 2012 6:13:55 PM (12 years ago)

Author:

enne@google.com

Message:

[chromium] Add diagnostic CRASH calls for tiler crashes
​https://bugs.webkit.org/show_bug.cgi?id=86930

Reviewed by James Robinson.

These lines would normally crash on their own due to null pointers,
but having an explicit CRASH call will help us differentiate what the
real problem might be in the crash report.

• platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::updateTiles):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/TiledLayerChromium.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-18  Adrienne Walker  <enne@google.com>
+
+        [chromium] Add diagnostic CRASH calls for tiler crashes
+        https://bugs.webkit.org/show_bug.cgi?id=86930
+
+        Reviewed by James Robinson.
+
+        These lines would normally crash on their own due to null pointers,
+        but having an explicit CRASH call will help us differentiate what the
+        real problem might be in the crash report.
+
+        * platform/graphics/chromium/TiledLayerChromium.cpp:
+        (WebCore::TiledLayerChromium::createTile):
+        (WebCore::TiledLayerChromium::updateTiles):
+
 2012-05-18  Aaron Colwell  <acolwell@chromium.org>
 

trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp

@@ -262 +262 @@
 
     addedTile->dirtyRect = m_tiler->tileRect(addedTile);
+
+    // Temporary diagnostic crash.
+    if (!addedTile)
+        CRASH();
+    if (!tileAt(i, j))
+        CRASH();
+
     return addedTile;
 }
@@ -363 +370 @@
             if (!tile)
                 tile = createTile(i, j);
+
+            // Temporary diagnostic crash
+            if (!m_tiler)
+                CRASH();
 
             if (!tile->managedTexture()->isValid(m_tiler->tileSize(), m_textureFormat)) {
@@ -413 +424 @@
         for (int i = left; i <= right; ++i) {
             UpdatableTile* tile = tileAt(i, j);
+            if (!tile)
+                CRASH();
             if (tile->updated)
                 tile->copyAndClearDirty();