Changeset 117696 in webkit
- Timestamp:
- May 19, 2012 1:41:42 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r117695 r117696 1 2012-05-19 Rob Buis <rbuis@rim.com> 2 3 Remove bbox caching from SVGPathElement 4 https://bugs.webkit.org/show_bug.cgi?id=86233 5 6 Reviewed by Nikolas Zimmermann. 7 8 Remove caching of path bounding box, since SVGLocatable::getBBox is not used much at all. 9 This saves 200k of memory for worldcup.svg on 64-bit machine. 10 11 * svg/SVGPathElement.cpp: 12 (WebCore::SVGPathElement::SVGPathElement): 13 (WebCore::SVGPathElement::svgAttributeChanged): 14 (WebCore::SVGPathElement::pathSegListChanged): 15 (WebCore::SVGPathElement::getBBox): 16 * svg/SVGPathElement.h: 17 (SVGPathElement): 18 1 19 2012-05-19 Andy Estes <aestes@apple.com> 2 20 -
trunk/Source/WebCore/svg/SVGPathElement.cpp
r117195 r117696 77 77 , m_pathByteStream(SVGPathByteStream::create()) 78 78 , m_pathSegList(PathSegUnalteredRole) 79 , m_cachedBBoxRectIsValid(false)80 79 , m_isAnimValObserved(false) 81 80 { … … 267 266 buildSVGPathSegListFromByteStream(m_pathByteStream.get(), this, newList, UnalteredParsing); 268 267 m_pathSegList.value = newList; 269 m_cachedBBoxRectIsValid = false;270 268 } 271 269 … … 350 348 invalidateSVGAttributes(); 351 349 352 m_cachedBBoxRectIsValid = false;353 354 350 RenderSVGPath* renderer = static_cast<RenderSVGPath*>(this->renderer()); 355 351 if (!renderer) … … 371 367 return FloatRect(); 372 368 373 if (!m_cachedBBoxRectIsValid) { 374 m_cachedBBoxRect = renderer->path().boundingRect(); 375 m_cachedBBoxRectIsValid = true; 376 } 377 378 return m_cachedBBoxRect; 369 return renderer->path().boundingRect(); 379 370 } 380 371 -
trunk/Source/WebCore/svg/SVGPathElement.h
r117195 r117696 132 132 OwnPtr<SVGPathByteStream> m_pathByteStream; 133 133 mutable SVGSynchronizableAnimatedProperty<SVGPathSegList> m_pathSegList; 134 FloatRect m_cachedBBoxRect;135 bool m_cachedBBoxRectIsValid;136 134 bool m_isAnimValObserved; 137 135 };
Note: See TracChangeset
for help on using the changeset viewer.