Changeset 117736 in webkit
- Timestamp:
- May 21, 2012 12:08:21 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 24 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r117734 r117736 1 2012-05-21 Kentaro Hara <haraken@chromium.org> 2 3 [V8] Pass Isolate to throwNotEnoughArgumentsError() 4 https://bugs.webkit.org/show_bug.cgi?id=86983 5 6 Reviewed by Adam Barth. 7 8 The objective is to pass Isolate around in V8 bindings. 9 This patch passes Isolate to throwNotEnoughArgumentsError(). 10 11 No tests. No change in behavior. 12 13 * bindings/scripts/CodeGeneratorV8.pm: 14 (GenerateArgumentsCountCheck): 15 (GenerateEventConstructorCallback): 16 * bindings/scripts/test/V8/V8Float64Array.cpp: 17 (WebCore::Float64ArrayV8Internal::fooCallback): 18 * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: 19 (WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback): 20 (WebCore::TestActiveDOMObjectV8Internal::postMessageCallback): 21 * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: 22 (WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback): 23 * bindings/scripts/test/V8/V8TestEventConstructor.cpp: 24 (WebCore::V8TestEventConstructor::constructorCallback): 25 * bindings/scripts/test/V8/V8TestEventTarget.cpp: 26 (WebCore::TestEventTargetV8Internal::itemCallback): 27 (WebCore::TestEventTargetV8Internal::dispatchEventCallback): 28 * bindings/scripts/test/V8/V8TestInterface.cpp: 29 (WebCore::TestInterfaceV8Internal::supplementalMethod2Callback): 30 (WebCore::V8TestInterface::constructorCallback): 31 * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: 32 (WebCore::TestMediaQueryListListenerV8Internal::methodCallback): 33 * bindings/scripts/test/V8/V8TestNamedConstructor.cpp: 34 (WebCore::V8TestNamedConstructorConstructorCallback): 35 * bindings/scripts/test/V8/V8TestObj.cpp: 36 (WebCore::TestObjV8Internal::voidMethodWithArgsCallback): 37 (WebCore::TestObjV8Internal::intMethodWithArgsCallback): 38 (WebCore::TestObjV8Internal::objMethodWithArgsCallback): 39 (WebCore::TestObjV8Internal::methodWithSequenceArgCallback): 40 (WebCore::TestObjV8Internal::methodReturningSequenceCallback): 41 (WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback): 42 (WebCore::TestObjV8Internal::serializedValueCallback): 43 (WebCore::TestObjV8Internal::idbKeyCallback): 44 (WebCore::TestObjV8Internal::optionsObjectCallback): 45 (WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback): 46 (WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): 47 (WebCore::TestObjV8Internal::methodWithCallbackArgCallback): 48 (WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback): 49 (WebCore::TestObjV8Internal::overloadedMethod1Callback): 50 (WebCore::TestObjV8Internal::overloadedMethod2Callback): 51 (WebCore::TestObjV8Internal::overloadedMethod3Callback): 52 (WebCore::TestObjV8Internal::overloadedMethod4Callback): 53 (WebCore::TestObjV8Internal::overloadedMethod5Callback): 54 (WebCore::TestObjV8Internal::overloadedMethod6Callback): 55 (WebCore::TestObjV8Internal::overloadedMethod7Callback): 56 (WebCore::TestObjV8Internal::overloadedMethod11Callback): 57 (WebCore::TestObjV8Internal::overloadedMethod12Callback): 58 (WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback): 59 (WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback): 60 (WebCore::TestObjV8Internal::convert1Callback): 61 (WebCore::TestObjV8Internal::convert2Callback): 62 (WebCore::TestObjV8Internal::convert3Callback): 63 (WebCore::TestObjV8Internal::convert4Callback): 64 (WebCore::TestObjV8Internal::convert5Callback): 65 (WebCore::TestObjV8Internal::strictFunctionCallback): 66 (WebCore::V8TestObj::constructorCallback): 67 * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: 68 (WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback): 69 (WebCore::V8TestSerializedScriptValueInterface::constructorCallback): 70 * bindings/v8/ScriptController.cpp: 71 (WebCore::setValueAndClosePopupCallback): 72 * bindings/v8/V8Proxy.cpp: 73 (WebCore::V8Proxy::throwNotEnoughArgumentsError): 74 * bindings/v8/V8Proxy.h: 75 (V8Proxy): 76 * bindings/v8/custom/V8AudioContextCustom.cpp: 77 (WebCore::V8AudioContext::constructorCallback): 78 * bindings/v8/custom/V8DataViewCustom.cpp: 79 (WebCore::V8DataView::getInt8Callback): 80 (WebCore::V8DataView::getUint8Callback): 81 (WebCore::V8DataView::setInt8Callback): 82 (WebCore::V8DataView::setUint8Callback): 83 * bindings/v8/custom/V8DirectoryEntryCustom.cpp: 84 (WebCore::V8DirectoryEntry::getDirectoryCallback): 85 (WebCore::V8DirectoryEntry::getFileCallback): 86 * bindings/v8/custom/V8IntentConstructor.cpp: 87 (WebCore::V8Intent::constructorCallback): 88 * bindings/v8/custom/V8SVGLengthCustom.cpp: 89 (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): 90 * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: 91 (WebCore::getObjectParameter): 92 (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback): 93 (WebCore::V8WebGLRenderingContext::getExtensionCallback): 94 (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback): 95 (WebCore::V8WebGLRenderingContext::getParameterCallback): 96 (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): 97 (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): 98 (WebCore::V8WebGLRenderingContext::getUniformCallback): 99 (WebCore::vertexAttribAndUniformHelperf): 100 (WebCore::uniformHelperi): 101 (WebCore::uniformMatrixHelper): 102 * bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: 103 (WebCore::V8WebKitMutationObserver::constructorCallback): 104 (WebCore::V8WebKitMutationObserver::observeCallback): 105 * bindings/v8/custom/V8WebSocketCustom.cpp: 106 (WebCore::V8WebSocket::constructorCallback): 107 (WebCore::V8WebSocket::sendCallback): 108 * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: 109 (WebCore::V8XMLHttpRequest::openCallback): 110 1 111 2012-05-20 Kentaro Hara <haraken@chromium.org> 2 112 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
r117725 r117736 1527 1527 if ($numMandatoryParams >= 1) { 1528 1528 $argumentsCountCheckString .= " if (args.Length() < $numMandatoryParams)\n"; 1529 $argumentsCountCheckString .= " return V8Proxy::throwNotEnoughArgumentsError( );\n";1529 $argumentsCountCheckString .= " return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate());\n"; 1530 1530 } 1531 1531 return $argumentsCountCheckString; … … 1806 1806 1807 1807 if (args.Length() < 1) 1808 return V8Proxy::throwNotEnoughArgumentsError( );1808 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1809 1809 1810 1810 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, type, args[0]); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8Float64Array.cpp
r115797 r117736 53 53 INC_STATS("DOM.Float64Array.foo"); 54 54 if (args.Length() < 1) 55 return V8Proxy::throwNotEnoughArgumentsError( );55 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 56 56 Float64Array* imp = V8Float64Array::toNative(args.Holder()); 57 57 EXCEPTION_BLOCK(Float32Array*, array, V8Float32Array::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8Float32Array::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestActiveDOMObject.cpp
r115797 r117736 52 52 INC_STATS("DOM.TestActiveDOMObject.excitingFunction"); 53 53 if (args.Length() < 1) 54 return V8Proxy::throwNotEnoughArgumentsError( );54 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 55 55 TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(args.Holder()); 56 56 if (!V8BindingSecurity::canAccessFrame(V8BindingState::Only(), imp->frame(), true)) … … 65 65 INC_STATS("DOM.TestActiveDOMObject.postMessage"); 66 66 if (args.Length() < 1) 67 return V8Proxy::throwNotEnoughArgumentsError( );67 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 68 68 TestActiveDOMObject* imp = V8TestActiveDOMObject::toNative(args.Holder()); 69 69 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, message, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp
r115797 r117736 44 44 INC_STATS("DOM.TestCustomNamedGetter.anotherFunction"); 45 45 if (args.Length() < 1) 46 return V8Proxy::throwNotEnoughArgumentsError( );46 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 47 47 TestCustomNamedGetter* imp = V8TestCustomNamedGetter::toNative(args.Holder()); 48 48 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, str, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
r117507 r117736 74 74 75 75 if (args.Length() < 1) 76 return V8Proxy::throwNotEnoughArgumentsError( );76 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 77 77 78 78 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, type, args[0]); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventTarget.cpp
r116269 r117736 47 47 INC_STATS("DOM.TestEventTarget.item"); 48 48 if (args.Length() < 1) 49 return V8Proxy::throwNotEnoughArgumentsError( );49 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 50 50 TestEventTarget* imp = V8TestEventTarget::toNative(args.Holder()); 51 51 ExceptionCode ec = 0; … … 89 89 INC_STATS("DOM.TestEventTarget.dispatchEvent"); 90 90 if (args.Length() < 1) 91 return V8Proxy::throwNotEnoughArgumentsError( );91 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 92 92 TestEventTarget* imp = V8TestEventTarget::toNative(args.Holder()); 93 93 ExceptionCode ec = 0; -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
r117725 r117736 125 125 INC_STATS("DOM.TestInterface.supplementalMethod2"); 126 126 if (args.Length() < 2) 127 return V8Proxy::throwNotEnoughArgumentsError( );127 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 128 128 TestInterface* imp = V8TestInterface::toNative(args.Holder()); 129 129 ExceptionCode ec = 0; … … 214 214 return args.Holder(); 215 215 if (args.Length() < 1) 216 return V8Proxy::throwNotEnoughArgumentsError( );216 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 217 217 218 218 ExceptionCode ec = 0; -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp
r115797 r117736 45 45 INC_STATS("DOM.TestMediaQueryListListener.method"); 46 46 if (args.Length() < 1) 47 return V8Proxy::throwNotEnoughArgumentsError( );47 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 48 48 TestMediaQueryListListener* imp = V8TestMediaQueryListListener::toNative(args.Holder()); 49 49 EXCEPTION_BLOCK(RefPtr<MediaQueryListListener>, listener, MediaQueryListListener::create(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestNamedConstructor.cpp
r117725 r117736 65 65 66 66 if (args.Length() < 1) 67 return V8Proxy::throwNotEnoughArgumentsError( );67 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 68 68 69 69 ExceptionCode ec = 0; -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
r117725 r117736 1231 1231 INC_STATS("DOM.TestObj.voidMethodWithArgs"); 1232 1232 if (args.Length() < 3) 1233 return V8Proxy::throwNotEnoughArgumentsError( );1233 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1234 1234 TestObj* imp = V8TestObj::toNative(args.Holder()); 1235 1235 EXCEPTION_BLOCK(int, intArg, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1251 1251 INC_STATS("DOM.TestObj.intMethodWithArgs"); 1252 1252 if (args.Length() < 3) 1253 return V8Proxy::throwNotEnoughArgumentsError( );1253 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1254 1254 TestObj* imp = V8TestObj::toNative(args.Holder()); 1255 1255 EXCEPTION_BLOCK(int, intArg, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1270 1270 INC_STATS("DOM.TestObj.objMethodWithArgs"); 1271 1271 if (args.Length() < 3) 1272 return V8Proxy::throwNotEnoughArgumentsError( );1272 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1273 1273 TestObj* imp = V8TestObj::toNative(args.Holder()); 1274 1274 EXCEPTION_BLOCK(int, intArg, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1282 1282 INC_STATS("DOM.TestObj.methodWithSequenceArg"); 1283 1283 if (args.Length() < 1) 1284 return V8Proxy::throwNotEnoughArgumentsError( );1284 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1285 1285 TestObj* imp = V8TestObj::toNative(args.Holder()); 1286 1286 EXCEPTION_BLOCK(sequence<ScriptProfile>*, sequenceArg, toNativeArray<ScriptProfile>(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1293 1293 INC_STATS("DOM.TestObj.methodReturningSequence"); 1294 1294 if (args.Length() < 1) 1295 return V8Proxy::throwNotEnoughArgumentsError( );1295 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1296 1296 TestObj* imp = V8TestObj::toNative(args.Holder()); 1297 1297 EXCEPTION_BLOCK(int, intArg, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1303 1303 INC_STATS("DOM.TestObj.methodThatRequiresAllArgsAndThrows"); 1304 1304 if (args.Length() < 2) 1305 return V8Proxy::throwNotEnoughArgumentsError( );1305 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1306 1306 TestObj* imp = V8TestObj::toNative(args.Holder()); 1307 1307 ExceptionCode ec = 0; … … 1323 1323 INC_STATS("DOM.TestObj.serializedValue"); 1324 1324 if (args.Length() < 1) 1325 return V8Proxy::throwNotEnoughArgumentsError( );1325 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1326 1326 TestObj* imp = V8TestObj::toNative(args.Holder()); 1327 1327 bool serializedArgDidThrow = false; … … 1337 1337 INC_STATS("DOM.TestObj.idbKey"); 1338 1338 if (args.Length() < 1) 1339 return V8Proxy::throwNotEnoughArgumentsError( );1339 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1340 1340 TestObj* imp = V8TestObj::toNative(args.Holder()); 1341 1341 EXCEPTION_BLOCK(RefPtr<IDBKey>, key, createIDBKeyFromValue(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1348 1348 INC_STATS("DOM.TestObj.optionsObject"); 1349 1349 if (args.Length() < 1) 1350 return V8Proxy::throwNotEnoughArgumentsError( );1350 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1351 1351 TestObj* imp = V8TestObj::toNative(args.Holder()); 1352 1352 EXCEPTION_BLOCK(Dictionary, oo, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)); … … 1554 1554 INC_STATS("DOM.TestObj.methodWithNonOptionalArgAndOptionalArg"); 1555 1555 if (args.Length() < 1) 1556 return V8Proxy::throwNotEnoughArgumentsError( );1556 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1557 1557 TestObj* imp = V8TestObj::toNative(args.Holder()); 1558 1558 EXCEPTION_BLOCK(int, nonOpt, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1570 1570 INC_STATS("DOM.TestObj.methodWithNonOptionalArgAndTwoOptionalArgs"); 1571 1571 if (args.Length() < 1) 1572 return V8Proxy::throwNotEnoughArgumentsError( );1572 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1573 1573 TestObj* imp = V8TestObj::toNative(args.Holder()); 1574 1574 EXCEPTION_BLOCK(int, nonOpt, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1622 1622 INC_STATS("DOM.TestObj.methodWithCallbackArg"); 1623 1623 if (args.Length() < 1) 1624 return V8Proxy::throwNotEnoughArgumentsError( );1624 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1625 1625 TestObj* imp = V8TestObj::toNative(args.Holder()); 1626 1626 if (args.Length() <= 0 || !args[0]->IsFunction()) … … 1635 1635 INC_STATS("DOM.TestObj.methodWithNonCallbackArgAndCallbackArg"); 1636 1636 if (args.Length() < 2) 1637 return V8Proxy::throwNotEnoughArgumentsError( );1637 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1638 1638 TestObj* imp = V8TestObj::toNative(args.Holder()); 1639 1639 EXCEPTION_BLOCK(int, nonCallback, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1698 1698 INC_STATS("DOM.TestObj.overloadedMethod1"); 1699 1699 if (args.Length() < 2) 1700 return V8Proxy::throwNotEnoughArgumentsError( );1700 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1701 1701 TestObj* imp = V8TestObj::toNative(args.Holder()); 1702 1702 EXCEPTION_BLOCK(TestObj*, objArg, V8TestObj::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8TestObj::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1710 1710 INC_STATS("DOM.TestObj.overloadedMethod2"); 1711 1711 if (args.Length() < 1) 1712 return V8Proxy::throwNotEnoughArgumentsError( );1712 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1713 1713 TestObj* imp = V8TestObj::toNative(args.Holder()); 1714 1714 EXCEPTION_BLOCK(TestObj*, objArg, V8TestObj::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8TestObj::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1726 1726 INC_STATS("DOM.TestObj.overloadedMethod3"); 1727 1727 if (args.Length() < 1) 1728 return V8Proxy::throwNotEnoughArgumentsError( );1728 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1729 1729 TestObj* imp = V8TestObj::toNative(args.Holder()); 1730 1730 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, strArg, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)); … … 1737 1737 INC_STATS("DOM.TestObj.overloadedMethod4"); 1738 1738 if (args.Length() < 1) 1739 return V8Proxy::throwNotEnoughArgumentsError( );1739 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1740 1740 TestObj* imp = V8TestObj::toNative(args.Holder()); 1741 1741 EXCEPTION_BLOCK(int, intArg, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1748 1748 INC_STATS("DOM.TestObj.overloadedMethod5"); 1749 1749 if (args.Length() < 1) 1750 return V8Proxy::throwNotEnoughArgumentsError( );1750 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1751 1751 TestObj* imp = V8TestObj::toNative(args.Holder()); 1752 1752 if (args.Length() <= 0 || !args[0]->IsFunction()) … … 1761 1761 INC_STATS("DOM.TestObj.overloadedMethod6"); 1762 1762 if (args.Length() < 1) 1763 return V8Proxy::throwNotEnoughArgumentsError( );1763 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1764 1764 TestObj* imp = V8TestObj::toNative(args.Holder()); 1765 1765 EXCEPTION_BLOCK(RefPtr<DOMStringList>, listArg, v8ValueToWebCoreDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1772 1772 INC_STATS("DOM.TestObj.overloadedMethod7"); 1773 1773 if (args.Length() < 1) 1774 return V8Proxy::throwNotEnoughArgumentsError( );1774 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1775 1775 TestObj* imp = V8TestObj::toNative(args.Holder()); 1776 1776 EXCEPTION_BLOCK(RefPtr<DOMStringList>, arrayArg, v8ValueToWebCoreDOMStringList(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); … … 1823 1823 INC_STATS("DOM.TestObj.overloadedMethod11"); 1824 1824 if (args.Length() < 1) 1825 return V8Proxy::throwNotEnoughArgumentsError( );1825 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1826 1826 EXCEPTION_BLOCK(int, arg, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); 1827 1827 TestObj::overloadedMethod1(arg); … … 1837 1837 INC_STATS("DOM.TestObj.overloadedMethod12"); 1838 1838 if (args.Length() < 1) 1839 return V8Proxy::throwNotEnoughArgumentsError( );1839 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1840 1840 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, type, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)); 1841 1841 TestObj::overloadedMethod1(type); … … 1864 1864 INC_STATS("DOM.TestObj.enabledAtRuntimeMethod1"); 1865 1865 if (args.Length() < 1) 1866 return V8Proxy::throwNotEnoughArgumentsError( );1866 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1867 1867 TestObj* imp = V8TestObj::toNative(args.Holder()); 1868 1868 EXCEPTION_BLOCK(int, intArg, V8int::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8int::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1875 1875 INC_STATS("DOM.TestObj.enabledAtRuntimeMethod2"); 1876 1876 if (args.Length() < 1) 1877 return V8Proxy::throwNotEnoughArgumentsError( );1877 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1878 1878 TestObj* imp = V8TestObj::toNative(args.Holder()); 1879 1879 EXCEPTION_BLOCK(int, intArg, V8int::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8int::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1904 1904 INC_STATS("DOM.TestObj.convert1"); 1905 1905 if (args.Length() < 1) 1906 return V8Proxy::throwNotEnoughArgumentsError( );1906 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1907 1907 TestObj* imp = V8TestObj::toNative(args.Holder()); 1908 1908 EXCEPTION_BLOCK(a*, , V8a::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8a::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1915 1915 INC_STATS("DOM.TestObj.convert2"); 1916 1916 if (args.Length() < 1) 1917 return V8Proxy::throwNotEnoughArgumentsError( );1917 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1918 1918 TestObj* imp = V8TestObj::toNative(args.Holder()); 1919 1919 EXCEPTION_BLOCK(b*, , V8b::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8b::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1926 1926 INC_STATS("DOM.TestObj.convert3"); 1927 1927 if (args.Length() < 1) 1928 return V8Proxy::throwNotEnoughArgumentsError( );1928 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1929 1929 TestObj* imp = V8TestObj::toNative(args.Holder()); 1930 1930 EXCEPTION_BLOCK(c*, , V8c::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8c::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1937 1937 INC_STATS("DOM.TestObj.convert4"); 1938 1938 if (args.Length() < 1) 1939 return V8Proxy::throwNotEnoughArgumentsError( );1939 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1940 1940 TestObj* imp = V8TestObj::toNative(args.Holder()); 1941 1941 EXCEPTION_BLOCK(d*, , V8d::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8d::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1948 1948 INC_STATS("DOM.TestObj.convert5"); 1949 1949 if (args.Length() < 1) 1950 return V8Proxy::throwNotEnoughArgumentsError( );1950 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1951 1951 TestObj* imp = V8TestObj::toNative(args.Holder()); 1952 1952 EXCEPTION_BLOCK(e*, , V8e::HasInstance(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)) ? V8e::toNative(v8::Handle<v8::Object>::Cast(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))) : 0); … … 1981 1981 INC_STATS("DOM.TestObj.strictFunction"); 1982 1982 if (args.Length() < 3) 1983 return V8Proxy::throwNotEnoughArgumentsError( );1983 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 1984 1984 TestObj* imp = V8TestObj::toNative(args.Holder()); 1985 1985 ExceptionCode ec = 0; … … 2240 2240 return args.Holder(); 2241 2241 if (args.Length() < 1) 2242 return V8Proxy::throwNotEnoughArgumentsError( );2242 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 2243 2243 if (args.Length() <= 0 || !args[0]->IsFunction()) 2244 2244 return throwError(TYPE_MISMATCH_ERR, args.GetIsolate()); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
r117507 r117736 125 125 INC_STATS("DOM.TestSerializedScriptValueInterface.acceptTransferList"); 126 126 if (args.Length() < 1) 127 return V8Proxy::throwNotEnoughArgumentsError( );127 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 128 128 TestSerializedScriptValueInterface* imp = V8TestSerializedScriptValueInterface::toNative(args.Holder()); 129 129 MessagePortArray messagePortArrayTransferList; … … 219 219 return args.Holder(); 220 220 if (args.Length() < 2) 221 return V8Proxy::throwNotEnoughArgumentsError( );221 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 222 222 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, hello, MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined)); 223 223 MessagePortArray messagePortArrayTransferList; -
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
r116744 r117736 255 255 { 256 256 if (args.Length() < 2) 257 return V8Proxy::throwNotEnoughArgumentsError( );257 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 258 258 DOMWindow* imp = V8DOMWindow::toNative(args.Data()->ToObject()); 259 259 EXCEPTION_BLOCK(int, intValue, toInt32(MAYBE_MISSING_PARAMETER(args, 0, DefaultIsUndefined))); -
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
r117728 r117736 637 637 } 638 638 639 v8::Handle<v8::Value> V8Proxy::throwNotEnoughArgumentsError( )640 { 641 return throwError(TypeError, "Not enough arguments" );639 v8::Handle<v8::Value> V8Proxy::throwNotEnoughArgumentsError(v8::Isolate* isolate) 640 { 641 return throwError(TypeError, "Not enough arguments", isolate); 642 642 } 643 643 -
trunk/Source/WebCore/bindings/v8/V8Proxy.h
r117579 r117736 241 241 // Helpers for throwing syntax and type errors with predefined messages. 242 242 static v8::Handle<v8::Value> throwTypeError(const char* = 0); 243 static v8::Handle<v8::Value> throwNotEnoughArgumentsError( );243 static v8::Handle<v8::Value> throwNotEnoughArgumentsError(v8::Isolate*); 244 244 245 245 v8::Local<v8::Context> context(); -
trunk/Source/WebCore/bindings/v8/custom/V8AudioContextCustom.cpp
r117733 r117736 72 72 // new AudioContext(in unsigned long numberOfChannels, in unsigned long numberOfFrames, in float sampleRate); 73 73 if (args.Length() < 3) 74 return V8Proxy::throwNotEnoughArgumentsError( );74 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 75 75 76 76 bool ok = false; -
trunk/Source/WebCore/bindings/v8/custom/V8DataViewCustom.cpp
r117448 r117736 69 69 INC_STATS("DOM.DataView.getInt8"); 70 70 if (args.Length() < 1) 71 return V8Proxy::throwNotEnoughArgumentsError( );71 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 72 72 73 73 DataView* imp = V8DataView::toNative(args.Holder()); … … 86 86 INC_STATS("DOM.DataView.getUint8"); 87 87 if (args.Length() < 1) 88 return V8Proxy::throwNotEnoughArgumentsError( );88 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 89 89 90 90 DataView* imp = V8DataView::toNative(args.Holder()); … … 103 103 INC_STATS("DOM.DataView.setInt8"); 104 104 if (args.Length() < 2) 105 return V8Proxy::throwNotEnoughArgumentsError( );105 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 106 106 107 107 DataView* imp = V8DataView::toNative(args.Holder()); … … 119 119 INC_STATS("DOM.DataView.setUint8"); 120 120 if (args.Length() < 2) 121 return V8Proxy::throwNotEnoughArgumentsError( );121 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 122 122 123 123 DataView* imp = V8DataView::toNative(args.Holder()); -
trunk/Source/WebCore/bindings/v8/custom/V8DirectoryEntryCustom.cpp
r117733 r117736 52 52 53 53 if (args.Length() < 1) 54 return V8Proxy::throwNotEnoughArgumentsError( );54 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 55 55 56 56 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<WithUndefinedOrNullCheck>, path, args[0]); … … 96 96 97 97 if (args.Length() < 1) 98 return V8Proxy::throwNotEnoughArgumentsError( );98 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 99 99 100 100 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<WithUndefinedOrNullCheck>, path, args[0]); -
trunk/Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp
r117734 r117736 54 54 return args.Holder(); 55 55 if (args.Length() < 1) 56 return V8Proxy::throwNotEnoughArgumentsError( );56 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 57 57 if (args.Length() == 1) { 58 58 // Use the dictionary constructor. This block will return if the -
trunk/Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp
r115670 r117736 91 91 92 92 if (args.Length() < 1) 93 return V8Proxy::throwNotEnoughArgumentsError( );93 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 94 94 95 95 SVGLength& imp = wrapper->propertyReference(); -
trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
r115673 r117736 218 218 { 219 219 if (args.Length() != 2) 220 return V8Proxy::throwNotEnoughArgumentsError( );220 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 221 221 222 222 ExceptionCode ec = 0; … … 270 270 271 271 if (args.Length() < 1) 272 return V8Proxy::throwNotEnoughArgumentsError( );272 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 273 273 274 274 ExceptionCode ec = 0; … … 304 304 WebGLRenderingContext* imp = V8WebGLRenderingContext::toNative(args.Holder()); 305 305 if (args.Length() < 1) 306 return V8Proxy::throwNotEnoughArgumentsError( );306 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 307 307 STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(V8Parameter<>, name, args[0]); 308 308 WebGLExtension* extension = imp->getExtension(name); … … 315 315 316 316 if (args.Length() != 3) 317 return V8Proxy::throwNotEnoughArgumentsError( );317 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 318 318 319 319 ExceptionCode ec = 0; … … 335 335 336 336 if (args.Length() != 1) 337 return V8Proxy::throwNotEnoughArgumentsError( );337 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 338 338 339 339 ExceptionCode ec = 0; … … 353 353 354 354 if (args.Length() != 2) 355 return V8Proxy::throwNotEnoughArgumentsError( );355 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 356 356 357 357 ExceptionCode ec = 0; … … 382 382 383 383 if (args.Length() != 2) 384 return V8Proxy::throwNotEnoughArgumentsError( );384 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 385 385 386 386 ExceptionCode ec = 0; … … 425 425 426 426 if (args.Length() != 2) 427 return V8Proxy::throwNotEnoughArgumentsError( );427 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 428 428 429 429 ExceptionCode ec = 0; … … 496 496 497 497 if (args.Length() != 2) 498 return V8Proxy::throwNotEnoughArgumentsError( );498 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 499 499 500 500 bool ok = false; … … 578 578 579 579 if (args.Length() != 2) 580 return V8Proxy::throwNotEnoughArgumentsError( );580 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 581 581 582 582 WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); … … 692 692 // FIXME: need to change to accept Float32Array as well. 693 693 if (args.Length() != 3) 694 return V8Proxy::throwNotEnoughArgumentsError( );694 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 695 695 696 696 WebGLRenderingContext* context = V8WebGLRenderingContext::toNative(args.Holder()); -
trunk/Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp
r117734 r117736 62 62 63 63 if (args.Length() < 1) 64 return V8Proxy::throwNotEnoughArgumentsError( );64 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 65 65 66 66 v8::Local<v8::Value> arg = args[0]; … … 84 84 INC_STATS("DOM.WebKitMutationObserver.observe"); 85 85 if (args.Length() < 2) 86 return V8Proxy::throwNotEnoughArgumentsError( );86 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 87 87 WebKitMutationObserver* imp = V8WebKitMutationObserver::toNative(args.Holder()); 88 88 EXCEPTION_BLOCK(Node*, target, V8Node::HasInstance(args[0]) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0); -
trunk/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp
r117734 r117736 63 63 64 64 if (args.Length() == 0) 65 return V8Proxy::throwNotEnoughArgumentsError( );65 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 66 66 67 67 v8::TryCatch tryCatch; … … 118 118 119 119 if (!args.Length()) 120 return V8Proxy::throwNotEnoughArgumentsError( );120 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 121 121 122 122 WebSocket* webSocket = V8WebSocket::toNative(args.Holder()); -
trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
r117734 r117736 122 122 123 123 if (args.Length() < 2) 124 return V8Proxy::throwNotEnoughArgumentsError( );124 return V8Proxy::throwNotEnoughArgumentsError(args.GetIsolate()); 125 125 126 126 XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toNative(args.Holder());
Note: See TracChangeset
for help on using the changeset viewer.