Changeset 117873 in webkit


Ignore:
Timestamp:
May 21, 2012 7:31:12 PM (12 years ago)
Author:
haraken@chromium.org
Message:

[V8] Remove V8Proxy::notHandledByInterceptor()
​https://bugs.webkit.org/show_bug.cgi?id=86831

Reviewed by Adam Barth.

This patch replaces 'return V8Proxy::notHandledByInterceptor()'
with 'return v8::Handle<v8::Value>()'. See the discussion in
​https://bugs.webkit.org/show_bug.cgi?id=85330 for more details.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunctionCallback):
(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):

  • bindings/v8/V8Collection.h:

(WebCore::collectionNamedPropertyGetter):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectSetProperty):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::throwError):

  • bindings/v8/V8Proxy.h:

(WebCore):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
(WebCore::V8CSSStyleDeclaration::namedPropertySetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:

(WebCore::npObjectNamedGetter):
(WebCore::npObjectNamedSetter):
(WebCore::npObjectIndexedGetter):
(WebCore::npObjectIndexedSetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyGetter):
(WebCore::storageSetter):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

Location:
trunk/Source/WebCore
Files:
24 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r117868 r117873  
     12012-05-21  Kentaro Hara  <haraken@chromium.org>
     2
     3        [V8] Remove V8Proxy::notHandledByInterceptor()
     4        https://bugs.webkit.org/show_bug.cgi?id=86831
     5
     6        Reviewed by Adam Barth.
     7
     8        This patch replaces 'return V8Proxy::notHandledByInterceptor()'
     9        with 'return v8::Handle<v8::Value>()'. See the discussion in
     10        https://bugs.webkit.org/show_bug.cgi?id=85330 for more details.
     11
     12        No tests. No change in behavior.
     13
     14        * bindings/scripts/CodeGeneratorV8.pm:
     15        (GenerateOverloadedFunctionCallback):
     16        (GenerateParametersCheck):
     17        * bindings/scripts/test/V8/V8TestObj.cpp:
     18        (WebCore::TestObjV8Internal::overloadedMethodCallback):
     19        (WebCore::TestObjV8Internal::overloadedMethod1Callback):
     20        * bindings/v8/V8Collection.h:
     21        (WebCore::collectionNamedPropertyGetter):
     22        * bindings/v8/V8DOMWrapper.cpp:
     23        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
     24        * bindings/v8/V8NPObject.cpp:
     25        (WebCore::npObjectSetProperty):
     26        * bindings/v8/V8Proxy.cpp:
     27        (WebCore::V8Proxy::runScript):
     28        (WebCore::V8Proxy::throwError):
     29        * bindings/v8/V8Proxy.h:
     30        (WebCore):
     31        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
     32        (WebCore::constructWebGLArrayWithArrayBufferArgument):
     33        (WebCore::setWebGLArrayHelper):
     34        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
     35        (WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
     36        (WebCore::V8CSSStyleDeclaration::namedPropertySetter):
     37        * bindings/v8/custom/V8DOMStringMapCustom.cpp:
     38        (WebCore::V8DOMStringMap::namedPropertyGetter):
     39        * bindings/v8/custom/V8DOMWindowCustom.cpp:
     40        (WebCore::V8DOMWindow::indexedPropertyGetter):
     41        (WebCore::V8DOMWindow::namedPropertyGetter):
     42        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
     43        (WebCore::V8HTMLAllCollection::namedPropertyGetter):
     44        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
     45        (WebCore::V8HTMLCollection::namedPropertyGetter):
     46        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
     47        (WebCore::V8HTMLFormElement::indexedPropertyGetter):
     48        (WebCore::V8HTMLFormElement::namedPropertyGetter):
     49        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
     50        (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
     51        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
     52        (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
     53        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
     54        (WebCore::npObjectNamedGetter):
     55        (WebCore::npObjectNamedSetter):
     56        (WebCore::npObjectIndexedGetter):
     57        (WebCore::npObjectIndexedSetter):
     58        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
     59        (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
     60        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
     61        (WebCore::V8NamedNodeMap::indexedPropertyGetter):
     62        (WebCore::V8NamedNodeMap::namedPropertyGetter):
     63        * bindings/v8/custom/V8NodeListCustom.cpp:
     64        (WebCore::V8NodeList::namedPropertyGetter):
     65        * bindings/v8/custom/V8StorageCustom.cpp:
     66        (WebCore::storageGetter):
     67        (WebCore::V8Storage::namedPropertyGetter):
     68        (WebCore::storageSetter):
     69        * bindings/v8/custom/V8StyleSheetListCustom.cpp:
     70        (WebCore::V8StyleSheetList::namedPropertyGetter):
     71        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
     72        (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
     73        (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
     74        (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
     75        (WebCore::V8WebGLRenderingContext::getUniformCallback):
     76        (WebCore::vertexAttribAndUniformHelperf):
     77        (WebCore::uniformHelperi):
     78        (WebCore::uniformMatrixHelper):
     79
    1802012-05-21  Rob Buis  <rbuis@rim.com>
    281

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r117736 r117873  
    13481348    push(@implContentDecls, <<END);
    13491349    V8Proxy::throwTypeError();
    1350     return notHandledByInterceptor();
     1350    return v8::Handle<v8::Value>();
    13511351END
    13521352    push(@implContentDecls, "}\n\n");
    … …  
    16601660                    $parameterCheckString .= "    if (args.Length() > $paramIndex && !isUndefinedOrNull($argValue) && !V8${argType}::HasInstance($argValue)) {\n";
    16611661                    $parameterCheckString .= "        V8Proxy::throwTypeError();\n";
    1662                     $parameterCheckString .= "        return notHandledByInterceptor();\n";
     1662                    $parameterCheckString .= "        return v8::Handle<v8::Value>();\n";
    16631663                    $parameterCheckString .= "    }\n";
    16641664                }

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

    r117736 r117873  
    17971797        return overloadedMethod7Callback(args);
    17981798    V8Proxy::throwTypeError();
    1799     return notHandledByInterceptor();
     1799    return v8::Handle<v8::Value>();
    18001800}
    18011801
    … …  
    18551855        return overloadedMethod12Callback(args);
    18561856    V8Proxy::throwTypeError();
    1857     return notHandledByInterceptor();
     1857    return v8::Handle<v8::Value>();
    18581858}
    18591859

  • trunk/Source/WebCore/bindings/v8/V8Collection.h

    r115068 r117873  
    7575{
    7676    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
    77         return notHandledByInterceptor();
     77        return v8::Handle<v8::Value>();
    7878    if (info.Holder()->HasRealNamedCallbackProperty(name))
    79         return notHandledByInterceptor();
     79        return v8::Handle<v8::Value>();
    8080
    8181    return getNamedPropertyOfCollection<Collection, ItemType>(name, info.Holder(), info.GetIsolate());

  • trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp

    r117374 r117873  
    266266
    267267    ASSERT_NOT_REACHED();
    268     return notHandledByInterceptor();
     268    return v8::Handle<v8::Value>();
    269269}
    270270

  • trunk/Source/WebCore/bindings/v8/V8NPObject.cpp

    r117732 r117873  
    290290            return value; // Intercept the call.
    291291    }
    292     return notHandledByInterceptor();
     292    return v8::Handle<v8::Value>();
    293293}
    294294

  • trunk/Source/WebCore/bindings/v8/V8Proxy.cpp

    r117736 r117873  
    343343{
    344344    if (script.IsEmpty())
    345         return notHandledByInterceptor();
     345        return v8::Local<v8::Value>();
    346346
    347347    V8GCController::checkMemoryUsage();
    … …  
    370370    if (tryCatch.HasCaught()) {
    371371        ASSERT(result.IsEmpty());
    372         return notHandledByInterceptor();
     372        return v8::Local<v8::Value>();
    373373    }
    374374
    375375    if (result.IsEmpty())
    376         return notHandledByInterceptor();
     376        return v8::Local<v8::Value>();
    377377
    378378    if (v8::V8::IsDead())
    … …  
    628628    default:
    629629        ASSERT_NOT_REACHED();
    630         return notHandledByInterceptor();
     630        return v8::Handle<v8::Value>();
    631631    }
    632632}

  • trunk/Source/WebCore/bindings/v8/V8Proxy.h

    r117736 r117873  
    314314    v8::Local<v8::Context> toV8Context(ScriptExecutionContext*, const WorldContextHandle& worldContext);
    315315
    316     // Used by an interceptor callback that it hasn't found anything to
    317     // intercept.
    318     inline static v8::Local<v8::Object> notHandledByInterceptor()
    319     {
    320         return v8::Local<v8::Object>();
    321     }
    322 
    323316    inline v8::Handle<v8::Primitive> throwError(ExceptionCode ec, v8::Isolate* isolate = 0)
    324317    {

  • trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

    r117733 r117873  
    8383    if (!array) {
    8484        V8Proxy::setDOMException(INDEX_SIZE_ERR, args.GetIsolate());
    85         return notHandledByInterceptor();
     85        return v8::Handle<v8::Value>();
    8686    }
    8787    // Transform the holder into a wrapper object for the array.
    … …  
    191191    if (args.Length() < 1) {
    192192        V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate());
    193         return notHandledByInterceptor();
     193        return v8::Handle<v8::Value>();
    194194    }
    195195
    … …  
    232232
    233233    V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate());
    234     return notHandledByInterceptor();
     234    return v8::Handle<v8::Value>();
    235235}
    236236

  • trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

    r117733 r117873  
    196196    // First look for API defined attributes on the style declaration object.
    197197    if (info.Holder()->HasRealNamedCallbackProperty(name))
    198         return notHandledByInterceptor();
     198        return v8::Handle<v8::Value>();
    199199
    200200    // Search the style declaration.
    … …  
    203203    // Do not handle non-property names.
    204204    if (!propInfo)
    205         return notHandledByInterceptor();
     205        return v8::Handle<v8::Value>();
    206206
    207207    CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder());
    … …  
    229229    CSSPropertyInfo* propInfo = cssPropertyInfo(name);
    230230    if (!propInfo)
    231         return notHandledByInterceptor();
     231        return v8::Handle<v8::Value>();
    232232
    233233    String propertyValue = toWebCoreStringWithNullCheck(value);

  • trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp

    r117733 r117873  
    5252    String value = V8DOMStringMap::toNative(info.Holder())->item(toWebCoreString(name));
    5353    if (value.isNull())
    54         return notHandledByInterceptor();
     54        return v8::Handle<v8::Value>();
    5555    return v8StringOrUndefined(value);
    5656}

  • trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

    r117826 r117873  
    477477    DOMWindow* window = V8DOMWindow::toNative(info.Holder());
    478478    if (!window)
    479         return notHandledByInterceptor();
     479        return v8::Handle<v8::Value>();
    480480
    481481    Frame* frame = window->frame();
    482482    if (!frame)
    483         return notHandledByInterceptor();
     483        return v8::Handle<v8::Value>();
    484484
    485485    Frame* child = frame->tree()->scopedChild(index);
    … …  
    487487        return toV8(child->domWindow(), info.GetIsolate());
    488488
    489     return notHandledByInterceptor();
     489    return v8::Handle<v8::Value>();
    490490}
    491491
    … …  
    497497    DOMWindow* window = V8DOMWindow::toNative(info.Holder());
    498498    if (!window)
    499         return notHandledByInterceptor();
     499        return v8::Handle<v8::Value>();
    500500
    501501    Frame* frame = window->frame();
    502502    // window is detached from a frame.
    503503    if (!frame)
    504         return notHandledByInterceptor();
     504        return v8::Handle<v8::Value>();
    505505
    506506    // Search sub-frames.
    … …  
    512512    // Search IDL functions defined in the prototype
    513513    if (!info.Holder()->GetRealNamedProperty(name).IsEmpty())
    514         return notHandledByInterceptor();
     514        return v8::Handle<v8::Value>();
    515515
    516516    // Search named items in the document.
    … …  
    528528    }
    529529
    530     return notHandledByInterceptor();
     530    return v8::Handle<v8::Value>();
    531531}
    532532

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

    r114972 r117873  
    7777
    7878    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
    79         return notHandledByInterceptor();
     79        return v8::Handle<v8::Value>();
    8080    if (info.Holder()->HasRealNamedCallbackProperty(name))
    81         return notHandledByInterceptor();
     81        return v8::Handle<v8::Value>();
    8282
    8383    HTMLAllCollection* imp = V8HTMLAllCollection::toNative(info.Holder());

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLCollectionCustom.cpp

    r117381 r117873  
    6666
    6767    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
    68         return notHandledByInterceptor();
     68        return v8::Handle<v8::Value>();
    6969    if (info.Holder()->HasRealNamedCallbackProperty(name))
    70         return notHandledByInterceptor();
     70        return v8::Handle<v8::Value>();
    7171
    7272    HTMLCollection* imp = V8HTMLCollection::toNative(info.Holder());

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLFormElementCustom.cpp

    r114927 r117873  
    4949    RefPtr<Node> formElement = form->elements()->item(index);
    5050    if (!formElement)
    51         return notHandledByInterceptor();
     51        return v8::Handle<v8::Value>();
    5252    return toV8(formElement.release(), info.GetIsolate());
    5353}
    … …  
    6666        imp->getNamedElements(v, elements);
    6767        if (elements.isEmpty())
    68             return notHandledByInterceptor();
     68            return v8::Handle<v8::Value>();
    6969    }
    7070

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp

    r114927 r117873  
    5858            return toV8(frame->domWindow(), info.GetIsolate());
    5959    }
    60     return notHandledByInterceptor();
     60    return v8::Handle<v8::Value>();
    6161}
    6262

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

    r115068 r117873  
    122122    RefPtr<Node> result = collection->item(index);
    123123    if (!result)
    124         return notHandledByInterceptor();
     124        return v8::Handle<v8::Value>();
    125125
    126126    return toV8(result.release(), info.GetIsolate());

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp

    r117732 r117873  
    5151    ScriptInstance scriptInstance = imp->getInstance();
    5252    if (!scriptInstance)
    53         return notHandledByInterceptor();
     53        return v8::Handle<v8::Value>();
    5454
    5555    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    5656    if (instance.IsEmpty())
    57         return notHandledByInterceptor();
     57        return v8::Handle<v8::Value>();
    5858
    5959    return npObjectGetNamedProperty(instance, name, info);
    … …  
    6666    ScriptInstance scriptInstance = imp->getInstance();
    6767    if (!scriptInstance)
    68         return notHandledByInterceptor();
     68        return v8::Handle<v8::Value>();
    6969
    7070    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    7171    if (instance.IsEmpty())
    72         return notHandledByInterceptor();
     72        return v8::Handle<v8::Value>();
    7373
    7474    return npObjectSetNamedProperty(instance, name, value, info);
    … …  
    136136    ScriptInstance scriptInstance = imp->getInstance();
    137137    if (!scriptInstance)
    138         return notHandledByInterceptor();
     138        return v8::Handle<v8::Value>();
    139139
    140140    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    141141    if (instance.IsEmpty())
    142         return notHandledByInterceptor();
     142        return v8::Handle<v8::Value>();
    143143
    144144    return npObjectGetIndexedProperty(instance, index, info);
    … …  
    152152    ScriptInstance scriptInstance = imp->getInstance();
    153153    if (!scriptInstance)
    154         return notHandledByInterceptor();
     154        return v8::Handle<v8::Value>();
    155155
    156156    v8::Local<v8::Object> instance = v8::Local<v8::Object>::New(scriptInstance->instance());
    157157    if (instance.IsEmpty())
    158         return notHandledByInterceptor();
     158        return v8::Handle<v8::Value>();
    159159
    160160    return npObjectSetIndexedProperty(instance, index, value, info);

  • trunk/Source/WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

    r115068 r117873  
    5252    RefPtr<Node> result = V8HTMLSelectElement::toNative(info.Holder())->item(index);
    5353    if (!result)
    54         return notHandledByInterceptor();
     54        return v8::Handle<v8::Value>();
    5555
    5656    return toV8(result.release(), info.GetIsolate());

  • trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp

    r115372 r117873  
    5050    RefPtr<Node> result = imp->item(index);
    5151    if (!result)
    52         return notHandledByInterceptor();
     52        return v8::Handle<v8::Value>();
    5353
    5454    return toV8(result.release(), info.GetIsolate());
    … …  
    6060
    6161    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
    62         return notHandledByInterceptor();
     62        return v8::Handle<v8::Value>();
    6363    if (info.Holder()->HasRealNamedCallbackProperty(name))
    64         return notHandledByInterceptor();
     64        return v8::Handle<v8::Value>();
    6565
    6666    NamedNodeMap* imp = V8NamedNodeMap::toNative(info.Holder());
    6767    RefPtr<Node> result = imp->getNamedItem(toWebCoreString(name));
    6868    if (!result)
    69         return notHandledByInterceptor();
     69        return v8::Handle<v8::Value>();
    7070
    7171    return toV8(result.release(), info.GetIsolate());

  • trunk/Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp

    r114932 r117873  
    5555    RefPtr<Node> result = list->itemWithName(key);
    5656    if (!result)
    57         return notHandledByInterceptor();
     57        return v8::Handle<v8::Value>();
    5858
    5959    return toV8(result.release(), info.GetIsolate());

  • trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp

    r117734 r117873  
    6262        return v8String(storage->getItem(name));
    6363
    64     return notHandledByInterceptor();
     64    return v8::Handle<v8::Value>();
    6565}
    6666
    … …  
    7676    INC_STATS("DOM.Storage.NamedPropertyGetter");
    7777    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
    78         return notHandledByInterceptor();
     78        return v8::Handle<v8::Value>();
    7979    return storageGetter(name, info);
    8080}
    … …  
    104104
    105105    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(v8Name).IsEmpty())
    106         return notHandledByInterceptor();
     106        return v8::Handle<v8::Value>();
    107107
    108108    ExceptionCode ec = 0;

  • trunk/Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp

    r114972 r117873  
    4545
    4646    if (info.Holder()->HasRealNamedProperty(name))
    47         return notHandledByInterceptor();
     47        return v8::Handle<v8::Value>();
    4848
    4949    // Search style sheet.
    … …  
    5151    HTMLStyleElement* item = imp->getNamedItem(toWebCoreString(name));
    5252    if (!item)
    53         return notHandledByInterceptor();
     53        return v8::Handle<v8::Value>();
    5454
    5555    return toV8(item->sheet(), info.GetIsolate());

  • trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

    r117736 r117873  
    276276    if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLProgram::HasInstance(args[0])) {
    277277        V8Proxy::throwTypeError();
    278         return notHandledByInterceptor();
     278        return v8::Handle<v8::Value>();
    279279    }
    280280    WebGLProgram* program = V8WebGLProgram::HasInstance(args[0]) ? V8WebGLProgram::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
    … …  
    359359    if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLProgram::HasInstance(args[0])) {
    360360        V8Proxy::throwTypeError();
    361         return notHandledByInterceptor();
     361        return v8::Handle<v8::Value>();
    362362    }
    363363    WebGLProgram* program = V8WebGLProgram::HasInstance(args[0]) ? V8WebGLProgram::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
    … …  
    388388    if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLShader::HasInstance(args[0])) {
    389389        V8Proxy::throwTypeError();
    390         return notHandledByInterceptor();
     390        return v8::Handle<v8::Value>();
    391391    }
    392392    WebGLShader* shader = V8WebGLShader::HasInstance(args[0]) ? V8WebGLShader::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
    … …  
    431431    if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLProgram::HasInstance(args[0])) {
    432432        V8Proxy::throwTypeError();
    433         return notHandledByInterceptor();
     433        return v8::Handle<v8::Value>();
    434434    }
    435435    WebGLProgram* program = V8WebGLProgram::HasInstance(args[0]) ? V8WebGLProgram::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
    … …  
    437437    if (args.Length() > 1 && !isUndefinedOrNull(args[1]) && !V8WebGLUniformLocation::HasInstance(args[1])) {
    438438        V8Proxy::throwTypeError();
    439         return notHandledByInterceptor();
     439        return v8::Handle<v8::Value>();
    440440    }
    441441    bool ok = false;
    … …  
    507507        if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLUniformLocation::HasInstance(args[0])) {
    508508            V8Proxy::throwTypeError();
    509             return notHandledByInterceptor();
     509            return v8::Handle<v8::Value>();
    510510        }
    511511        location = toWebGLUniformLocation(args[0], ok);
    … …  
    536536    if (args[1].IsEmpty() || !args[1]->IsArray()) {
    537537        V8Proxy::throwTypeError();
    538         return notHandledByInterceptor();
     538        return v8::Handle<v8::Value>();
    539539    }
    540540    v8::Handle<v8::Array> array =
    … …  
    545545        // FIXME: consider different / better exception type.
    546546        V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate());
    547         return notHandledByInterceptor();
     547        return v8::Handle<v8::Value>();
    548548    }
    549549    ExceptionCode ec = 0;
    … …  
    583583    if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLUniformLocation::HasInstance(args[0])) {
    584584        V8Proxy::throwTypeError();
    585         return notHandledByInterceptor();
     585        return v8::Handle<v8::Value>();
    586586    }
    587587    bool ok = false;
    … …  
    606606    if (args[1].IsEmpty() || !args[1]->IsArray()) {
    607607        V8Proxy::throwTypeError();
    608         return notHandledByInterceptor();
     608        return v8::Handle<v8::Value>();
    609609    }
    610610    v8::Handle<v8::Array> array =
    … …  
    615615        // FIXME: consider different / better exception type.
    616616        V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate());
    617         return notHandledByInterceptor();
     617        return v8::Handle<v8::Value>();
    618618    }
    619619    ExceptionCode ec = 0;
    … …  
    698698    if (args.Length() > 0 && !isUndefinedOrNull(args[0]) && !V8WebGLUniformLocation::HasInstance(args[0])) {
    699699        V8Proxy::throwTypeError();
    700         return notHandledByInterceptor();
     700        return v8::Handle<v8::Value>();
    701701    }
    702702    bool ok = false;
    … …  
    721721    if (args[2].IsEmpty() || !args[2]->IsArray()) {
    722722        V8Proxy::throwTypeError();
    723         return notHandledByInterceptor();
     723        return v8::Handle<v8::Value>();
    724724    }
    725725    v8::Handle<v8::Array> array =
    … …  
    730730        // FIXME: consider different / better exception type.
    731731        V8Proxy::setDOMException(SYNTAX_ERR, args.GetIsolate());
    732         return notHandledByInterceptor();
     732        return v8::Handle<v8::Value>();
    733733    }
    734734    ExceptionCode ec = 0;
Note: See TracChangeset for help on using the changeset viewer.