Changeset 117917 in webkit

Timestamp:

May 21, 2012 11:52:44 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: "Deactivate All Breakpoints" should visually get reflected in Breakpoints pane.
​https://bugs.webkit.org/show_bug.cgi?id=86844

Patch by Sam D <​dsam2912@gmail.com> on 2012-05-21
Reviewed by Pavel Feldman.

Added an option for activate/deactivate breakpoints into Breakpoints
pane section. Style properties has been attached with
breakpoint list to reflect active state of breakpoints.

No new tests. UI Change.

• English.lproj/localizedStrings.js:
• inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

• inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):

• inspector/front-end/inspector.css:

(.breakpoints-list-deactivated):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/BreakpointsSidebarPane.js (modified) (1 diff)
• inspector/front-end/ScriptsPanel.js (modified) (1 diff)
• inspector/front-end/inspector.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-21  Sam D  <dsam2912@gmail.com>
+
+        Web Inspector: "Deactivate All Breakpoints" should visually get reflected in Breakpoints pane.
+        https://bugs.webkit.org/show_bug.cgi?id=86844
+
+        Reviewed by Pavel Feldman.
+
+        Added an option for activate/deactivate breakpoints into Breakpoints
+        pane section. Style properties has been attached with
+        breakpoint list to reflect active state of breakpoints.
+
+        No new tests. UI Change.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/BreakpointsSidebarPane.js:
+        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
+        * inspector/front-end/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
+        * inspector/front-end/inspector.css:
+        (.breakpoints-list-deactivated):
+
 2012-05-21  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js

@@ -172 +172 @@
         var removeAllTitle = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Remove all JavaScript breakpoints" : "Remove All JavaScript Breakpoints");
         contextMenu.appendItem(removeAllTitle, this._breakpointManager.removeAllBreakpoints.bind(this._breakpointManager));
+        
+        var breakpointActive = WebInspector.debuggerModel.breakpointsActive();
+        var breakpointActiveTitle = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints");
+        contextMenu.appendItem(breakpointActiveTitle, WebInspector.debuggerModel.setBreakpointsActive.bind(WebInspector.debuggerModel, !breakpointActive));
         contextMenu.show(event);
     },

trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js

@@ -778 +778 @@
             this._toggleBreakpointsButton.title = WebInspector.UIString("Deactivate all breakpoints.");
             WebInspector.inspectorView.element.removeStyleClass("breakpoints-deactivated");
+            this.sidebarPanes.jsBreakpoints.listElement.removeStyleClass("breakpoints-list-deactivated");
         } else {
             this._toggleBreakpointsButton.title = WebInspector.UIString("Activate all breakpoints.");
             WebInspector.inspectorView.element.addStyleClass("breakpoints-deactivated");
+            this.sidebarPanes.jsBreakpoints.listElement.addStyleClass("breakpoints-list-deactivated");
         }
     },

trunk/Source/WebCore/inspector/front-end/inspector.css

@@ -2140 +2140 @@
 }
 
+.breakpoints-list-deactivated {
+    background-color: rgb(245, 245, 245);
+    opacity: 0.3;
+}
+
 .breakpoint-list li {
     white-space: nowrap;