Changeset 117976 in webkit


Ignore:
Timestamp:
May 22, 2012 8:24:33 AM (12 years ago)
Author:
dmazzoni@google.com
Message:

Chromium AX: Crash when menulist adds selected option via document.write
​https://bugs.webkit.org/show_bug.cgi?id=87028

Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/chromium/accessibility/add-to-menu-list-crashes.html

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):

LayoutTests:

  • platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added.
  • platform/chromium/accessibility/add-to-menu-list-crashes.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r117975 r117976  
     12012-05-22  Dominic Mazzoni  <dmazzoni@google.com>
     2
     3        Chromium AX: Crash when menulist adds selected option via document.write
     4        https://bugs.webkit.org/show_bug.cgi?id=87028
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * platform/chromium/accessibility/add-to-menu-list-crashes-expected.txt: Added.
     9        * platform/chromium/accessibility/add-to-menu-list-crashes.html: Added.
     10
    1112012-05-22  Nikolas Zimmermann  <nzimmermann@rim.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r117975 r117976  
     12012-05-22  Dominic Mazzoni  <dmazzoni@google.com>
     2
     3        Chromium AX: Crash when menulist adds selected option via document.write
     4        https://bugs.webkit.org/show_bug.cgi?id=87028
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Test: platform/chromium/accessibility/add-to-menu-list-crashes.html
     9
     10        * rendering/RenderMenuList.cpp:
     11        (WebCore::RenderMenuList::addChild):
     12
    1132012-05-22  Nikolas Zimmermann  <nzimmermann@rim.com>
    214

  • trunk/Source/WebCore/rendering/RenderMenuList.cpp

    r116476 r117976  
    120120    m_innerBlock->addChild(newChild, beforeChild);
    121121    ASSERT(m_innerBlock == firstChild());
     122
     123    if (AXObjectCache::accessibilityEnabled())
     124        document()->axObjectCache()->childrenChanged(this);
    122125}
    123126
Note: See TracChangeset for help on using the changeset viewer.