Changeset 117979 in webkit

Timestamp:

May 22, 2012 8:57:04 AM (12 years ago)

Author:

haraken@chromium.org

Message:

[V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=87114

Reviewed by Nate Chapin.

GenerateSetDOMException() is used by only one place. This patch removes it.

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-22  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
+        https://bugs.webkit.org/show_bug.cgi?id=87114
+
+        Reviewed by Nate Chapin.
+
+        GenerateSetDOMException() is used by only one place. This patch removes it.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateNormalAttrGetter):
+
 2012-05-22  David Grogan  <dgrogan@chromium.org>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -645 +645 @@
 }
 
-sub GenerateSetDOMException
-{
-    my $indent = shift;
-    my $getIsolate = shift;
-    my $result = "";
-
-    $result .= $indent . "if (UNLIKELY(ec))\n";
-    $result .= $indent . "    return V8Proxy::setDOMException(ec, $getIsolate);\n";
-    return $result;
-}
-
 sub IsSubType
 {
@@ -899 +888 @@
             push(@implContentDecls, "    $nativeType v = $getterString;\n");
         }
-        push(@implContentDecls, GenerateSetDOMException("    ", "info.GetIsolate()"));
+        push(@implContentDecls, "    if (UNLIKELY(ec))\n");
+        push(@implContentDecls, "        return V8Proxy::setDOMException(ec, info.GetIsolate());\n");
 
         if ($codeGenerator->ExtendedAttributeContains($attribute->signature->extendedAttributes->{"CallWith"}, "ScriptState")) {