Changeset 118098 in webkit


Ignore:
Timestamp:
May 22, 2012 7:03:09 PM (12 years ago)
Author:
morrita@google.com
Message:

<shadow> and <content> should be hidden behind ContextEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=87063

This change repalces "runtimeConditional" tag definition property
with new "contextConditional" property, which refers
ContextEnabledFeatures instead of RuntimeEnabledFeatures.

Reviewed by Dimitri Glazkov.

No new tests. DRT cannot test this. No behaviour change on DRT.

  • dom/make_names.pl:

(defaultTagPropertyHash):
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • html/HTMLTagNames.in:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r118096 r118098  
     12012-05-22  MORITA Hajime  <morrita@google.com>
     2
     3        <shadow> and <content> should be hidden behind ContextEnabledFeatures
     4        https://bugs.webkit.org/show_bug.cgi?id=87063
     5
     6        This change repalces "runtimeConditional" tag definition property
     7        with new "contextConditional" property, which refers
     8        ContextEnabledFeatures instead of RuntimeEnabledFeatures.
     9
     10        Reviewed by Dimitri Glazkov.
     11
     12        No new tests. DRT cannot test this. No behaviour change on DRT.
     13
     14        * dom/make_names.pl:
     15        (defaultTagPropertyHash):
     16        (printConstructorInterior):
     17        (printFactoryCppFile):
     18        (printWrapperFunctions):
     19        (printWrapperFactoryCppFile):
     20        * html/HTMLTagNames.in:
     21
    1222012-05-22  Kent Tamura  <tkent@chromium.org>
    223
  • trunk/Source/WebCore/dom/make_names.pl

    r117371 r118098  
    187187        'wrapperOnlyIfMediaIsAvailable' => 0,
    188188        'conditional' => 0,
    189         'runtimeConditional' => 0
     189        'contextConditional' => 0
    190190    );
    191191}
     
    376376    }
    377377
    378     my $runtimeConditional = $enabledTags{$tagName}{runtimeConditional};
    379     if ($runtimeConditional) {
     378    my $contextConditional = $enabledTags{$tagName}{contextConditional};
     379    if ($contextConditional) {
    380380        print F <<END
    381     if (!RuntimeEnabledFeatures::${runtimeConditional}Enabled())
     381    if (!ContextEnabledFeatures::${contextConditional}Enabled(document->domWindow()))
    382382        return 0;
    383383END
     
    805805print F <<END
    806806
    807 #include "RuntimeEnabledFeatures.h"
     807#include "ContextEnabledFeatures.h"
    808808
    809809#if ENABLE(DASHBOARD_SUPPORT) || ENABLE(VIDEO)
     
    10091009END
    10101010;
    1011             } elsif ($enabledTags{$tagName}{runtimeConditional}) {
    1012                 my $runtimeConditional = $enabledTags{$tagName}{runtimeConditional};
     1011            } elsif ($enabledTags{$tagName}{contextConditional}) {
     1012                my $contextConditional = $enabledTags{$tagName}{contextConditional};
    10131013                print F <<END
    10141014static JSDOMWrapper* create${JSInterfaceName}Wrapper(ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr<$parameters{namespace}Element> element)
    10151015{
    1016     if (!RuntimeEnabledFeatures::${runtimeConditional}Enabled()) {
     1016    if (!ContextEnabledFeatures::${contextConditional}Enabled(element->document()->domWindow())) {
    10171017        ASSERT(!element || element->is$parameters{fallbackInterfaceName}());
    10181018        return CREATE_DOM_WRAPPER(exec, globalObject, $parameters{fallbackInterfaceName}, element.get());
     
    10461046END
    10471047;
    1048             } elsif ($enabledTags{$tagName}{runtimeConditional}) {
    1049                 my $runtimeConditional = $enabledTags{$tagName}{runtimeConditional};
     1048            } elsif ($enabledTags{$tagName}{contextConditional}) {
     1049                my $contextConditional = $enabledTags{$tagName}{contextConditional};
    10501050                print F <<END
    10511051static v8::Handle<v8::Value> create${JSInterfaceName}Wrapper($parameters{namespace}Element* element, v8::Isolate* isolate)
    10521052{
    1053     if (!RuntimeEnabledFeatures::${runtimeConditional}Enabled())
     1053    if (!ContextEnabledFeatures::${contextConditional}Enabled(element->document()->domWindow()))
    10541054        return V8$parameters{fallbackInterfaceName}::wrap(to$parameters{fallbackInterfaceName}(element), isolate);
    10551055    return toV8(static_cast<${JSInterfaceName}*>(element), isolate);
     
    11121112    print F <<END
    11131113
    1114 #include "RuntimeEnabledFeatures.h"
     1114#include "ContextEnabledFeatures.h"
    11151115
    11161116#if ENABLE(VIDEO)
  • trunk/Source/WebCore/html/HTMLTagNames.in

    r116384 r118098  
    3232colgroup interfaceName=HTMLTableColElement
    3333command interfaceName=HTMLElement
    34 content interfaceName=HTMLContentElement, conditional=SHADOW_DOM, runtimeConditional=shadowDOM
     34content interfaceName=HTMLContentElement, conditional=SHADOW_DOM, contextConditional=shadowDOM
    3535webkitShadowContent interfaceName=HTMLElement, noConstructor
    3636datalist interfaceName=HTMLDataListElement, conditional=DATALIST
     
    9696option
    9797output constructorNeedsFormElement
    98 shadow interfaceName=HTMLShadowElement, conditional=SHADOW_DOM, runtimeConditional=shadowDOM
     98shadow interfaceName=HTMLShadowElement, conditional=SHADOW_DOM, contextConditional=shadowDOM
    9999p interfaceName=HTMLParagraphElement
    100100param
Note: See TracChangeset for help on using the changeset viewer.